Integrated: JDK-8288531: Empty spans in mobile navigation markup
Hannes Wallnöfer
hannesw at openjdk.org
Tue Jun 21 16:06:42 UTC 2022
On Tue, 21 Jun 2022 12:40:14 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
> The empty spans in the mobile navigation button are removed with a warning by HTML Tidy in the default setting.
>
> I tried three different solutions:
>
> - Add a normal space character: this did not satisfy HTML Tidy, it still removed the spans with a warning.
> - Add an HTML comment: this stopped HTML Tidy from removing the spans, but the three comments added a lot of visual noise.
> - Add a ` ` entity: this stops HTML Tidy from removing the spans, doesn't add too much to the page and does not affect the layout.
>
> I went with the third option after making sure the layout is not affected (tested on Chrome, Firefox, Safari on macOS as well as Safari on iOS and Chrome on Android). Behaviour of HTML Tidy was tested with version 5.8.0 on macOS.
This pull request has now been integrated.
Changeset: c74a9235
Author: Hannes Wallnöfer <hannesw at openjdk.org>
URL: https://git.openjdk.org/jdk19/commit/c74a9235fc4526d9954ba3cedd14bbb370217570
Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
8288531: Empty spans in mobile navigation markup
Reviewed-by: jjg
-------------
PR: https://git.openjdk.org/jdk19/pull/53
More information about the javadoc-dev
mailing list