RFR: JDK-8286101: Support formatting in @value tag [v3]
Pavel Rappo
prappo at openjdk.org
Wed Jun 22 12:09:45 UTC 2022
On Wed, 22 Jun 2022 11:48:43 GMT, ExE Boss <duke at openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - fix typo
>> - Merge remote-tracking branch 'upstream/master' into 8286101.format-at-value
>> - address review feedback
>> - address review feedback
>> - Merge remote-tracking branch 'upstream/master' into 8286101.format-at-value
>> - JDK-8286101: Support formatting in @value tag
>
> src/jdk.compiler/share/classes/com/sun/source/util/DocTreeFactory.java line 423:
>
>> 421: *
>> 422: * @implSpec This implementation calls {@link #newValueTree(ReferenceTree) newValueTree(ref)}.
>> 423: * @since 19
>
> [ditto](https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/8565*discussion_r903643787__;Iw!!ACWV5N9M2RV99hQ!NpigilPyeaBHKXhe8SJPQK_SSa0M4rRoVhAK2_ihD8m_ZYW_Fhy_xAQfmxVVKcd2QYwo8bBDXPkcYE_oH7WBfQ$ )
Those `@since` tags were correct when the PR was approved, but became outdated on the 9th of June. What can I say? A PR has a shelf life.
Those tags should be fixed. @jonathan-gibbons, please file a bug and I will review it. @ExE-Boss, thanks for noticing.
-------------
PR: https://git.openjdk.org/jdk/pull/8565
More information about the javadoc-dev
mailing list