RFR: JDK-8286153: Remove redundant casts and other cleanup [v2]

[Jonathan Gibbons]

On Thu, 5 May 2022 23:51:59 GMT, liach <duke at openjdk.java.net> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address review feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/ClassUseMapper.java line 224:
> 
>> 222:                 mapTypeParameters(classToFieldTypeParam, fd, fd);
>> 223:                 mapAnnotations(annotationToField, fd, fd);
>> 224:                  var stv = new SimpleTypeVisitor9<Void, VariableElement>() {
> 
> Extra space before `var`

Thanks, will fix.

> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java line 1528:
> 
>> 1526:             instance.setStrength(strength);
>> 1527: 
>> 1528:             keys = new LinkedHashMap<>(MAX_SIZE + 1, 0.75f, true) {
> 
> This map's initial capacity requires it to resize before it starts evicting, see https://github.com/openjdk/jdk/blob/7ebc4bce930e7d406f1e68c8bd09ac1dc3a21e5a/src/java.base/share/classes/java/util/HashMap.java#L2563
> 
> Can either increase the initial capacity or change the load factor to 1.0f.

Not in this PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8543