RFR: JDK-8277420: Provide a way to copy the hyperlink to a doc element to the clipboard [v3]
Pavel Rappo
prappo at openjdk.java.net
Fri May 27 08:54:44 UTC 2022
On Fri, 27 May 2022 07:16:23 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
>> This is a CSS/JavaScript only change to implement copy-to-clipboard functionality for all headers (`h1` - `h6`) that have an `id` attribute associated with them. The following element-attribute patterns are supported (using `<h2>` as an example):
>>
>> - `<section id="..."><h2>` (generated by javadoc)
>> - `<h2 id="...">` (commonly used)
>> - `<h2><a id="...">` (legacy)
>>
>> The change includes a consolidation of the CSS styles used to render copy-to-clipboard buttons, of which we have now three kinds: for snippets, for the link on the search page, and for headers. There is now a base CSS class called "copy" that defines the styles shared by all copy-to-clipboard buttons, and additional CSS properties for the concrete "subclasses".
>>
>> API docs generated with this change can be viewed here (top level files and java.base module):
>> http://cr.openjdk.java.net/~hannesw/8277420/api.03/
>
> Hannes Wallnöfer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Update new snippet test for CSS changes
> - Merge branch 'master' into JDK-8277420
> - Fix jquery selector for anchor within header
> - Clean up copy-to-clipboard button styles
> - JDK-8277420: Provide a way to copy the hyperlink to a doc element to the clipboard
Marked as reviewed by prappo (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/8817
More information about the javadoc-dev
mailing list