RFR: JDK-8287337: SnippetUtils should throw exceptions if snippets not found

Hannes Wallnöfer hannesw at openjdk.java.net
Tue May 31 16:04:47 UTC 2022


On Wed, 25 May 2022 19:38:13 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple change for `SnippetUtils` to throw a checked exception if a snippet cannot be found.

Looks good to me. I'm not sure the `requireNonNull` method carries its own weight given that one `getSnippetById` method could by implemented by calling the other, but that's a minor stylistic concern.

-------------

Marked as reviewed by hannesw (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8892


More information about the javadoc-dev mailing list