RFR: 8285488: Improve DocFinder [v3]

[Jonathan Gibbons]

On Mon, 24 Oct 2022 21:59:29 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java line 365:
>> 
>>> 363:         var subtypeTestInapplicable = t.getKind() == TypeKind.EXECUTABLE
>>> 364:                 || t.getKind() == TypeKind.PACKAGE
>>> 365:                 || t.getKind() == TypeKind.MODULE;
>> 
>> Just asking ... would this be more concise as an enhanced switch expression?
>
> A `switch` expression will likely look uglier than you might think. Care to suggest such an expression? Performance implications aside, perhaps an `EnumSet` could be more readable.

How about:

var subtypeTestInapplicable = switch (t.getKind()) {
    case EXECUTABLE, PACKAGE, MODULE -> yield true;
    default yield false;
}

-------------

PR: https://git.openjdk.org/jdk/pull/10746