RFR: 8285488: Improve DocFinder [v4]

Jonathan Gibbons jjg at openjdk.org
Tue Nov 15 18:31:12 UTC 2022


On Tue, 1 Nov 2022 14:45:49 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java line 782:
>> 
>>> 780:         }
>>> 781:         var enclosingElementDescription = detailedDescriptionOf(e.getEnclosingElement());
>>> 782:         return enclosingElementDescription + " " + thisElementDescription;
>> 
>> A named package is enclosed by a module, although it may be the unnamed module for >= JDK 9.
>> A well-formed named module never has an unnamed package.
>> 
>> Consider return empty string from the switch and dealing with that in the `return` statement.
>> 
>> That being said, who uses this info where: you're including the raw element kind in the result, so is this mostly for debugging?
>
> It will need to be better stringified and i18n-zed. That output is not for debugging, it's for diagnosing.

I see the preceding TODOs.

-------------

PR: https://git.openjdk.org/jdk/pull/10746


More information about the javadoc-dev mailing list