RFR: JDK-8290845: Consider an alternative item separator for multi-item option values [v3]

Pavel Rappo prappo at openjdk.org
Fri Nov 18 22:21:16 UTC 2022


On Fri, 18 Nov 2022 21:21:20 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a medium simple update to prefer the use of comma (`,`) instead of colon (`:`) in certain options taking a list of values.    Options taking a search path (like `--class-path`, `--source-path`, etc) are **not** affected.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix man page header

Marked as reviewed by prappo (Reviewer).

Looks good to me.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java line 520:

> 518:      * @return an array of tokens
> 519:      */
> 520:     private List<String> tokenize(String s, int maxTokens) {

Not saying that we should do anything about it, but I would be surprised if there were no such tokenization functionality in the JDK API.

-------------

PR: https://git.openjdk.org/jdk/pull/11178Marked as reviewed by prappo (Reviewer).


More information about the javadoc-dev mailing list