RFR: 8297091: New langtools test jdk/javadoc/doclet/testValueTag/TestValueFormats.java fails on machines with unexpected number format

Christoph Langer clanger at openjdk.org
Tue Nov 22 21:00:25 UTC 2022


On Tue, 22 Nov 2022 11:08:03 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The new test langtools/jdk/javadoc/doclet/testValueTag/TestValueFormats.java assumes a number format with a decimal separator dot (.). This can be different in other locales.
>> 
>> This fixes the issue by expecting a number format that is calculated at runtime, with the locale settings the test runs in. Not sure if it is the correct way to fix, though.
>
> So this PR is good as is?

> @RealCLanger yes, you're good to go.
> 
> The next step is for you to enter `/integrate` as a comment.

Thanks, @jonathan-gibbons, for approving. Technically I know what to do to get this merged. I just wasn't sure whether you were ok with the fix or suggesting something different. So...

-------------

PR: https://git.openjdk.org/jdk/pull/11177


More information about the javadoc-dev mailing list