RFR: JDK-8297216: Search results omit some methods

[Jonathan Gibbons]

On Tue, 22 Nov 2022 14:38:34 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

> Please review a fix for a bug where a method's parameter type could "mask" a method and result in the method to not appear in the search results. The fix consists in checking whether a match covers an element's name in the match loop. 
> 
> Note that the added test must be run manually as it requires GraalVM JS (or some other JS engine) to be installed. In addition to running the test I did extensive A/B testing to make sure search results remain unchanged apart from the bug fix.

Minor question about a minor nit: a duplicate option in a test.

test/langtools/jdk/javadoc/doclet/testSearchScript/TestSearchScript.java line 345:

> 343:                 "-Xdoclint:none",
> 344:                 "-use",
> 345:                 "-use",

double `-use` ... is that intentional?

-------------

Marked as reviewed by jjg (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11287