RFR: JDK-8290126: Add a check in JavadocTester for "javadoc should not crash" [v6]

Pavel Rappo prappo at openjdk.org
Thu Sep 1 21:09:06 UTC 2022


On Thu, 1 Sep 2022 19:00:25 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a simple update to `JavadocTester` to provide a default-on check that no stack traces were written to the STDERR stream.
>> 
>> There are also some minor cleanup edits suggested by the IDE.
>
> Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - fix broken test
>  - Merge remote-tracking branch 'upstream/master' into 8290126.javadoctester-checkCrash
>  - improve check in JavadocTester
>    remove obsolete/now-broken check from DocTest.java
>  - Merge remote-tracking branch 'upstream/master' into 8290126.javadoctester-checkCrash
>  - Merge remote-tracking branch 'upstream/master' into 8290126.javadoctester-checkCrash
>  - revert (defer) improvement of TagletManager error message; fix TestTFMBuilder.java
>  - Respond to review feedback; add new test
>  - JDK-8290126: Add a check in JavadocTester for "javadoc should not crash"

It would be great if you could update the copyright year in TestTFMBuilder.java.

-------------

Marked as reviewed by prappo (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9458


More information about the javadoc-dev mailing list