RFR: 8292892: Javadoc index descriptions are not deterministic [v2]

John Neffenger jgneff at openjdk.org
Tue Sep 6 21:52:36 UTC 2022


On Mon, 5 Sep 2022 10:44:12 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> John Neffenger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename test class members and rewrite its comments
>
> test/langtools/jdk/javadoc/doclet/testIndexInherited/pkg1/ClassB.java line 34:
> 
>> 32:      */
>> 33:     public ClassB() {
>> 34:     }
> 
> One nit: here and elsewhere in this PR an explicit no-arg (parameterless, nullary, etc.) constructor is called _default_, which, technically speaking, it isn't. If a constructor is _default_, then it is implicit. Once you make it explicit, it is no longer _default_. A _default_ constructor is provided by the compiler, when there are no other constructors defined, see: JLS 8.8.9. Default Constructor.

Fixed. Thank you, Pavel. I wondered that exact question while writing the comment, but I didn't bother to look it up. Thanks for taking the time to let me know. I changed the comments to "sole constructor."

-------------

PR: https://git.openjdk.org/jdk/pull/10070


More information about the javadoc-dev mailing list