RFR: JDK-8302324: Inheritance tree does not show correct type parameters/arguments [v2]

Hannes Wallnöfer hannesw at openjdk.org
Tue Feb 14 12:35:14 UTC 2023


> Please review a simple change to show the correct type parameters or arguments in the inheritance list in the class documentation header. The solution is simply to move the implementation of `Utils.getFirstVisibleSuperClass(...)` from the method with a `TypeElement` parameter to the one with a `TypeMirror` parameter, thereby preserving the type arguments.
> 
> I compared JDK API docs with and without this change, and the only change is that inheritance with generic superclasses is now rendered correctly. For instance, the inheritance list for `java.util.Properties` used to look like this:
> 
> 
> java.lang.Object
>     java.util.Dictionary<K,V>
>         java.util.Hashtable<Object,Object>
>             java.util.Properties
> 
> Now it is generated as follows:
> 
> java.lang.Object
>     java.util.Dictionary<Object,Object>
>         java.util.Hashtable<Object,Object>
>             java.util.Properties

Hannes Wallnöfer has updated the pull request incrementally with three additional commits since the last revision:

 - Update test/langtools/jdk/javadoc/doclet/testInheritance/TestInheritance.java
   
   Co-authored-by: Pavel Rappo <32523691+pavelrappo at users.noreply.github.com>
 - Update test/langtools/jdk/javadoc/doclet/testInheritance/TestInheritance.java
   
   Co-authored-by: Pavel Rappo <32523691+pavelrappo at users.noreply.github.com>
 - Update test/langtools/jdk/javadoc/doclet/testInheritance/TestInheritance.java
   
   Co-authored-by: Pavel Rappo <32523691+pavelrappo at users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12544/files
  - new: https://git.openjdk.org/jdk/pull/12544/files/f2b94e2d..c0859657

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12544&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12544&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/12544.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12544/head:pull/12544

PR: https://git.openjdk.org/jdk/pull/12544


More information about the javadoc-dev mailing list