RFR: JDK-8298405: Support Markdown in the standard doclet

Jonathan Gibbons jjg at openjdk.org
Mon Jan 9 15:52:59 UTC 2023


On Mon, 9 Jan 2023 10:13:54 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> src/jdk.javadoc/share/classes/jdk/internal/org/commonmark/internal/Bracket.java line 48:
>> 
>>> 46:     public boolean bracketAfter = false;
>>> 47: 
>>> 48:     static public Bracket link(Text node, Position markerPosition, Position contentPosition, Bracket previous, Delimiter previousDelimiter) {
>> 
>> Let's use blessed modifiers order
>> Suggestion:
>> 
>>     public static Bracket link(Text node, Position markerPosition, Position contentPosition, Bracket previous, Delimiter previousDelimiter) {
>
> This class belongs to a 3rd party library, CommonMark. Changes that aren't necessary for the library to work in the JDK or not related to security might not be worth it.

Agreed that we should not do "cosmetic" changes on imported code.

-------------

PR: https://git.openjdk.org/jdk/pull/11701


More information about the javadoc-dev mailing list