RFR: JDK-8309566: Migrate away from TagletWriter and TagletWriterImpl [v3]

[Jonathan Gibbons]

On Wed, 12 Jul 2023 13:47:11 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve comments
>>   Convert `InheritableTaglet` to just a marker interface.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/taglets/SummaryTaglet.java line 44:
> 
>> 42: public class SummaryTaglet extends BaseTaglet {
>> 43: 
>> 44:     public SummaryTaglet(HtmlConfiguration config) {
> 
> This constructor could have package access similarly to those of other taglets.

Yes, already found and fixed that one, while checking a similar instance earlier.

> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/taglets/package-info.java line 37:
> 
>> 35:  * context. In general, inline tags always generate some (non-empty) output,
>> 36:  * even if the output is some form indicating an error. It is almost never
>> 37:  * correct to not generate any output to fill the between the parts of the
> 
>> fill the between the parts
> 
> Is it just me or it reads weird?

Not just you. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14793#discussion_r1261719152
PR Review Comment: https://git.openjdk.org/jdk/pull/14793#discussion_r1261718669