RFR: JDK-8312445: Array types in annotation elements show square brackets twice [v2]

Hannes Wallnöfer hannesw at openjdk.org
Wed Jul 26 09:11:20 UTC 2023


> Please review a change to fix the representation of array types as values of annotation elements in javadoc-generated documentation.
> 
> The primary fix is to avoid generating duplicate `[]` brackets for array types, but there are a few secondary improvements:
> 
>  - When linking to a type, only use the type name as link label, appending the `.class` as plain text after the link
>  - Support linking to the base type of array types, again appending the square brackets and `.class` after the link
>  - Leave it to the `LinkFactory` code to decide whether to use the qualified or simple type name for a link (uses `isLinkable` instead of `isIncluded`)
> 
> There already was some test code for the use of array types in annotation elements in `TestNewLanguageFeatures.java`, but it was disabled with a comment referring to another issue that has long been resolved.

Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:

  Address review feedback

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15019/files
  - new: https://git.openjdk.org/jdk/pull/15019/files/706c8a5f..a176dd82

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15019&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15019&range=00-01

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/15019.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15019/head:pull/15019

PR: https://git.openjdk.org/jdk/pull/15019


More information about the javadoc-dev mailing list