RFR: JDK-8313204: Inconsistent order of sections in generated class documentation [v2]
Pavel Rappo
prappo at openjdk.org
Fri Jul 28 17:09:58 UTC 2023
On Fri, 28 Jul 2023 17:05:08 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Please review a minor change to `ClassWriter` to make the order of sections consistent across member-kinds and between summary and detail sections. The change to `ClassWriter` is just to reorder the sections, and to add some explanatory comments.
>>
>> One test detected the change and is therefore updated.
>> Another test is updated to include a check for the section ordering.
>>
>> Note: the changes to `ClassWriter` may soon be superseded by work on [JDK-8312201](https://bugs.openjdk.org/browse/JDK-8312201). The primary goal of this PR is to establish the preferred order and update the tests accordingly.
>
> Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge remote-tracking branch 'upstream/master' into 8313204.member-order
> - JDK-8313204: Inconsistent order of sections in generated class documentation
Thanks for checking with the JavaFX team.
Looks good to me.
-------------
Marked as reviewed by prappo (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15046#pullrequestreview-1552527849
More information about the javadoc-dev
mailing list