RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents [v4]

KIRIYAMA Takuya duke at openjdk.org
Thu Jun 15 05:13:16 UTC 2023


On Tue, 13 Jun 2023 16:30:50 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin' into 8306980
>>  - 8306980: Generated docs should contain correct GPLv2 Legal Documents
>>  - 8306980: Generated docs should contain correct GPLv2 Legal Documents
>>  - 8306980: Generated docs should contain correct GPLv2 Legal Documents
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java line 383:
> 
>> 381:                                     entry = descriptive_link;
>> 382:                                 }
>> 383:                             } catch(InvalidPathException e) {}
> 
> nit
> Suggestion:
> 
>                             } catch (InvalidPathException e) {}

Thank you for your suggestion. I fixed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13686#discussion_r1230433101


More information about the javadoc-dev mailing list