RFR: JDK-8309471: Limit key characters in static index pages [v4]

[Hannes Wallnöfer]

On Fri, 16 Jun 2023 14:45:37 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Hannes Wallnöfer has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Include sections in index pages but restrict key characters
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/IndexBuilder.java line 307:
> 
>> 305:         for (int i = 0; i < s.length(); i++) {
>> 306:             if (Character.isJavaIdentifierStart(s.charAt(i))) {
>> 307:                 return Character.toUpperCase(s.charAt(i));
> 
> maybe use the overload that takes a locale, and use `Locale.ROOT`

I just learned that `Character.toUpperCase` does not have a locale-sensitive overload, we'd have to use `String.toUpperCase` for that. I don't think it's that important in this case, so I'm leaving the code as it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14312#discussion_r1232372853