RFR: 8300517: Refactor VisibleMemberTable (method members) [v2]

[Pavel Rappo]

On Fri, 10 Mar 2023 19:44:33 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to feedback
>
> Approved, although there are still some outstanding suggestions for comments.
> 
> Generally, this is obviously a big project, so well done on progress so far.
> 
> It is well worth aligning the functionality and terminology of this code with current JLS, and so I (generally) encourage JLS references in key places, preferably in a stylized manner (to facilitate checking and/or updates).
> 
> I also think it is worth adding notes comparing the functionality here with that of plain-old `Elements.getAllMembers`.  That is a simple building block that returns a list-y set of the members of a `TypeElement`, but VMT needs to do more:
> * handle members of so-called hidden types
> * build a DAG for each method, relating that method to corresponding methods in the supertypes of the type element, for use by `@link` and `Specified By:`.
> * ...

@jonathan-gibbons, while I haven't addressed all your review comments, I believe I addressed the most important ones.

Unaddressed comments will either be explicitly addressed in upcoming PRs or will become irrelevant as a result of code change in those PRs.

-------------

PR: https://git.openjdk.org/jdk/pull/12887