Integrated: 8300517: Refactor VisibleMemberTable (method members)
Pavel Rappo
prappo at openjdk.org
Mon Mar 13 20:57:34 UTC 2023
On Mon, 6 Mar 2023 19:48:48 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
> Please review this explorative refactoring for VisibleMemberTable (VMT).
>
> This is the first round of refactoring for VMT. This round is about *method members*: declared (overriding and not) and inherited.
>
> During this work I gained some insight into internal workings of VMT, fixed what was feasible and left TODOs and FIXMEs for everything else. Leaving those comments might look untidy, but leaving them out is wasteful: they clearly mark issues that should be revisited in upcoming rounds of refactoring.
>
> As I see it today, the main issue with VMT is that implements complex and error-prone computations from Java Language Specification (JLS) by hand. For example, VMT interprets JLS rules for relations such as _inherits_, _overrides_ and _hides_. As one would imagine, sometimes VMT does it incorrectly. It would be better to eventually re-implement VMT using `javax.lang.model` as much as possible. Unlike that of `jdk.javadoc`, the day job of `javax.lang.model` is to provide JLS services.
This pull request has now been integrated.
Changeset: 7bbc5e0e
Author: Pavel Rappo <prappo at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/7bbc5e0efbcbf97e8c1d4e889bd06c33c5f4eaa5
Stats: 711 lines in 13 files changed: 395 ins; 176 del; 140 mod
8300517: Refactor VisibleMemberTable (method members)
Reviewed-by: jjg
-------------
PR: https://git.openjdk.org/jdk/pull/12887
More information about the javadoc-dev
mailing list