RFR: 8304146: Refactor VisibleMemberTable (LocalMemberTable) [v2]
Pavel Rappo
prappo at openjdk.org
Wed Mar 15 18:23:27 UTC 2023
On Wed, 15 Mar 2023 17:52:29 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Trivially rephrase TODO
>> - Address feedback
>>
>> - renames simplename to simpleName
>> - links to the relevant JBS issue from TODOs
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/VisibleMemberTable.java line 907:
>
>> 905: @Override
>> 906: public String visitExecutable(ExecutableElement e, Void aVoid) {
>> 907: return e.getSimpleName() + ":" + e.getParameters().size();
>
> That was bizarre.
Somewhat, yes. That computation complicated code more than it improved (some aspects of) it.
-------------
PR: https://git.openjdk.org/jdk/pull/13044
More information about the javadoc-dev
mailing list