RFR: JDK-8303123: Add line break opportunity to single type parameters
Jonathan Gibbons
jjg at openjdk.org
Fri Mar 31 21:13:16 UTC 2023
On Tue, 21 Mar 2023 14:11:56 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
> Please review a simple change to add a `<wbr>` (line break opportunity) tag before type parameters in some type links. This is only used in the first column of member summary tables as this is the only place where we have type names with full type parameters and no natural line break opportunities in a very limited horizontal space. Attached below is a screenshot of the method summary table of `java.net.http.HttpResponse.BodySubscribers` with this fix applied (see JBS issue for a screenshot of the previous rendering).
>
> <img width="1175" alt="return-type-line-breaks" src="https://user-images.githubusercontent.com/15975/226632264-73700740-dc25-429f-acce-d26e24be26cd.png">
Looks. good to me.
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractMemberWriter.java line 208:
> 206: // Add explicit line break between method type parameters and
> 207: // return type in member summary table to avoid random wrapping.
> 208: if (typeParameters.charCount() > 10) {
Unrelated to this PR, I still dislike these unnamed numeric values.
-------------
Marked as reviewed by jjg (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13119#pullrequestreview-1367602710
PR Review Comment: https://git.openjdk.org/jdk/pull/13119#discussion_r1154896533
More information about the javadoc-dev
mailing list