RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents

[Jonathan Gibbons]

On Thu, 27 Apr 2023 08:02:50 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

> I modified the location from which javadoc copies some legal files to the generated documentation.  If --legal-notices　option is set to default or nothing is specified,, GPLv2 Legal Documents are copied from legal/java.base/ directory, such as LICENSE, ADDITIONAL_LICENSE_INFO and ASSEMBLY_EXCEPTION.
> 
> Would you please review this fix?

The change to use a mixture of `Path` and `File` is bizarre and mostly gratuitous and unnecessary.
Please stay using `nio.Path` objects.

test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java line 35:

> 33: 
> 34: import java.io.IOException;
> 35: import java.io.File;

Use `java.nio.Path`, not `java.io.File`

test/langtools/jdk/javadoc/doclet/testLegalNotices/TestLegalNotices.java line 109:

> 107: 
> 108:         Set<File> expectFiles = getExpectFiles(optionKind, indexKind, legal);
> 109:         Set<File> foundFiles = listFiles(out.resolve("legal"));

Do not change return type from `Path` to `File`

-------------

Changes requested by jjg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13686#pullrequestreview-1415181295
PR Review Comment: https://git.openjdk.org/jdk/pull/13686#discussion_r1186340653
PR Review Comment: https://git.openjdk.org/jdk/pull/13686#discussion_r1186341069