RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents [v2]

Fri May 12 22:38:42 UTC 2023

On Thu, 11 May 2023 08:50:55 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

>> I modified the location from which javadoc copies some legal files to the generated documentation.  If --legal-notices　option is set to default or nothing is specified,, GPLv2 Legal Documents are copied from legal/java.base/ directory, such as LICENSE, ADDITIONAL_LICENSE_INFO and ASSEMBLY_EXCEPTION.
>> 
>> Would you please review this fix?
>
> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8306980: Generated docs should contain correct GPLv2 Legal Documents

This seems like the wrong solution.

It does not seem right for javadoc to rummage around finding legal files that may or may not be the right ones to use.   By deign, it is supposed to just copy the files from a directory that has been provided. If the files in that directory are wrong or missing, we should fix that, not fix javadoc to go looking elsewhere.

-------------

Changes requested by jjg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13686#pullrequestreview-1425223519