RFR: JDK-8305958: Use links instead of buttons for auto-generated header links [v3]

Jonathan Gibbons jjg at openjdk.org
Wed May 24 20:35:55 UTC 2023


On Mon, 8 May 2023 14:35:39 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Please review a change to use plain HTML links instead of buttons to provide the URL to page section/heading anchors. Special care was taken to retain the accessibility features added in JDK-8299718, so section links can be reached and activated by keyboard and have an `aria-label` attribute. The generated documentation was tested on a range of desktop and mobile browsers (Firefox, Chrome on Mac OS and Linux, Safari on Mac OS and iOS, Chrome on Android) and can be viewed here:
>> 
>> https://cr.openjdk.org/~hannesw/8305958/api.00/index.html
>
> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move anchor-link sizing to stylesheet.css

Marked as reviewed by jjg (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/13831#pullrequestreview-1442706339


More information about the javadoc-dev mailing list