RFR: 8320234: Merge doclint.Env.AccessKind with tool.AccessKind [v2]

Mon Nov 20 17:33:20 UTC 2023

On Mon, 20 Nov 2023 17:31:14 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Back when DocLint lived in jdk.compiler, neither jdk.javadoc had access to DocLint, nor DocLint had access to jdk.javadoc. Since DocLint moved to jdk.javadoc, some redundancy can be eliminated and functionality shared; AccessKind is one such functionality.
>> 
>> There's more that could be done here. For example, jdk.javadoc.internal.doclint.Messages.Options can be simplified more. However, it's a separate issue.
>
> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove assert, but implement Comparable explicitly

Marked as reviewed by jjg (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/16714#pullrequestreview-1740349773