RFR: 8308753: Class-File API transition to Preview [v3]

[Maurizio Cimadamore]

On Mon, 2 Oct 2023 13:19:48 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/ClassTransform.java line 164:
> 
>> 162: 
>> 163:     /**
>> 164:      * @implSpec
> 
> Should these overridden method have `@inheritDoc` ? If not, their javadoc won't show much, I believe. (same might be true for other methods)

(To be precise - the javadoc says "Description copied from interface: ClassFileTransform") - just make sure that's what you want.

> src/java.base/share/classes/java/lang/classfile/FieldTransform.java line 116:
> 
>> 114: 
>> 115:     /**
>> 116:      * @implSpec The default implementation returns a resolved transform with all
> 
> Perhaps lose the `all its parts` - not sure that makes the comment any clearer?

I've noted the same pattern in other similar methods

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1342689301
PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1342697392