RFR: 8308753: Class-File API transition to Preview [v3]

[Adam Sotona]

On Mon, 2 Oct 2023 13:24:49 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/CodeBuilder.java line 596:
> 
>> 594:      * @param type the object type
>> 595:      * @return this builder
>> 596:      * @throws IllegalArgumentException if {@code type} represents a primitive type
> 
> What about arrays? (ClassDesc has an `isArray` predicate too). This probably applies to other methods too.

Test for arrays is not performed. The only constraint here is ability to construct constant pool class entry, which is not possible from a primitive type.
The library does only bare minimal consistency checks and proposal for additional constraints should be discussed at the mailing list.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1342731348