RFR: 8308753: Class-File API transition to Preview [v3]

[Maurizio Cimadamore]

On Mon, 2 Oct 2023 13:50:17 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/instruction/InvokeInstruction.java line 67:
> 
>> 65: 
>> 66:     /**
>> 67:      * {@return for an {@code invokeinterface}, the {@code count} value, as defined in {@jvms 6.5}}
> 
> Suggestion:
> 
>      * {@return the {@code count} value of an {@code invokeinterface} instruction, as defined in {@jvms 6.5}}

What does this return for something that is not `invokeinterface` ? Do we infer the count from the descriptor? Or do we return -1 ? This should probably be reflected in the javadoc.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1342721975