RFR: 8308753: Class-File API transition to Preview [v3]

[Adam Sotona]

On Mon, 2 Oct 2023 13:57:58 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/package-info.java line 273:
> 
>> 271:  * <p>
>> 272:  * More complex verification of a classfile can be achieved by explicit invocation
>> 273:  * of {@link java.lang.classfile.ClassModel#verify}.
> 
> Aren't part of verification also ran as part of generating stackmaps (unless stackmap inference is disabled) ? Should it be mentioned here?

Only fragment of verification conditions are required for stackmaps generator and it is indirectly mentioned in the sentence: "However fatal inconsistencies (like for example invalid code sequence or unresolved labels) affects internal tools and may cause exceptions later in the classfile building process."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1344048341