RFR: 8308753: Class-File API transition to Preview [v3]

[Adam Sotona]

On Mon, 2 Oct 2023 14:03:48 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/package-info.java line 389:
> 
>> 387:  * To achieve stability of transformations in future JDK releases it is desired
>> 388:  * to set appropriate response to potential new classfile elements appearing.
>> 389:  * Transformation designed to handle all situation should be implemented strict way,
> 
> "handle all situations" - I couldn't make much sense of it. I only got it when reading the text that follows, which says "transformation selectively interested in ...". This para should be rephrased for better clarity. E.g.
> "Classfile transforms that are interested in consuming _all_ classfile elements should be implemented in a strict fashion, so that new exceptions will be issued, should a new and unknown classfile element appear ... Conversely, classfile transforms that are only interested in consuming a portion of classfile elements do not need to concern with new and unknown classfile elements ... because ... "

Thanks for the review, I've reformulated the paragraph as suggested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1344157870