RFR: 8308753: Class-File API transition to Preview [v3]
Adam Sotona
asotona at openjdk.org
Tue Oct 3 14:11:11 UTC 2023
On Mon, 2 Oct 2023 14:51:47 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fixed javadoc typo
>
> test/langtools/tools/javac/classfiles/attributes/SourceFile/NoSourceFileAttribute.java line 52:
>
>> 50: assertNull(
>> 51: ClassFile.of().parse(getClassFile(NoSourceFileAttribute.class).toPath()).findAttribute(Attributes.SOURCE_FILE).orElse(null),
>> 52: "ClassFile should have no SourceFile attribute when compiled without debug information.");
>
> Not sure if replacing the camel case ClassFile in the assertion message is what you wanted here
Nice catch, fixed, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1344165330
More information about the javadoc-dev
mailing list