RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents [v6]

[Jaikiran Pai]

On Wed, 4 Oct 2023 05:36:54 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

>> KIRIYAMA Takuya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin' into 8306980
>>  - 8306980: Generated docs should contain correct GPLv2 Legal Documents
>>  - Merge remote-tracking branch 'origin' into 8306980
>>  - 8306980: Generated docs should contain correct GPLv2 Legal Documents
>>  - 8306980: Generated docs should contain correct GPLv2 Legal Documents
>>  - 8306980: Generated docs should contain correct GPLv2 Legal Documents
>
> I can't find anyone to sponsor this pull request.
> Could someone please review this fix?

Hello @tkiriyama, I agree with Jon, it feels wrong to be doing such a change in the javadoc code. I understand why it's being done - on Windows, the per module license files (in this case for the `jdk.javadoc` module) do not contain the actual license text. That's due to how jlink generates them on systems (like Windows) which do not support symbolic links.

I think we should ask for input from people who are more familiar with jlink on what is expected of other parts of JDK code when such code wants to copy over the license files. Perhaps @AlanBateman or @mlchung would have some suggestions.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13686#issuecomment-1746202410