RFR: 8308753: Class-File API transition to Preview [v18]
Adam Sotona
asotona at openjdk.org
Tue Oct 10 11:29:40 UTC 2023
> Classfile API is an internal library under package `jdk.internal.classfile` in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR goes in sync with [JDK-8308754](https://bugs.openjdk.org/browse/JDK-8308754): Class-File API (Preview) (CSR)
> and [JDK-8280389](https://bugs.openjdk.org/browse/JDK-8280389): Class-File API (Preview) (JEP).
>
> Online javadoc is available at:
> https://cr.openjdk.org/~asotona/JDK-8308753-preview/api/java.base/java/lang/classfile/package-summary.html
>
> In addition to the primary transition to preview, this pull request also includes:
> - All Classfile* classes ranamed to ClassFile* (based on JEP discussion).
> - A new preview feature, `CLASSFILE_API`, has been added.
> - Buildsystem tool required a little patch to support annotated modules.
> - All JDK modules using the Classfile API are newly participating in the preview.
> - All tests that use the Classfile API now have preview enabled.
> - A few Javac tests not allowing preview have been partially reverted; their conversion can be re-applied when the Classfile API leaves preview mode.
>
> Despite the number of affected files, this pull request is relatively straight-forward. The preview version of the Classfile API is based on the internal version of the library from the JDK master branch, and there are no API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 348 commits:
- Merge branch 'master' into JDK-8308753-preview
- added @sealedGraph tags
- fixed exception type thrown from CodeImpl
- added constraint to throw on an attempt to parse unknown classfile version
+ test
- removed AttributeMapper::validSince
- fixed DirectCodeBuilder
- improved ClassFile constants javadoc
- fixed AnnotationValue::of javadoc
- fixed elements javadoc
- Typo in BufWriter javadoc
- ... and 338 more: https://git.openjdk.org/jdk/compare/ad7a8e86...5e537a86
-------------
Changes: https://git.openjdk.org/jdk/pull/15706/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15706&range=17
Stats: 32099 lines in 763 files changed: 14605 ins; 14018 del; 3476 mod
Patch: https://git.openjdk.org/jdk/pull/15706.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15706/head:pull/15706
PR: https://git.openjdk.org/jdk/pull/15706
More information about the javadoc-dev
mailing list