RFR: 8308753: Class-File API transition to Preview [v19]

Adam Sotona asotona at openjdk.org
Thu Oct 12 10:43:27 UTC 2023


On Thu, 12 Oct 2023 10:23:56 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed obsolete exports from BuildMicrobenchmark.gmk
>
> make/test/BuildMicrobenchmark.gmk line 99:
> 
>> 97:     JAVAC_FLAGS := --add-exports java.base/sun.security.util=ALL-UNNAMED \
>> 98:         --add-exports java.base/sun.invoke.util=ALL-UNNAMED \
>> 99:         --add-exports java.base/jdk.internal.classfile.impl=ALL-UNNAMED \
> 
> Just checking: do we really need `jdk.internal.classfile.impl`? (It might have been added in by someone a bit sloppily just adding all jdk.internal.classfile modules.)

One of the benchmarks is focused on stack maps generator, which is not directly exposed through the API. We can remove this one and keep just the API-based benchmarks if it an issue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1356629635


More information about the javadoc-dev mailing list