RFR: JDK-8316972: Add javadoc support for restricted methods [v4]

Hannes Wallnöfer hannesw at openjdk.org
Tue Oct 17 09:36:00 UTC 2023


On Mon, 16 Oct 2023 22:51:26 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename local variable
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java line 432:
> 
>> 430:     }
>> 431: 
>> 432:     public boolean isRestrictedAPI(Element el) {
> 
> It would be good to file a JBS issue, requesting that this info should be available using `java.lang.model` API, perhaps `util.Elements.isRestricted(ExecutableElement)`
> and to document that JBS issue here.
> 
> Bottom line: ideally, the doclet should be a clean client of the Language Model API, and other public API. Workarounds are "bad" and indicative of something wrong or missing elsewhere.

I'll file an issue. We also have similar workaround methods for preview API, I wonder if these should also be "made official"?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16188#discussion_r1361812478


More information about the javadoc-dev mailing list