RFR: 8318082: ConcurrentModificationException from IndexWriter [v2]

[Pavel Rappo]

On Fri, 20 Oct 2023 16:47:10 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/taglets/TagletWriter.java line 375:
> 
>> 373:     Content createAnchorAndSearchIndex(Element element, String tagText, Content tagContent, String desc, DocTree tree) {
>> 374:         Content result;
>> 375:         if (context.isFirstSentence && context.inSummary || context.inTags.contains(DocTree.Kind.INDEX)
> 
> If you introduce `context.isIndexable` then the code may read better if you flip the then/else parts.
> 
> 
> if (htmlWriter.isIndexable() && context.isIndexable()) {
>     // index it
> } else {
>     // don't index it
> }

Let's leave it out for now. It's not because I don't like flipping the `if` and `else` arms around, it's because I'm not very comfortable with introducing `isIndexable` to Context at the moment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16271#discussion_r1368373607