RFR: 8338190: TOC vertical offsets not updated when document size changes
Jonathan Gibbons
jjg at openjdk.org
Mon Aug 19 17:33:49 UTC 2024
On Mon, 12 Aug 2024 12:59:13 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
> Please review a simple change to switch to a [better suited API](https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver) to track changes in document size in `javadoc`-generated pages. In addition to changes in the size of the browser viewport, the new code handles changes coming from page content, such as showing different subsets of members in a member summary table.
>
> This issue is labeled `noreg-hard` since we don't have a way to test resize behaviour in an automated way. I manually tested the change in Chrome, Firefox and Safari on various desktop and mobile platforms. The `ResizeObserver` API has been implemented in supported browsers [between early 2018 and early 2020](https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver/ResizeObserver#browser_compatibility).
I'm not an expert and I note the `noreg-hard`.
But the change seems reasonable.
-------------
Marked as reviewed by jjg (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20547#pullrequestreview-2246098962
More information about the javadoc-dev
mailing list