RFR: 8339115: Rename TypeKind enum constants to follow code style [v4]
Chen Liang
liach at openjdk.org
Thu Aug 29 22:33:34 UTC 2024
> `TypeKind` enum constants are named in wrong code style; correct them before finalization.
>
> Also improved `TypeKind` specification to talk about not mentioned `returnType`, `void`, and subword types being erased to int (and how). See the associated CSR too.
>
> See the HTML output for the changed `JSpec` taglet's `6.5.newarray` rendering: https://cr.openjdk.org/~liach/8339115-typekind/java.base/java/lang/classfile/TypeKind.html
>
> Note: when reviewing, please use https://cr.openjdk.org/~iris/se/23/spec/draft/java-se-23-draft-spec-37/ instead of JVMS 22 for reference; JVMS 23 has fixed a few ambiguities about subword types being absent from JVM's stack and locals.
Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
- Reorder float and long to match instruction order, fix compilation
- Merge branch 'master' of https://github.com/openjdk/jdk into fix/typekind
- space
- More fixes, reorder constants
- Merge branch 'master' of https://github.com/openjdk/jdk into fix/typekind
- 8339115: Rename TypeKind enum constants to follow code style
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/20737/files
- new: https://git.openjdk.org/jdk/pull/20737/files/41f81fe8..3ab23576
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=20737&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=20737&range=02-03
Stats: 2553 lines in 73 files changed: 2112 ins; 146 del; 295 mod
Patch: https://git.openjdk.org/jdk/pull/20737.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20737/head:pull/20737
PR: https://git.openjdk.org/jdk/pull/20737
More information about the javadoc-dev
mailing list