RFR: 8333230: Improve code example in doclet package [v2]

Nizar Benalla nbenalla at openjdk.org
Fri Aug 30 13:37:20 UTC 2024


On Fri, 30 Aug 2024 08:22:30 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename SimpleDoclet to Example so that TestDocletExample.java passes
>
> src/jdk.javadoc/share/classes/jdk/javadoc/doclet/package-info.java line 289:
> 
>> 287:  *
>> 288:  *    // A scanner to loop through specified elements
>> 289:  *    class ShowFileObjects {
> 
> What is the benefit of defining this inner class versus just implementing the `show` method in the doclet class?

I think it was mostly a coding style decision, I wanted to put emphasis on using a scanner

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20619#discussion_r1738683013


More information about the javadoc-dev mailing list