RFR: 8337111: Bad HTML checker for generated documentation [v3]

Sat Dec 14 21:04:42 UTC 2024

On Thu, 14 Nov 2024 08:21:51 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Add a test for external links
>>    separate checks into different jtreg tests
>>    fix typos
>>  - Merge remote-tracking branch 'upstream/master' into new-docs-tests-suit
>>  - Merge remote-tracking branch 'upstream/master' into new-docs-tests-suit
>>  - add file with all vetted links
>>  - improve some parts based on review comments
>>  - Merge remote-tracking branch 'upstream/master' into new-docs-tests-suit
>>  - Merge remote-tracking branch 'upstream/master' into new-docs-tests-suit
>>  - Convert parts of doccheck into tests
>
> test/docs/jdk/javadoc/doccheck/doccheckutils/checkers/DocTypeChecker.java line 77:
> 
>> 75:                     + "\\s+([a-z]+)"
>> 76:                     + "\\s+\"([^\"]+)\""
>> 77:                     + "(?:\\s+\"([^\"]+)\")?"
> 
> Where is this part of the doctype specified?

It can match the string `:legacy-compat` in `<!DOCTYPE html SYSTEM "about:legacy-compat">` or `<!DOCTYPE html SYSTEM 'about:legacy-compat'>`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21879#discussion_r1885388066