RFR: 8323698: Class use page does not include extends/implements type arguments [v7]

Hannes Wallnöfer hannesw at openjdk.org
Fri Feb 23 11:58:55 UTC 2024


On Fri, 23 Feb 2024 05:44:08 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Currently in the javadoc tool, the generated class use page does not track the occurrences of a class in the type arguments of the extends or implements list, where they can appear. (See more details on the JBS issue) For example:
>> 
>> public class One {}
>> 
>> 
>> import java.util.*;
>> public class Two extends ArrayList<One> implements Comparator<One> {
>> }
>> 
>> 
>> This patch proposes to add new 2 usage categories, "Classes that extend types with arguments of type" and "Classes that implement types with arguments of type" to describe the missing usage scenarios.
>> 
>> A preview of the new use page with the 2 new categories, generated based on the example above, can be found here: https://cr.openjdk.org/~liach/8323698-javadocuse/doc/class-use/One.html
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - Merge branch 'master' of https://github.com/openjdk/jdk into feature/jd-use-super-typearg
>  - Improve documentation
>  - Apply suggestions from code review
>    
>    Co-authored-by: Pavel Rappo <32523691+pavelrappo at users.noreply.github.com>
>  - Distinguish subinterfaces, use clearer terms
>  - Merge branch 'master' of https://github.com/openjdk/jdk into feature/jd-use-super-typearg
>  - Review changes
>  - Merge branch 'master' of https://github.com/openjdk/jdk into feature/jd-use-super-typearg
>  - Fix tests
>  - Improve localization
>  - Merge branch 'master' of https://github.com/openjdk/jdk into feature/jd-use-super-typearg
>  - ... and 1 more: https://git.openjdk.org/jdk/compare/45d43185...98587bc6

Looks good to me.

-------------

Marked as reviewed by hannesw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17414#pullrequestreview-1897948293


More information about the javadoc-dev mailing list