RFR: JDK-8326694: Defer setting of autocapitalize attribute
Jonathan Gibbons
jjg at openjdk.org
Tue Feb 27 18:50:51 UTC 2024
On Tue, 27 Feb 2024 14:14:49 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
> Please review a simple change to set the `autocapitalize` attribute of input fields dynamically in the initialization scripts rather than statically in HTML.
I'll approve it, but make a suggestion as well...
We could set "standard" attributes in the `HtmlTree.INPUT` factory method, optionally conditional on the input type. This would allow the code to set `autocomplete` just once, in that method, instead of 3 places, as here. It would also give a single place to explain why we do _not_ set `autocapitalize` in the HTML tree.
-------------
Marked as reviewed by jjg (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18029#pullrequestreview-1904547153
More information about the javadoc-dev
mailing list