RFR: 8323698: Class use page does not include extends/implements type arguments [v2]

Chen Liang liach at openjdk.org
Tue Jan 23 14:35:47 UTC 2024


On Mon, 22 Jan 2024 14:41:05 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Improve localization
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into feature/jd-use-super-typearg
>>  - Use page to check extends/implements type arguments
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties line 384:
> 
>> 382: doclet.ClassUse_TypeParameter=Classes in {1} with type parameters of type {0}
>> 383: doclet.ClassUse_SuperclassTypeParameter=Classes in {1} that extend types with arguments of type {0}
>> 384: doclet.ClassUse_InterfaceTypeParameter=Classes in {1} that implement types with arguments of type {0}
> 
> Not sure about the wording here: I think it should be "type arguments" instead of just "arguments", and maybe "extend classes" and "implement interfaces"?

Done. Also pulled latest master, the preview on CR is updated too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17414#discussion_r1463370306


More information about the javadoc-dev mailing list