RFR: 8318106: Generated HTML for snippet does not always contain an id [v2]

Chen Liang liach at openjdk.org
Thu Jul 11 15:11:27 UTC 2024


On Thu, 11 Jul 2024 15:08:34 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Please review this jdk24 bug, which we intend to backport to jdk23 before RDP2, which is a week away. This is a simple fix, but it disturbs multiple tests.
>> 
>> Here's a tip for reviewing. Sometimes a snippet id in a test ends up with `()1`, other times with `()2`. This is because the same snippet may appear more than once on the same page, and we are always looking for its last appearance. For example, if a snippet resides in the first sentence of a method documentation, that snippet will appear in both the "Method Summary" and "Method Details" sections. Otherwise, it will only appear in "Method Details". Appearances are numbered starting from 1 and increment by 1 from top ("Method Summary") to bottom ("Method Details").
>
> Pavel Rappo has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
> 
>  - Remove extra hyphen as suggested
>  - Initial commit

Marked as reviewed by liach (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20136#pullrequestreview-2172186395


More information about the javadoc-dev mailing list