RFR: 8318106: Generated HTML for snippet does not always contain an id [v2]
Pavel Rappo
prappo at openjdk.org
Thu Jul 11 15:11:27 UTC 2024
On Thu, 11 Jul 2024 14:43:08 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Pavel Rappo has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
>>
>> - Remove extra hyphen as suggested
>> - Initial commit
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlIds.java line 619:
>
>> 617: } else {
>> 618: // utmost unexpected, but this case shouldn't fail
>> 619: id += "unknown-element-";
>
> Feels weird that unknown element has a `-` between name and count but the others don't.
Sorry, I initially pushed an outdated commit. This is a rare situation where a force push is warranted. Also, fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20136#discussion_r1674179141
More information about the javadoc-dev
mailing list