RFR: 8299080: Wrong default value of snippet lang attribute [v2]

Pavel Rappo prappo at openjdk.org
Mon Jul 15 12:48:18 UTC 2024


On Tue, 9 Jul 2024 21:13:45 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> General comment: while the dust on `Path.getExtension` is still settling, as a matter of policy, we should try and stay compatible with that. In particular, a filename like `.gitignore` is a hidden filename with no extension, not an empty filename with a 9-letter extension.
>
> Agreed on lower case

> One thing I would consider is converting the result or this method to lower case, since that is how the language attribute value is usually represented.

> Agreed on lower case

Please provide a few examples where it would be necessary.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19971#discussion_r1677770516


More information about the javadoc-dev mailing list