From duke at openjdk.org  Mon Jun  3 06:37:20 2024
From: duke at openjdk.org (psoujany)
Date: Mon, 3 Jun 2024 06:37:20 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v24]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <DzhgqmSJFNZcywFPWjlhMXoRzIxPD3UmJ-7tZSnqorE=.3c804d94-6e75-41be-b27f-0d484536db8a@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Add tabindex only to elemetns which are not tabbable

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/eda64006..95f99497

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=23
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=22-23

  Stats: 14 lines in 1 file changed: 1 ins; 10 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Mon Jun  3 06:40:05 2024
From: duke at openjdk.org (psoujany)
Date: Mon, 3 Jun 2024 06:40:05 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v23]
In-Reply-To: <B639d3msMiDgs3FWVRzZV20i_i65v3nzZADKbQU-bFA=.959d9223-482d-4f84-8e85-091fd113e0a7@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
 <4qdAGPJ4wHfvhkkALNrnsEHdSAu2guRqMxfDYnsz8b4=.c9bbf75b-608e-40ae-b261-d5539eb12708@github.com>
 <B639d3msMiDgs3FWVRzZV20i_i65v3nzZADKbQU-bFA=.959d9223-482d-4f84-8e85-091fd113e0a7@github.com>
Message-ID: <dppfhC4OAe66l8k_lHclswVZ2e5BrvcHqiGJDdgcn-M=.b01050ef-7473-4f78-9cfd-b252edefde7a@github.com>

On Fri, 31 May 2024 14:20:50 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

>> psoujany has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Add tab order to plain text
>>  - Add tab order to plain text
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Table.java line 349:
> 
>> 347:              * For more information on the `widget_tabbable_single` rule, please refer to the following documentation:
>> 348:              * <a href="https://able.ibm.com/rules/archives/latest/doc/en-US/widget_tabbable_single.html#%7B%22message%22%3A%22Component%20with%20%5C%22tablist%5C%22%20role%20has%20more%20than%20one%20tabbable%20element%22%2C%22snippet%22%3A%22%3Cdiv%20tabindex%3D%5C%220%5C%22%20role%3D%5C%22tablist%5C%22%20class%3D%5C%22col-second%20odd-row-color%20method-summary-table%20method-summary-table-tab2%20method-summary-table-tab3%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22POTENTIAL%22%5D%2C%22reasonId%22%3A%22fail_multiple_tabbable%22%2C%22ruleId%22%3A%22widget_tabbable_single%22%7D">widget_tabbable_single</a>
>> 349:              */
> 
> I think this new comment is a bit excessive. Can it be boiled down to a single sentence, maybe one or two lines? Also, there's no need to use `/**` doc comment style here. For example (but feel free to improve):
> 
>     // Only make element tabbable if it doesn't contain tabbable content.
> 
> Regarding the link, I don't think the content after the `#` is necessary. I would prefer the following form:
> 
>     // https://able.ibm.com/rules/archives/latest/doc/en-US/widget_tabbable_single.html

I simplified comment as per your suggestion. Thank You.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17819#discussion_r1623851288

From duke at openjdk.org  Mon Jun  3 06:46:10 2024
From: duke at openjdk.org (psoujany)
Date: Mon, 3 Jun 2024 06:46:10 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v23]
In-Reply-To: <p3jQwT1_XF1zNvw9oreZi0-n_S-s-1hRDggP7tBYKt8=.a0a7c2e6-9851-4c9b-a205-a98ea3b6508f@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
 <4qdAGPJ4wHfvhkkALNrnsEHdSAu2guRqMxfDYnsz8b4=.c9bbf75b-608e-40ae-b261-d5539eb12708@github.com>
 <p3jQwT1_XF1zNvw9oreZi0-n_S-s-1hRDggP7tBYKt8=.a0a7c2e6-9851-4c9b-a205-a98ea3b6508f@github.com>
Message-ID: <OJ1-RDSpXjXP3OLIbiFFHtRgaqUzAoiPoLJ46u-Ig2E=.62838b42-09e1-4b75-b053-150666c0de3f@github.com>

On Fri, 31 May 2024 14:23:06 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

>> psoujany has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Add tab order to plain text
>>  - Add tab order to plain text
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Table.java line 335:
> 
>> 333:         }
>> 334:         int colIndex = 0;
>> 335:         String regex = "<(?:a|area|button|input|object|select|textarea)\\b";
> 
> The only element that will likely occur in a API description is `a`. Is it actually the case that a contained link will make the table cell tabbable and scrollable via keyboard?

We initially added all elements which have default tab-order to avoid potential violations. But `<a>` should be sufficient as it's the only potential option possible in API description. Link will only make table cell tabbable via keyboard. As CSS is adding overflow: auto on table cells, making cells to be tabbable. The proposed solution here makes table cells accessible via keyboard by adding tabindex.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17819#discussion_r1623857346

From duke at openjdk.org  Mon Jun  3 07:05:31 2024
From: duke at openjdk.org (psoujany)
Date: Mon, 3 Jun 2024 07:05:31 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v25]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <c9UTf4MrLm8Is5lk8PB9F0K_tVVpWEAuKbgOsdGimI0=.d22fa37c-8e07-41ba-a3e9-c35e8c0f10d7@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 28 additional commits since the last revision:

 - Merge branch 'openjdk:master' into remove-overflow
 - Add tabindex only to elemetns which are not tabbable
 - Add tab order to plain text
 - Add tab order to plain text
 - Add tabindex to plain text
 - Add tabindex to plain text
 - Remove trailing whitespaces
 - Add tabindex to grid columns
 - Add tabindex to grid columns
 - Add tabindex
 - ... and 18 more: https://git.openjdk.org/jdk/compare/1d8695f4...cff5ca30

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/95f99497..cff5ca30

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=24
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=23-24

  Stats: 724439 lines in 9515 files changed: 182054 ins; 181766 del; 360619 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Mon Jun  3 07:11:17 2024
From: duke at openjdk.org (psoujany)
Date: Mon, 3 Jun 2024 07:11:17 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v26]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <qXs4X_gTaqvtzRXof_-BGB0mDx_S2V0j-k3gr8f1s-I=.ca625049-66fa-4f44-b77a-4f3d4cf0038c@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Make only elements which are tabbable

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/cff5ca30..268fbfa0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=25
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=24-25

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From jlahoda at openjdk.org  Mon Jun  3 07:34:18 2024
From: jlahoda at openjdk.org (Jan Lahoda)
Date: Mon, 3 Jun 2024 07:34:18 GMT
Subject: RFR: 8325168: JShell should support Markdown comments [v6]
In-Reply-To: <lgOTJzXSIjOcHAZp2SpQ96tEKpnwqGDP0jtIXVU9PEo=.ae8137ed-882c-4146-a4f9-68de26b03ef0@github.com>
References: <lgOTJzXSIjOcHAZp2SpQ96tEKpnwqGDP0jtIXVU9PEo=.ae8137ed-882c-4146-a4f9-68de26b03ef0@github.com>
Message-ID: <jZXTxX8Tb4hBgngenoFweWHFuOTXgp4TFdNQM9lXPD4=.793acd11-fea6-45ec-8a34-a7ceec301e5f@github.com>

> This is an attempt to add Markdown support in documentation comments to JShell.
> 
> It works by converting the Markdown text to HTML during the process of resolving `{@inheritDoc}` tags.

Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:

  Reflecting review comments.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17686/files
  - new: https://git.openjdk.org/jdk/pull/17686/files/d85a2b8a..64c984d6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17686&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17686&range=04-05

  Stats: 128 lines in 3 files changed: 21 ins; 4 del; 103 mod
  Patch: https://git.openjdk.org/jdk/pull/17686.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17686/head:pull/17686

PR: https://git.openjdk.org/jdk/pull/17686

From duke at openjdk.org  Mon Jun  3 08:42:19 2024
From: duke at openjdk.org (psoujany)
Date: Mon, 3 Jun 2024 08:42:19 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v27]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <hYQaM4_eovVIHzz70WsRKoHGKyCWdra29-N7rCQZrsg=.41d0840d-0b9c-4cf2-abbb-2f020860993b@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Make only elements which are tabbable

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/268fbfa0..4b4d829b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=26
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=25-26

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Mon Jun  3 10:12:25 2024
From: duke at openjdk.org (psoujany)
Date: Mon, 3 Jun 2024 10:12:25 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v28]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <_b7a8ZSp08t2fYj-3BlN-gqxoAhwnpNqkni0EtxqHv4=.abedd121-41d0-43f4-b6e5-18f60d48983d@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Add tabindex to tabbable elements

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/4b4d829b..aa84ed70

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=27
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=26-27

  Stats: 53 lines in 5 files changed: 0 ins; 0 del; 53 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Mon Jun  3 12:33:31 2024
From: duke at openjdk.org (psoujany)
Date: Mon, 3 Jun 2024 12:33:31 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v29]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <WNwQ2b1llrm16uHkbyds1w0socVc5bFczDyFUhf6jgE=.00979129-e0d1-40de-aac7-5712915075d6@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Add tabindex to tabbable elements

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/aa84ed70..265ee868

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=28
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=27-28

  Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From hannesw at openjdk.org  Mon Jun  3 12:43:00 2024
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Mon, 3 Jun 2024 12:43:00 GMT
Subject: RFR: 8332039: Cannot invoke
 "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null
In-Reply-To: <TholBqVCyLRPKfY928jOZ7B7T4J3_gokCTAi84WedA0=.02289b9f-87b3-465f-831d-d8d05a378892@github.com>
References: <IQ4zNSBMwkzOjbfFJ8yEf1zLsECDoX_v51f0f2S1Ro8=.f953327b-b135-4ce4-b059-66badbb0f26d@github.com>
 <Pcne1oBGaDQSVvzbDNZ2Kr-W7k5-VkGN1Nu6wsduorA=.3c457a0d-e040-413b-8574-3cd6d5a66169@github.com>
 <HwNsVAFjJBWFSJY1f7CuJ-jSJUkjgWlq9_HDuVMX-6s=.fefe11b4-08b7-4203-81ea-bba9a5456b5e@github.com>
 <TholBqVCyLRPKfY928jOZ7B7T4J3_gokCTAi84WedA0=.02289b9f-87b3-465f-831d-d8d05a378892@github.com>
Message-ID: <U2yFymCYLkNvZYxlCJG8fXQKc30IEej6FE5bKuFL8Ss=.8e3238b8-6163-43b3-b923-20858f08e05e@github.com>

On Fri, 31 May 2024 20:58:31 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> > To clarify, I'm not too concerned with how we call an action whereby a nested class gets its `@since` tag from the enclosing class; but yes, "inheritance" might not be ideal. What I'm concerned with is the fact that the logic originally provided in [`getDefaultBlockTags`](https://github.com/openjdk/jdk/blob/6ee8407758c92d32e18642b0758d2d5c71ad09f5/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/taglets/SimpleTaglet.java#L141-L147) is now duplicated in `getInheritedDocTreePath`.
> > Like I said, while it's bad, the new duplication merely replicates the one we already have between `InheritableTaglet.inherit` and `getInheritedDocTreePath`.
> 
> If we can't fix this in the next few days, we should file a cleanup issue to resolve this duplication.

I don't quite see the problem with this, or how to improve it substantially (beyond finding better terminology). We have different ways of obtaining doc comment fragments from related elements. The major and well-established one is along the lines of Java type inheritance, and a minor/new one along enclosing/enclosed classes. Since `CommentHelper` provides a means to reverse lookup `DocTree` -> `DocTreePath`, it necessarily needs to know about all of these mechanisms. The code for the enclosing/enclosed classes is actually trivial, so I don't see how this could be simplified further. The code for finding doc comments along type inheritance is more complex, but it already delegates to the `DocFinder` class, which is also used for the primary lookup for inherited doc comments. 

I certainly don't think the existing/proposed code is perfect, but I don't see huge potential for improvement. Of course I'm open to learn and better understand the issues, and how to solve them.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19363#issuecomment-2145104410

From liach at openjdk.org  Mon Jun  3 23:49:01 2024
From: liach at openjdk.org (Chen Liang)
Date: Mon, 3 Jun 2024 23:49:01 GMT
Subject: RFR: 8331947: Preview creates checkbox for JEP-less preview
 feature [v4]
In-Reply-To: <birqULAu0eTzbh9uY4_F0FPaIPDKlmErjYN8IarcKS8=.abc79d59-c21e-4860-a14a-363ce6c1c5db@github.com>
References: <_kx1TJGenvZCMoSaeGX1HdxQQWR8t24OOqnrq0SpOmY=.31389dd4-1e6f-4c18-bf15-273520afb6b8@github.com>
 <birqULAu0eTzbh9uY4_F0FPaIPDKlmErjYN8IarcKS8=.abc79d59-c21e-4860-a14a-363ce6c1c5db@github.com>
Message-ID: <vnTQXfRj6tyEjCvo1P6hww9H_zi9z-yTa5QERzqdi30=.2a41983b-78bf-4cdb-9fd5-db1966a540a9@github.com>

On Fri, 31 May 2024 10:01:17 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

>> Please review a simple patch to exclude preview visitor classes meant to support future preview features from the Preview API page. 
>> 
>> The test adds an sample element annotated with the new `PreviewFeature.Feature.LANGUAGE_MODEL` constant (which does not have a `@JEP` annotation) to make sure it is not listed in the Preview API page. The test itself does not have to be modified, as it would fail without the change in `PreviewAPIListBuilder.java`.
>
> Hannes Walln?fer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review feedback

Marked as reviewed by liach (Author).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19344#pullrequestreview-2095041186

From hannesw at openjdk.org  Tue Jun  4 10:26:11 2024
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Tue, 4 Jun 2024 10:26:11 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v29]
In-Reply-To: <WNwQ2b1llrm16uHkbyds1w0socVc5bFczDyFUhf6jgE=.00979129-e0d1-40de-aac7-5712915075d6@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
 <WNwQ2b1llrm16uHkbyds1w0socVc5bFczDyFUhf6jgE=.00979129-e0d1-40de-aac7-5712915075d6@github.com>
Message-ID: <JDuhkNP_9UGqharzduplIpb9BW0b4-2yLsypa5MbOn0=.464f8fe5-f402-4bf1-bbc7-511a8ba8f02a@github.com>

On Mon, 3 Jun 2024 12:33:31 GMT, psoujany <duke at openjdk.org> wrote:

>> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
>> https://bugs.openjdk.org/browse/JDK-8325690
>
> psoujany has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add tabindex to tabbable elements

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Table.java line 334:

> 332:             cell.addStyle(rowStyle);
> 333:             if (!matchFound) {
> 334:                 cell.put(HtmlAttr.ROLE, "tablist")

Looking into this further, I don't think the `role="tablist"` attribute is correct here. According to the [MDN documentation], a `tablist` is defined as a container for a set of `tabs`, which does not apply for table cells.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17819#discussion_r1625750412

From jlahoda at openjdk.org  Tue Jun  4 11:57:13 2024
From: jlahoda at openjdk.org (Jan Lahoda)
Date: Tue, 4 Jun 2024 11:57:13 GMT
Subject: Integrated: 8325168: JShell should support Markdown comments
In-Reply-To: <lgOTJzXSIjOcHAZp2SpQ96tEKpnwqGDP0jtIXVU9PEo=.ae8137ed-882c-4146-a4f9-68de26b03ef0@github.com>
References: <lgOTJzXSIjOcHAZp2SpQ96tEKpnwqGDP0jtIXVU9PEo=.ae8137ed-882c-4146-a4f9-68de26b03ef0@github.com>
Message-ID: <RZKa5hvR9TysS734SfoiWUJXyyy-4Gw4F9F6OUdh37s=.4bb17103-cf09-42cb-9cff-a4235a302335@github.com>

On Fri, 2 Feb 2024 14:02:28 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> This is an attempt to add Markdown support in documentation comments to JShell.
> 
> It works by converting the Markdown text to HTML during the process of resolving `{@inheritDoc}` tags.

This pull request has now been integrated.

Changeset: 8d3de45f
Author:    Jan Lahoda <jlahoda at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8d3de45f4dfd60dc4e2f210cb0c085fcf6efb8e2
Stats:     2056 lines in 9 files changed: 1209 ins; 842 del; 5 mod

8325168: JShell should support Markdown comments

Reviewed-by: jjg

-------------

PR: https://git.openjdk.org/jdk/pull/17686

From hannesw at openjdk.org  Tue Jun  4 17:24:02 2024
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Tue, 4 Jun 2024 17:24:02 GMT
Subject: RFR: 8332039: Cannot invoke
 "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null
In-Reply-To: <IQ4zNSBMwkzOjbfFJ8yEf1zLsECDoX_v51f0f2S1Ro8=.f953327b-b135-4ce4-b059-66badbb0f26d@github.com>
References: <IQ4zNSBMwkzOjbfFJ8yEf1zLsECDoX_v51f0f2S1Ro8=.f953327b-b135-4ce4-b059-66badbb0f26d@github.com>
Message-ID: <H8nsgaNfoUiqKfVAs-UD5TsWyDlwcR4dYS_3akdbeFo=.321a1d79-894d-4197-8bf2-5de67b6b014f@github.com>

On Thu, 23 May 2024 10:39:52 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a patch to fix a NPE thrown when a `@since` tag inherited by a nested class contains a nested inline tag. The solution is to make `CommentHelper.getDocTreePath(DocTree)` able to handle block tags inherited by nested classes.

I filed a follow-up issue to refactor the code for inherited and derived doc comments:

https://bugs.openjdk.org/browse/JDK-8333557

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19363#issuecomment-2148040277

From hannesw at openjdk.org  Tue Jun  4 17:24:03 2024
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Tue, 4 Jun 2024 17:24:03 GMT
Subject: Integrated: 8332039: Cannot invoke
 "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null
In-Reply-To: <IQ4zNSBMwkzOjbfFJ8yEf1zLsECDoX_v51f0f2S1Ro8=.f953327b-b135-4ce4-b059-66badbb0f26d@github.com>
References: <IQ4zNSBMwkzOjbfFJ8yEf1zLsECDoX_v51f0f2S1Ro8=.f953327b-b135-4ce4-b059-66badbb0f26d@github.com>
Message-ID: <wiy04FDy5U12rZtvx5dngDId_CSV2u60Xfp-TfsQFfI=.925ea918-9005-4ba7-8776-636cd55dd3e2@github.com>

On Thu, 23 May 2024 10:39:52 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a patch to fix a NPE thrown when a `@since` tag inherited by a nested class contains a nested inline tag. The solution is to make `CommentHelper.getDocTreePath(DocTree)` able to handle block tags inherited by nested classes.

This pull request has now been integrated.

Changeset: a706e35b
Author:    Hannes Walln?fer <hannesw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a706e35b12addff987b489059be8f240c60fae75
Stats:     68 lines in 2 files changed: 49 ins; 3 del; 16 mod

8332039: Cannot invoke "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null

Reviewed-by: jjg

-------------

PR: https://git.openjdk.org/jdk/pull/19363

From prappo at openjdk.org  Wed Jun  5 11:47:58 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Wed, 5 Jun 2024 11:47:58 GMT
Subject: RFR: 8331947: Preview creates checkbox for JEP-less preview
 feature [v4]
In-Reply-To: <birqULAu0eTzbh9uY4_F0FPaIPDKlmErjYN8IarcKS8=.abc79d59-c21e-4860-a14a-363ce6c1c5db@github.com>
References: <_kx1TJGenvZCMoSaeGX1HdxQQWR8t24OOqnrq0SpOmY=.31389dd4-1e6f-4c18-bf15-273520afb6b8@github.com>
 <birqULAu0eTzbh9uY4_F0FPaIPDKlmErjYN8IarcKS8=.abc79d59-c21e-4860-a14a-363ce6c1c5db@github.com>
Message-ID: <F43zlb_9WvnIllMGeUWpN40nAQdY5FMWFMy2uVsZgRY=.377380f2-9000-4a68-bcaf-9a0488060cb6@github.com>

On Fri, 31 May 2024 10:01:17 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

>> Please review a simple patch to exclude preview visitor classes meant to support future preview features from the Preview API page. 
>> 
>> The test adds an sample element annotated with the new `PreviewFeature.Feature.LANGUAGE_MODEL` constant (which does not have a `@JEP` annotation) to make sure it is not listed in the Preview API page. The test itself does not have to be modified, as it would fail without the change in `PreviewAPIListBuilder.java`.
>
> Hannes Walln?fer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review feedback

Approved with fuzz.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/PreviewAPIListBuilder.java line 96:

> 94:             return true;
> 95:         }
> 96:         // Preview features without JEP are not included.

Trivial: we don't need to mention "support" near "preview" and "features", right? Just checking.

test/langtools/jdk/javadoc/doclet/testPreview/TestPreview.java line 161:

> 159:                     </ol>""");
> 160: 
> 161:         // 8331947: Support preview features without JEP should not be included in Preview API page

Trivial: here it is phrased as "Support preview features", while in the actual test source file it is "Preview support feature".

-------------

Marked as reviewed by prappo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19344#pullrequestreview-2098808073
PR Review Comment: https://git.openjdk.org/jdk/pull/19344#discussion_r1627545672
PR Review Comment: https://git.openjdk.org/jdk/pull/19344#discussion_r1627530580

From hannesw at openjdk.org  Wed Jun  5 12:39:58 2024
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Wed, 5 Jun 2024 12:39:58 GMT
Subject: RFR: 8331947: Preview creates checkbox for JEP-less preview
 feature [v4]
In-Reply-To: <F43zlb_9WvnIllMGeUWpN40nAQdY5FMWFMy2uVsZgRY=.377380f2-9000-4a68-bcaf-9a0488060cb6@github.com>
References: <_kx1TJGenvZCMoSaeGX1HdxQQWR8t24OOqnrq0SpOmY=.31389dd4-1e6f-4c18-bf15-273520afb6b8@github.com>
 <birqULAu0eTzbh9uY4_F0FPaIPDKlmErjYN8IarcKS8=.abc79d59-c21e-4860-a14a-363ce6c1c5db@github.com>
 <F43zlb_9WvnIllMGeUWpN40nAQdY5FMWFMy2uVsZgRY=.377380f2-9000-4a68-bcaf-9a0488060cb6@github.com>
Message-ID: <KmTJ98f7plq8DacHJCmk8SafSCQty7UnVQDL9_3KnM4=.4afbc0b3-ea14-4658-86cd-1a13111c880e@github.com>

On Wed, 5 Jun 2024 11:04:06 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Hannes Walln?fer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review feedback
>
> test/langtools/jdk/javadoc/doclet/testPreview/TestPreview.java line 161:
> 
>> 159:                     </ol>""");
>> 160: 
>> 161:         // 8331947: Support preview features without JEP should not be included in Preview API page
> 
> Trivial: here it is phrased as "Support preview features", while in the actual test source file it is "Preview support feature".

I agree the terminology in comments is somewhat inconsistent. I don't think there is an "official" term for these preview features. [In the CSR](https://bugs.openjdk.org/browse/JDK-8329634) they are summarized as follows: "Add a set of persistent preview visitors to support new language changes in development." 

I think the essential property for our purpose is the "without JEP". I added the "support" adjective to make their purpose clearer, but I don't think it's essential.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19344#discussion_r1627680852

From hannesw at openjdk.org  Wed Jun  5 12:43:01 2024
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Wed, 5 Jun 2024 12:43:01 GMT
Subject: Integrated: 8331947: Preview creates checkbox for JEP-less preview
 feature
In-Reply-To: <_kx1TJGenvZCMoSaeGX1HdxQQWR8t24OOqnrq0SpOmY=.31389dd4-1e6f-4c18-bf15-273520afb6b8@github.com>
References: <_kx1TJGenvZCMoSaeGX1HdxQQWR8t24OOqnrq0SpOmY=.31389dd4-1e6f-4c18-bf15-273520afb6b8@github.com>
Message-ID: <4-C4fdy0mVJi1DUKAW_ZigRR87uyYRoAqK7Y2xrhSdw=.5601a03c-0345-49a0-8f72-d0d310aea336@github.com>

On Wed, 22 May 2024 08:39:12 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a simple patch to exclude preview visitor classes meant to support future preview features from the Preview API page. 
> 
> The test adds an sample element annotated with the new `PreviewFeature.Feature.LANGUAGE_MODEL` constant (which does not have a `@JEP` annotation) to make sure it is not listed in the Preview API page. The test itself does not have to be modified, as it would fail without the change in `PreviewAPIListBuilder.java`.

This pull request has now been integrated.

Changeset: 765ad0e4
Author:    Hannes Walln?fer <hannesw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/765ad0e40bc522de4b2821ccc60b9139faf7376f
Stats:     97 lines in 8 files changed: 46 ins; 11 del; 40 mod

8331947: Preview creates checkbox for JEP-less preview feature

Reviewed-by: liach, prappo

-------------

PR: https://git.openjdk.org/jdk/pull/19344

From michael.osipov at innomotics.com  Wed Jun  5 09:51:28 2024
From: michael.osipov at innomotics.com (Osipov, Michael)
Date: Wed, 5 Jun 2024 09:51:28 +0000
Subject: Missing element-list for
 https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec
In-Reply-To: <d93a2dfe-50b8-4fe3-a680-cdad8aef4b81@oracle.com>
References: <5947f22d-0c8d-4063-b721-42b7dd44ba4c@siemens.com>
 <47A81E8E-1DFB-4CE1-A465-7FDE83F183DA@oracle.com>
 <d93a2dfe-50b8-4fe3-a680-cdad8aef4b81@oracle.com>
Message-ID: <PAVPR10MB7035701A19D9F217B471B27C8AF92@PAVPR10MB7035.EURPRD10.PROD.OUTLOOK.COM>

On 2024-05-31 21:38, Jonathan Gibbons wrote:
> Michael,
> 
> There is no `element-list` file for any version of JDK before JDK 9.    
> Before JDK 9, the appropriate information was in the `package-list` 
> file. In JDK 9, with the introduction of modules, the format of the file 
> was updated to include modules, and because this was an incompatible 
> change, the file was renamed as well, to `element-list`.
> 
> It is an annoying misconfiguration of `docs.oracle.com` that you are 
> seeing `302 Moved Temporarily` instead of `404 Not Found` which would be 
> a more semantically accurate response.
> 
> That leaves the question of why whatever you were doing was looking for 
> `element-list` in JDK 8. To answer that, we need more info, to determine 
> whether it is just a command-line error on your part, or any error in 
> the `javadoc` tool itself. What version of JDK and javadoc are you 
> using; what external libraries were you referencing in `-link` or `- 
> linkoffline` options; and what source level were you using, with either 
> the `-source` or `--release` options?

John,

thanks for the elaboration. Let me better clarify what happens.

The code is question with a modification for you is available at: 
https://github.com/michael-o/tomcatspnegoad/tree/javadoc-issue

Class net.sf.michaelo.tomcat.pac.asn1.AdIfRelevantAsn1Parser uses 
com.sun.security.jgss.AuthorizationDataEntry and others use private Sun 
classes which does not allow me to use -release for now, only -source. 
The source is Java 8. When I run javadoc:javadoc with Zulu 8 all links 
are generated successfully. Running Zulu 11 with extracted Javadoc call 
(&"C:\Program Files\Zulu\zulu-11\bin\javadoc.exe" -verbose "@options" 
"@packages") gives me no warning, even in verbose mode. It simply does 
not link.
When trying Temurin 22.0.1 (&"C:\Temp\jdk-22.0.1+8\bin\javadoc.exe" 
-verbose "@options" "@packages") it gives me:
> Warnung: URL https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec/element-list wurde umgeleitet an https://docs.oracle.com/en/java/javase/22/ - Aktualisieren Sie die Befehlszeilenoptionen, um diese Warnung zu unterdr?cken.

That is the redirect. Either I am misunderstanding or I have hit an edge 
case for public classes outside of the standard JDK (Java namespaces). 
Here is the input to Javadoc (@options, @packages) if you cannot try 
yourself: https://gist.github.com/michael-o/212c6797b000914b9142f1f077b1d9df

I have tried:
> Apache Maven 3.8.8 (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
> Maven home: C:\Entwicklung\Programme\apache-maven-3.8.8
> Java version: 11.0.18, vendor: Azul Systems, Inc., runtime: C:\Program Files\Zulu\zulu-11
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

> Apache Maven 3.8.8 (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
> Maven home: C:\Entwicklung\Programme\apache-maven-3.8.8
> Java version: 1.8.0_362, vendor: Azul Systems, Inc., runtime: C:\Program Files\Zulu\zulu-8\jre
> Default locale: de_DE, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

> Apache Maven 3.8.8 (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
> Maven home: C:\Entwicklung\Programme\apache-maven-3.8.8
> Java version: 22.0.1, vendor: Eclipse Adoptium, runtime: C:\Temp\jdk-22.0.1+8
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Note: I have routed the Javadoc traffic through Fiddler and it clearly 
following the misconfigured docs.oracle.com location:
> #	Result	Protocol	Host	URL	Body	Caching	Content-Type	Process	Comments	Custom	
> 10	302	HTTPS	docs.oracle.com	/javase/8/docs/jre/api/security/jgss/spec/element-list	1			javadoc:24660			
> #	Result	Protocol	Host	URL	Body	Caching	Content-Type	Process	Comments	Custom	
> 12	200	HTTPS	docs.oracle.com	/en/java/javase/22/	33 431	max-age=19052	text/html	javadoc:24660			


Regards,

Michael



From jonathan.gibbons at oracle.com  Thu Jun  6 23:11:56 2024
From: jonathan.gibbons at oracle.com (Jonathan Gibbons)
Date: Thu, 6 Jun 2024 16:11:56 -0700
Subject: [External] : Re: Missing element-list for
 https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec
In-Reply-To: <PAVPR10MB7035701A19D9F217B471B27C8AF92@PAVPR10MB7035.EURPRD10.PROD.OUTLOOK.COM>
References: <5947f22d-0c8d-4063-b721-42b7dd44ba4c@siemens.com>
 <47A81E8E-1DFB-4CE1-A465-7FDE83F183DA@oracle.com>
 <d93a2dfe-50b8-4fe3-a680-cdad8aef4b81@oracle.com>
 <PAVPR10MB7035701A19D9F217B471B27C8AF92@PAVPR10MB7035.EURPRD10.PROD.OUTLOOK.COM>
Message-ID: <94c6cf1c-21f3-4fb6-9c5a-4bd6cada8e4b@oracle.com>


On 6/5/24 2:51 AM, Osipov, Michael wrote:
> On 2024-05-31 21:38, Jonathan Gibbons wrote:
>> Michael,
>>
>> There is no `element-list` file for any version of JDK before JDK 9.
>> Before JDK 9, the appropriate information was in the `package-list`
>> file. In JDK 9, with the introduction of modules, the format of the file
>> was updated to include modules, and because this was an incompatible
>> change, the file was renamed as well, to `element-list`.
>>
>> It is an annoying misconfiguration of `docs.oracle.com` that you are
>> seeing `302 Moved Temporarily` instead of `404 Not Found` which would be
>> a more semantically accurate response.
>>
>> That leaves the question of why whatever you were doing was looking for
>> `element-list` in JDK 8. To answer that, we need more info, to determine
>> whether it is just a command-line error on your part, or any error in
>> the `javadoc` tool itself. What version of JDK and javadoc are you
>> using; what external libraries were you referencing in `-link` or `-
>> linkoffline` options; and what source level were you using, with either
>> the `-source` or `--release` options?
> John,
>
> thanks for the elaboration. Let me better clarify what happens.
>
> The code is question with a modification for you is available at:
> https://urldefense.com/v3/__https://github.com/michael-o/tomcatspnegoad/tree/javadoc-issue__;!!ACWV5N9M2RV99hQ!L6MibNz6g0M99jnVOo2O_Zs2vP8-4CM-NS4WNUmHmL5dB30i0qaSfDJBHW4S_bxjOhImERJfBWGpStJ6WrwE0WAva10xtV86PQ$  
>
> Class net.sf.michaelo.tomcat.pac.asn1.AdIfRelevantAsn1Parser uses
> com.sun.security.jgss.AuthorizationDataEntry and others use private Sun
> classes which does not allow me to use -release for now, only -source.
> The source is Java 8. When I run javadoc:javadoc with Zulu 8 all links
> are generated successfully. Running Zulu 11 with extracted Javadoc call
> (&"C:\Program Files\Zulu\zulu-11\bin\javadoc.exe" -verbose "@options"
> "@packages") gives me no warning, even in verbose mode. It simply does
> not link.
> When trying Temurin 22.0.1 (&"C:\Temp\jdk-22.0.1+8\bin\javadoc.exe"
> -verbose "@options" "@packages") it gives me:
>> Warnung: URLhttps://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec/element-list  wurde umgeleitet anhttps://docs.oracle.com/en/java/javase/22/  - Aktualisieren Sie die Befehlszeilenoptionen, um diese Warnung zu unterdr?cken.
> That is the redirect. Either I am misunderstanding or I have hit an edge
> case for public classes outside of the standard JDK (Java namespaces).
> Here is the input to Javadoc (@options, @packages) if you cannot try
> yourself:https://urldefense.com/v3/__https://gist.github.com/michael-o/212c6797b000914b9142f1f077b1d9df__;!!ACWV5N9M2RV99hQ!L6MibNz6g0M99jnVOo2O_Zs2vP8-4CM-NS4WNUmHmL5dB30i0qaSfDJBHW4S_bxjOhImERJfBWGpStJ6WrwE0WAva12c46QzhA$  
>
> I have tried:
>> Apache Maven 3.8.8 (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
>> Maven home: C:\Entwicklung\Programme\apache-maven-3.8.8
>> Java version: 11.0.18, vendor: Azul Systems, Inc., runtime: C:\Program Files\Zulu\zulu-11
>> Default locale: de_DE, platform encoding: UTF-8
>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>> Apache Maven 3.8.8 (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
>> Maven home: C:\Entwicklung\Programme\apache-maven-3.8.8
>> Java version: 1.8.0_362, vendor: Azul Systems, Inc., runtime: C:\Program Files\Zulu\zulu-8\jre
>> Default locale: de_DE, platform encoding: Cp1252
>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>> Apache Maven 3.8.8 (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
>> Maven home: C:\Entwicklung\Programme\apache-maven-3.8.8
>> Java version: 22.0.1, vendor: Eclipse Adoptium, runtime: C:\Temp\jdk-22.0.1+8
>> Default locale: de_DE, platform encoding: UTF-8
>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> Note: I have routed the Javadoc traffic through Fiddler and it clearly
> following the misconfigured docs.oracle.com location:
>> #	Result	Protocol	Host	URL	Body	Caching	Content-Type	Process	Comments	Custom	
>> 10	302	HTTPS	docs.oracle.com	/javase/8/docs/jre/api/security/jgss/spec/element-list	1			javadoc:24660			
>> #	Result	Protocol	Host	URL	Body	Caching	Content-Type	Process	Comments	Custom	
>> 12	200	HTTPS	docs.oracle.com	/en/java/javase/22/	33 431	max-age=19052	text/html	javadoc:24660			
>
> Regards,
>
> Michael
>
>

Michael,

I investigated a bit further, and I may have a solution for you.

The redirect is annoying, and sad to say, there is nothing I can do to 
get it fixed in a timely manner.? But, I think you may be able to work 
around it.? The answer is based on the content of the files in the gist 
that you referenced in your message.

Look at these lines:

-link
'https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec'
-linkoffline
'https://docs.oracle.com/javase/8/docs/api' 
'C:/Entwicklung/workspace-2023-06/tomcatspnegoad/tomcat90/target/javadoc-bundle-options' 


I'm not sure what is in your `javadoc-bundle-options` file, but it 
*ought* to be a local copy of the `package-list` found here:
https://docs.oracle.com/javase/8/docs/api/package-list

For the first option, the `-link` one, try changing it to:

-linkoffline
'https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec' 
/path/to/file

where `/path/to/file` is a local copy of the file found here:
https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec/package-list

which in reality is just:

com.sun.security.jgss

In other words, both options should be instances of the `-linkoffline` 
option, which should be of the form:

-linkofflinehttps:/url/to/api   /path/to/file

where `/path/to/file` is a local copy of the file downloaded from 
`https:/url/to/api/package-list`

Note I am using `.../package-list` in this message because you are using 
`-source 8`.? If you use a newer version of these APIs, you may need to 
change `package-list` to `element-list`. (I believe the change happened 
in JDK 11.)

For more details on the `-linkoffline` option, see
https://docs.oracle.com/en/java/javase/22/docs/specs/man/javadoc.html#option-linkoffline


-- Jon
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/javadoc-dev/attachments/20240606/d397e3b5/attachment-0001.htm>

From dholmes at openjdk.org  Mon Jun 10 02:38:25 2024
From: dholmes at openjdk.org (David Holmes)
Date: Mon, 10 Jun 2024 02:38:25 GMT
Subject: RFR: 8330205: Initial troff manpage generation for JDK 24
Message-ID: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>

Sets the version to 24/24-ea and the copyright year to 2025.

Content changes related to the start of release (e.g. for removed options in java.1) are handled separately.

This initial generation also picks up the unpublished changes from: 

- JDK-8330807: Update Manpage for obsoletion of ScavengeBeforeFullGC
- JDK-8284500: Typo in Supported Named Extensions - BasicContraints
- JDK-8324342: Doclet should default @since for a nested class to that of its enclosing class

Thanks

-------------

Commit messages:
 - 8330205: Initial troff manpage generation for JDK 24

Changes: https://git.openjdk.org/jdk/pull/19617/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19617&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8330205
  Stats: 66 lines in 28 files changed: 12 ins; 13 del; 41 mod
  Patch: https://git.openjdk.org/jdk/pull/19617.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19617/head:pull/19617

PR: https://git.openjdk.org/jdk/pull/19617

From alanb at openjdk.org  Mon Jun 10 07:18:11 2024
From: alanb at openjdk.org (Alan Bateman)
Date: Mon, 10 Jun 2024 07:18:11 GMT
Subject: RFR: 8330205: Initial troff manpage generation for JDK 24
In-Reply-To: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>
References: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>
Message-ID: <3hAM5el3W8wXMgyjuCGXpmRjCxld2dvHMiUbvarBPhU=.62cd1645-6bf1-4da4-b70e-70c12e6377c8@github.com>

On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Sets the version to 24/24-ea and the copyright year to 2025.
> 
> Content changes related to the start of release (e.g. for removed options in java.1) are handled separately.
> 
> This initial generation also picks up the unpublished changes from: 
> 
> - JDK-8330807: Update Manpage for obsoletion of ScavengeBeforeFullGC
> - JDK-8284500: Typo in Supported Named Extensions - BasicContraints
> - JDK-8324342: Doclet should default @since for a nested class to that of its enclosing class
> 
> Thanks

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19617#pullrequestreview-2106832118

From dholmes at openjdk.org  Mon Jun 10 08:04:12 2024
From: dholmes at openjdk.org (David Holmes)
Date: Mon, 10 Jun 2024 08:04:12 GMT
Subject: RFR: 8330205: Initial troff manpage generation for JDK 24
In-Reply-To: <3hAM5el3W8wXMgyjuCGXpmRjCxld2dvHMiUbvarBPhU=.62cd1645-6bf1-4da4-b70e-70c12e6377c8@github.com>
References: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>
 <3hAM5el3W8wXMgyjuCGXpmRjCxld2dvHMiUbvarBPhU=.62cd1645-6bf1-4da4-b70e-70c12e6377c8@github.com>
Message-ID: <G-MYWkkw506r9DLMCcme6orMWiD3hu1Wn6nRJuSIG_c=.94373b8a-b647-4e59-9a3e-053c012032aa@github.com>

On Mon, 10 Jun 2024 07:15:51 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Sets the version to 24/24-ea and the copyright year to 2025.
>> 
>> Content changes related to the start of release (e.g. for removed options in java.1) are handled separately.
>> 
>> This initial generation also picks up the unpublished changes from: 
>> 
>> - JDK-8330807: Update Manpage for obsoletion of ScavengeBeforeFullGC
>> - JDK-8284500: Typo in Supported Named Extensions - BasicContraints
>> - JDK-8324342: Doclet should default `@since` for a nested class to that of its enclosing class
>> 
>> Thanks
>
> Marked as reviewed by alanb (Reviewer).

Thanks for the review @AlanBateman !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19617#issuecomment-2157606095

From iris at openjdk.org  Mon Jun 10 17:30:15 2024
From: iris at openjdk.org (Iris Clark)
Date: Mon, 10 Jun 2024 17:30:15 GMT
Subject: RFR: 8330205: Initial troff manpage generation for JDK 24
In-Reply-To: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>
References: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>
Message-ID: <uNkk5qQaPdNEfH5YxUXvQL8CFKT63f4P-PKcE3vKcMw=.6270cb01-eb8e-4f51-986c-5e93ec02cdcf@github.com>

On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Sets the version to 24/24-ea and the copyright year to 2025.
> 
> Content changes related to the start of release (e.g. for removed options in java.1) are handled separately.
> 
> This initial generation also picks up the unpublished changes from: 
> 
> - JDK-8330807: Update Manpage for obsoletion of ScavengeBeforeFullGC
> - JDK-8284500: Typo in Supported Named Extensions - BasicContraints
> - JDK-8324342: Doclet should default `@since` for a nested class to that of its enclosing class
> 
> Thanks

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19617#pullrequestreview-2108383696

From dnguyen at openjdk.org  Mon Jun 10 20:05:33 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 10 Jun 2024 20:05:33 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
Message-ID: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>

This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.

The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.

Alternatively, the diffs are viewable here and was generated using John Gibbon's diff tool for l10n:
https://cr.openjdk.org/~dnguyen/output2/

-------------

Commit messages:
 - Review comment edits
 - Initial localization changes

Changes: https://git.openjdk.org/jdk/pull/19609/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8333827
  Stats: 239 lines in 39 files changed: 133 ins; 57 del; 49 mod
  Patch: https://git.openjdk.org/jdk/pull/19609.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609

PR: https://git.openjdk.org/jdk/pull/19609

From achung at openjdk.org  Mon Jun 10 20:05:33 2024
From: achung at openjdk.org (Alisen Chung)
Date: Mon, 10 Jun 2024 20:05:33 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
Message-ID: <b6aneCOmBcnk_v0W_sl89B94wwIeT12Zf2GwtSaG99A=.5d32dade-5b56-4179-9bbe-f07eb0352cfb@github.com>

On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
> 
> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
> 
> Alternatively, the diffs are viewable here and was generated using John Gibbon's diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/

Just a question about the reverted translations, otherwise LGTM

> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.

Any particular reason you know that the tool had the definitions adjusted? I see some of the changes look like like command line options not being translated, but it's a bit hard to tell. Do you know if the reverted words should be translated (and possibly will be re-translated in future drops?) or should they be left untranslated?

-------------

PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2105526180
PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2155723513

From jlu at openjdk.org  Mon Jun 10 20:05:33 2024
From: jlu at openjdk.org (Justin Lu)
Date: Mon, 10 Jun 2024 20:05:33 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
Message-ID: <6x05vtOnVTgxlyzPvesvYR9v3NUNHNkinbbaXJtXzxU=.492b5e27-02dd-4457-a725-705a3d6be7f9@github.com>

On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
> 
> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
> 
> Alternatively, the diffs are viewable here and was generated using John Gibbon's diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/

Cannot speak to the translations themselves, but in general the changes LGTM pending the comments.

src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties line 1:

> 1: #

It looks like these .properties files need to have their copyright years bumped. I believe since the original was not bumped, the translation tool did not reflect the correct year in the localized versions.

src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties line 66:

> 64: label.size=??(&Z):
> 65: label.source=??(&C):
> 66: label.outputbins=????(&P)?

Looks like the translation tool changed this from a colon (U+003A) to a full width colon (U+FF1A). There are l10n rules when it comes to punctuation, I am not sure if this is a result of that. It looks like the surrounding key/values are simply using (U+003A) colons. If we decide to revert this colon change, we need to also probably file a bug against the translation tool.

src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties line 278:

> 276:         UndeclaredElementInContentSpec = Contentmodell des Elements "{0}" verweist auf das nicht deklarierte Element "{1}".
> 277:         UniqueNotationName = Deklaration f?r die Notation "{0}" ist nicht eindeutig. Ein jeweiliger Name darf nicht in mehreren Notationsdeklarationen deklariert werden.
> 278:         ENTITYFailedInitializeGrammar =  ENTITYDatatype-Validator: Nicht erfolgreich. Initialisierungsmethode muss mit einer g?ltigen Grammatikreferenz aufgerufen werden. \t

It looks like the _zh_CN_ file should also have the `\t` removed, but such changes are done by the translation tool. I think in this case, we should manually remove it, and then file a bug against the translation tool.

src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties line 285:

> 283: VIRTUAL_MACHINE=Virtuelle Maschine
> 284: VM_ARGUMENTS=VM-Argumente
> 285: VMINTERNAL_FRAME_ACCESSIBLE_DESCRIPTION=Innerer Frame f?r das Monitoring einer Java Virtual Machine

This one-off change is consistent with the change in _src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java_.

src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_de.properties line 183:

> 181: jshell.fix.wrong.shortcut =Unerwartetes Zeichen nach Umschalt+Tab.\nVerwenden Sie "I" f?r automatischen Import, "V" zur Variablenerstellung oder "M" zur Methodenerstellung.\nWeitere Informationen finden Sie unter:\n/help shortcuts
> 182: 
> 183: help.usage = Verwendung:   jshell <option>... <load-file>...\nM?gliche Optionen:\n    --class-path <path>   Gibt an, wo die Benutzerklassendateien gespeichert sind\n    --module-path <path>  Gibt an, wo die Anwendungsmodule gespeichert sind\n    --add-modules <module>(,<module>)*\n                          Gibt aufzul?sende Module oder alle Module im\n                            Modulpfad an, wenn <module> ALL-MODULE-PATHs lautet\n    --enable-native-access\n                          Erm?glicht Ausf?hrung eingeschr?nkter nativer Methoden durch Code\n    --enable-preview      Code kann Vorschaufeatures in diesem Release nutzen\n    --startup <Datei>      Ersetzung der Startdefinitionen mit einer Ausf?hrung\n    --no-startup          Startdefinitionen werden nicht ausgef?hrt\n    --feedback <Modus>     Gibt den anf?nglichen Feedbackmodus an. Der Modus kann\n                            vordefiniert (Silent, Concise, Normal oder Verbose) oder\n                            v
 orab benutzerdefiniert sein\n    -q                    Stilles Feedback. Identisch mit: --feedback concise\n    -s                    ?u?erst stilles Feedback. Identisch mit: --feedback silent\n    -v                    Verbose-Feedback. Identisch mit: --feedback verbose\n    -J<flag>              ?bergibt <flag> an das Laufzeitsystem, hat aber keine Auswirkungen\n                            auf die Ausf?hrung von Code-Snippets. Um Kennzeichen anzugeben,\n                            die die Ausf?hrung von Code-Snippets beeinflussen, verwenden Sie\n                            -R<flag>. Verwenden Sie alternativ dazu -J<flag> mit\n                            --execution local.\n    -R<flag>              ?bergibt <flag> nur dann an das Laufzeitsystem, wenn\n                            Code-Snippets ausgef?hrt werden. Beispiel: -R-Dfoo=bar\n                            bedeutet, dass die Ausf?hrung des Snippets\n                            System.getProperty("foo") "bar" zur?ckgi
 bt.\n    -C<flag>              ?bergibt <flag> an den Java-Compiler in JShell.\n                            Beispiel: -C-Xlint aktiviert alle empfohlenen\n                            LINT-Warnungen, und -C--release=<N> kompiliert f?r\n                            Java SE N, wie wenn --release N angegeben wird.\n                            Verwenden Sie ein -C pro Compiler-Kennzeichen oder Kennzeichenargument\n    --version             Gibt Versionsinformationen aus und beendet den Vorgang\n    --show-version        Gibt Versionsinformationen aus und setzt den Vorgang fort\n    --help, -?, -h        Gibt diese Zusammenfassung der Standardoptionen aus und beendet den Vorgang\n    --help-extra, -X      Gibt Hilfetext zu Nicht-Standardoptionen aus und beendet den Vorgang\n\nEin Dateiargument kann ein Dateiname oder einer der vordefinierten Dateinamen sein: DEFAULT,\nPRINTING, TOOLING oder JAVASE.\nEine Ladedatei kann auch "-" zur Angabe einer Standardeingabe ohne interaktiven I/O sein.
 \n\nWeitere Informationen zu den Auswertungskontextoptionen (--class-path,\n--module-path und --add-modules) finden Sie unter:\n\t/help context\n\nEin Pfad listet die zu durchsuchenden Verzeichnisse und Archive auf. Verwenden Sie unter Windows ein\nSemikolon (;), um Elemente im Pfad zu trennen. Verwenden Sie auf anderen Plattformen einen\nDoppelpunkt (:), um Elemente zu trennen.\n

> Any particular reason you know that the tool had the definitions adjusted? I see some of the changes look like like command line options not being translated, but it's a bit hard to tell. Do you know if the reverted words should be translated (and possibly will be re-translated in future drops?) or should they be left untranslated?

@alisenchung While these command line options are untranslated, which initially may seem confusing, it appears to be the translation tool standardizing the definitions with the Japanese and Chinese localized definitions. We should leave them untranslated.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2106349441
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1632407907
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1632376640
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1632375726
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1632377328
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1632373349

From dnguyen at openjdk.org  Mon Jun 10 20:05:33 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 10 Jun 2024 20:05:33 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <6x05vtOnVTgxlyzPvesvYR9v3NUNHNkinbbaXJtXzxU=.492b5e27-02dd-4457-a725-705a3d6be7f9@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <6x05vtOnVTgxlyzPvesvYR9v3NUNHNkinbbaXJtXzxU=.492b5e27-02dd-4457-a725-705a3d6be7f9@github.com>
Message-ID: <wk1BTXn55Ouaqbe_dkzkgpOMsrlIkQVDk5he2qLxgF8=.0ee9ea01-13f5-4c0a-91e2-24cd031eb91e@github.com>

On Sun, 9 Jun 2024 22:49:11 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>> 
>> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
>> 
>> Alternatively, the diffs are viewable here and was generated using John Gibbon's diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties line 1:
> 
>> 1: #
> 
> It looks like these .properties files need to have their copyright years bumped. I believe since the original was not bumped, the translation tool did not reflect the correct year in the localized versions.

Right, the source file has the copyright year of 2019, and these translated files reflect that, so I believe this is OK.

> src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties line 66:
> 
>> 64: label.size=??(&Z):
>> 65: label.source=??(&C):
>> 66: label.outputbins=????(&P)?
> 
> Looks like the translation tool changed this from a colon (U+003A) to a full width colon (U+FF1A). There are l10n rules when it comes to punctuation, I am not sure if this is a result of that. It looks like the surrounding key/values are simply using (U+003A) colons. If we decide to revert this colon change, we need to also probably file a bug against the translation tool.

Right, I agree. I'm OK with either decision too, but I'm leaning towards reverting this to standardize the colons since the rest are (U+003A). Maybe a reviewer from desktop can chime in once this PR is undrafted.

> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties line 278:
> 
>> 276:         UndeclaredElementInContentSpec = Contentmodell des Elements "{0}" verweist auf das nicht deklarierte Element "{1}".
>> 277:         UniqueNotationName = Deklaration f?r die Notation "{0}" ist nicht eindeutig. Ein jeweiliger Name darf nicht in mehreren Notationsdeklarationen deklariert werden.
>> 278:         ENTITYFailedInitializeGrammar =  ENTITYDatatype-Validator: Nicht erfolgreich. Initialisierungsmethode muss mit einer g?ltigen Grammatikreferenz aufgerufen werden. \t
> 
> It looks like the _zh_CN_ file should also have the `\t` removed, but such changes are done by the translation tool. I think in this case, we should manually remove it, and then file a bug against the translation tool.

Yeah, I believe you're right. Noted as something else to file against the translation tool.

> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_de.properties line 183:
> 
>> 181: jshell.fix.wrong.shortcut =Unerwartetes Zeichen nach Umschalt+Tab.\nVerwenden Sie "I" f?r automatischen Import, "V" zur Variablenerstellung oder "M" zur Methodenerstellung.\nWeitere Informationen finden Sie unter:\n/help shortcuts
>> 182: 
>> 183: help.usage = Verwendung:   jshell <option>... <load-file>...\nM?gliche Optionen:\n    --class-path <path>   Gibt an, wo die Benutzerklassendateien gespeichert sind\n    --module-path <path>  Gibt an, wo die Anwendungsmodule gespeichert sind\n    --add-modules <module>(,<module>)*\n                          Gibt aufzul?sende Module oder alle Module im\n                            Modulpfad an, wenn <module> ALL-MODULE-PATHs lautet\n    --enable-native-access\n                          Erm?glicht Ausf?hrung eingeschr?nkter nativer Methoden durch Code\n    --enable-preview      Code kann Vorschaufeatures in diesem Release nutzen\n    --startup <Datei>      Ersetzung der Startdefinitionen mit einer Ausf?hrung\n    --no-startup          Startdefinitionen werden nicht ausgef?hrt\n    --feedback <Modus>     Gibt den anf?nglichen Feedbackmodus an. Der Modus kann\n                            vordefiniert (Silent, Concise, Normal oder Verbose) oder\n                            
 vorab benutzerdefiniert sein\n    -q                    Stilles Feedback. Identisch mit: --feedback concise\n    -s                    ?u?erst stilles Feedback. Identisch mit: --feedback silent\n    -v                    Verbose-Feedback. Identisch mit: --feedback verbose\n    -J<flag>              ?bergibt <flag> an das Laufzeitsystem, hat aber keine Auswirkungen\n                            auf die Ausf?hrung von Code-Snippets. Um Kennzeichen anzugeben,\n                            die die Ausf?hrung von Code-Snippets beeinflussen, verwenden Sie\n                            -R<flag>. Verwenden Sie alternativ dazu -J<flag> mit\n                            --execution local.\n    -R<flag>              ?bergibt <flag> nur dann an das Laufzeitsystem, wenn\n                            Code-Snippets ausgef?hrt werden. Beispiel: -R-Dfoo=bar\n                            bedeutet, dass die Ausf?hrung des Snippets\n                            System.getProperty("foo") "bar" zur?ckg
 ibt.\n    -C<flag>              ?bergibt <flag> an den Java-Compiler in JShell.\n                            Beispiel: -C-Xlint aktiviert alle empfohlenen\n                           ...

This is what I've determined as well. I planned to leave these untranslated to reduce noise between drops as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633762275
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1632401147
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633748812
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1632401256

From jjg at openjdk.org  Mon Jun 10 20:15:13 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Mon, 10 Jun 2024 20:15:13 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <wk1BTXn55Ouaqbe_dkzkgpOMsrlIkQVDk5he2qLxgF8=.0ee9ea01-13f5-4c0a-91e2-24cd031eb91e@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <6x05vtOnVTgxlyzPvesvYR9v3NUNHNkinbbaXJtXzxU=.492b5e27-02dd-4457-a725-705a3d6be7f9@github.com>
 <wk1BTXn55Ouaqbe_dkzkgpOMsrlIkQVDk5he2qLxgF8=.0ee9ea01-13f5-4c0a-91e2-24cd031eb91e@github.com>
Message-ID: <06n4CAAdscvysfgXBWG-uWwIUSIt4D_o1wppGATS1II=.7c9a46de-2b24-482b-8f67-77741a7ae938@github.com>

On Sun, 9 Jun 2024 22:07:44 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_de.properties line 183:
>> 
>>> 181: jshell.fix.wrong.shortcut =Unerwartetes Zeichen nach Umschalt+Tab.\nVerwenden Sie "I" f?r automatischen Import, "V" zur Variablenerstellung oder "M" zur Methodenerstellung.\nWeitere Informationen finden Sie unter:\n/help shortcuts
>>> 182: 
>>> 183: help.usage = Verwendung:   jshell <option>... <load-file>...\nM?gliche Optionen:\n    --class-path <path>   Gibt an, wo die Benutzerklassendateien gespeichert sind\n    --module-path <path>  Gibt an, wo die Anwendungsmodule gespeichert sind\n    --add-modules <module>(,<module>)*\n                          Gibt aufzul?sende Module oder alle Module im\n                            Modulpfad an, wenn <module> ALL-MODULE-PATHs lautet\n    --enable-native-access\n                          Erm?glicht Ausf?hrung eingeschr?nkter nativer Methoden durch Code\n    --enable-preview      Code kann Vorschaufeatures in diesem Release nutzen\n    --startup <Datei>      Ersetzung der Startdefinitionen mit einer Ausf?hrung\n    --no-startup          Startdefinitionen werden nicht ausgef?hrt\n    --feedback <Modus>     Gibt den anf?nglichen Feedbackmodus an. Der Modus kann\n                            vordefiniert (Silent, Concise, Normal oder Verbose) oder\n                           
  vorab benutzerdefiniert sein\n    -q                    Stilles Feedback. Identisch mit: --feedback concise\n    -s                    ?u?erst stilles Feedback. Identisch mit: --feedback silent\n    -v                    Verbose-Feedback. Identisch mit: --feedback verbose\n    -J<flag>              ?bergibt <flag> an das Laufzeitsystem, hat aber keine Auswirkungen\n                            auf die Ausf?hrung von Code-Snippets. Um Kennzeichen anzugeben,\n                            die die Ausf?hrung von Code-Snippets beeinflussen, verwenden Sie\n                            -R<flag>. Verwenden Sie alternativ dazu -J<flag> mit\n                            --execution local.\n    -R<flag>              ?bergibt <flag> nur dann an das Laufzeitsystem, wenn\n                            Code-Snippets ausgef?hrt werden. Beispiel: -R-Dfoo=bar\n                            bedeutet, dass die Ausf?hrung des Snippets\n                            System.getProperty("foo") "bar" zur?ck
 gibt.\n    -C<flag>              ?bergibt <flag> an den Java-Compiler in JShell.\n                            Beispiel: -C-Xlint aktiviert alle empfohlenen\n                    ...
>
> This is what I've determined as well. I planned to leave these untranslated to reduce noise between drops as well.

While we do not translate Java keywords (when used as such, e.g. "`class` not allowed here"), and option names (e.g. `--class-path`) we have typically translated other text that is not mandated by the language or tools, (e.g. `the name of this class`, `<args>`, `<class-path>`.

This change seems to be going backwards.

Whatever the policy we use for translating (or not translating) parts of a message, we should be consistent across all tools and documents.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633774912

From prr at openjdk.org  Mon Jun 10 20:23:22 2024
From: prr at openjdk.org (Phil Race)
Date: Mon, 10 Jun 2024 20:23:22 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
Message-ID: <4SzROPbfO7QDv-6_f_D3ntFvyEpXOvV9vsnb1LNU7Os=.b0fcfbbd-8c54-4443-b06d-722da305490d@github.com>

On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
> 
> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
> 
> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/

src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties line 66:

> 64: label.size=G&r??e:
> 65: label.source=&Quelle:
> 66: label.outputbins=A&usgabef?cher:

How confident are we in this ?
google translate says that the old text referred to 'compartments' and the new one to 'areas' and I wonder why that is better ?

https://translate.google.com/?sl=auto&tl=en&text=Ausgabebereiche%0AAusgebefacher&op=translate

src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties line 32:

> 30: border.jobattributes=????
> 31: border.media=??
> 32: border.output=??

What triggered this ? Just someone noticing it and deciding there's a better translation ?
What does it say ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633781646
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633782742

From jjg at openjdk.org  Mon Jun 10 20:23:23 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Mon, 10 Jun 2024 20:23:23 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
Message-ID: <SjpwOVwkqCFBlC_Vj1rv4JwgHdgqnpiz8xrDTE98eOc=.c90d5753-0206-48e9-bfb4-8e6bc67c616a@github.com>

On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
> 
> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
> 
> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/

src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties line 409:

> 407: compiler.err.unconditional.pattern.and.default=Switch umfasst sowohl ein nicht bedingtes Muster als auch ein Standardlabel
> 408: 
> 409: compiler.err.unconditional.pattern.and.both.boolean.values=Switch umfasst sowohl boolesche Werte als auch ein nicht bedingtes Muster

Here and elsewhere in this file and other translations, I'm surprised `switch` is not being translated, and is being capitalized. In the English form, it is not being used as a keyword, although could maybe be seen as a short form of `switch' statement, in which case `switch` should be treated as a keyword and not translated or capitalized.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633782242

From dnguyen at openjdk.org  Mon Jun 10 20:37:13 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 10 Jun 2024 20:37:13 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <SjpwOVwkqCFBlC_Vj1rv4JwgHdgqnpiz8xrDTE98eOc=.c90d5753-0206-48e9-bfb4-8e6bc67c616a@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <SjpwOVwkqCFBlC_Vj1rv4JwgHdgqnpiz8xrDTE98eOc=.c90d5753-0206-48e9-bfb4-8e6bc67c616a@github.com>
Message-ID: <2-SMv3j3Eqrv7LVV6CbkZVEb3KFcahQR1_8AiJErDAQ=.07538bd6-9b25-45ed-b47f-8e9102ea8af9@github.com>

On Mon, 10 Jun 2024 20:20:26 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>> 
>> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
>> 
>> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties line 409:
> 
>> 407: compiler.err.unconditional.pattern.and.default=Switch umfasst sowohl ein nicht bedingtes Muster als auch ein Standardlabel
>> 408: 
>> 409: compiler.err.unconditional.pattern.and.both.boolean.values=Switch umfasst sowohl boolesche Werte als auch ein nicht bedingtes Muster
> 
> Here and elsewhere in this file and other translations, I'm surprised `switch` is not being translated, and is being capitalized. In the English form, it is not being used as a keyword, although could maybe be seen as a short form of `switch' statement, in which case `switch` should be treated as a keyword and not translated or capitalized.

Good catch. Seems to be across all files and I'm assuming it's for the reason you suggested. I'll bring this up to the go team. I have no way to fix this since I can't rely on google translate. This can be caught in a future update if the go team can successfully differentiate the difference between the word `switch` and a `switch keyword`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633796771

From dnguyen at openjdk.org  Mon Jun 10 20:37:14 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 10 Jun 2024 20:37:14 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <06n4CAAdscvysfgXBWG-uWwIUSIt4D_o1wppGATS1II=.7c9a46de-2b24-482b-8f67-77741a7ae938@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <6x05vtOnVTgxlyzPvesvYR9v3NUNHNkinbbaXJtXzxU=.492b5e27-02dd-4457-a725-705a3d6be7f9@github.com>
 <wk1BTXn55Ouaqbe_dkzkgpOMsrlIkQVDk5he2qLxgF8=.0ee9ea01-13f5-4c0a-91e2-24cd031eb91e@github.com>
 <06n4CAAdscvysfgXBWG-uWwIUSIt4D_o1wppGATS1II=.7c9a46de-2b24-482b-8f67-77741a7ae938@github.com>
Message-ID: <P4mDp3QdSzjC6Fdj2ZmhOdNl5GcRrEb6PexlIZYYHpI=.9b384ebb-9dee-4b33-8fc2-370818ac80a3@github.com>

On Mon, 10 Jun 2024 20:12:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> This is what I've determined as well. I planned to leave these untranslated to reduce noise between drops as well.
>
> While we do not translate Java keywords (when used as such, e.g. "`class` not allowed here"), and option names (e.g. `--class-path`) we have typically translated other text that is not mandated by the language or tools, (e.g. `the name of this class`, `<args>`, `<class-path>`.
> 
> This change seems to be going backwards.
> 
> Whatever the policy we use for translating (or not translating) parts of a message, we should be consistent across all tools and documents.

The go translation team dictates which of these segments within a file actually get updated. I can manually revert the segments if preferred, but these changes will continue appearing for future drops with the current system. 

I can potentially try to communicate to the other team to differentiate between keywords & option names versus some of these other words, but let me know how you'd like me to proceed with this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633794362

From dnguyen at openjdk.org  Mon Jun 10 20:40:15 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 10 Jun 2024 20:40:15 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <4SzROPbfO7QDv-6_f_D3ntFvyEpXOvV9vsnb1LNU7Os=.b0fcfbbd-8c54-4443-b06d-722da305490d@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <4SzROPbfO7QDv-6_f_D3ntFvyEpXOvV9vsnb1LNU7Os=.b0fcfbbd-8c54-4443-b06d-722da305490d@github.com>
Message-ID: <0xmUIRy1V_ts7yyfm1kMaQfbzU5YoJSWAzD3QDNLY7U=.8e0e163e-d0c6-4f22-a92d-79de8c58e8f6@github.com>

On Mon, 10 Jun 2024 20:20:52 GMT, Phil Race <prr at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>> 
>> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
>> 
>> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties line 32:
> 
>> 30: border.jobattributes=????
>> 31: border.media=??
>> 32: border.output=??
> 
> What triggered this ? Just someone noticing it and deciding there's a better translation ?
> What does it say ?

In the past, it was brought up in review that some of the words were translated to localized words that didn't exactly mean what the original English word meant. I believe Weijun Wang caught some of these in Chinese files in the past.  I'm assuming these are cases where the go team is improving the translation, but I also can't exactly tell. We do suggest changes to the go team, so maybe this is evidence of them improving their tool.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633801033

From naoto at openjdk.org  Mon Jun 10 20:49:13 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Mon, 10 Jun 2024 20:49:13 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
Message-ID: <RdC2DWY9T4c_CtoDC0VQQO-glDmN41Gyjl3ZevJgU5c=.525f206b-ef90-4856-bd4e-e6e0b26822e6@github.com>

On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
> 
> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
> 
> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/

Did not look at each for translation accuracy (did some for Japanese), but looks good overall.
It's great to see diffs in native languages, rather than those cryptic `\uXXXX` notation!

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2108722631

From dnguyen at openjdk.org  Mon Jun 10 21:45:13 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 10 Jun 2024 21:45:13 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <RdC2DWY9T4c_CtoDC0VQQO-glDmN41Gyjl3ZevJgU5c=.525f206b-ef90-4856-bd4e-e6e0b26822e6@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <RdC2DWY9T4c_CtoDC0VQQO-glDmN41Gyjl3ZevJgU5c=.525f206b-ef90-4856-bd4e-e6e0b26822e6@github.com>
Message-ID: <ib1NQFG8TW7Wr6ZMzxxxF5JreiZiVPHoyTHn--6ad2k=.f01f7a8c-49cc-42fc-84f3-16a6afc5b8fc@github.com>

On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Did not look at each for translation accuracy (did some for Japanese), but looks good overall. It's great to see diffs in native languages, rather than those cryptic `\uXXXX` notation!

Justin's tool is responsible for this. Made the process quicker/simpler as well once everything was setup properly and working.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2159331304

From dnguyen at openjdk.org  Mon Jun 10 21:45:14 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 10 Jun 2024 21:45:14 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <06n4CAAdscvysfgXBWG-uWwIUSIt4D_o1wppGATS1II=.7c9a46de-2b24-482b-8f67-77741a7ae938@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <6x05vtOnVTgxlyzPvesvYR9v3NUNHNkinbbaXJtXzxU=.492b5e27-02dd-4457-a725-705a3d6be7f9@github.com>
 <wk1BTXn55Ouaqbe_dkzkgpOMsrlIkQVDk5he2qLxgF8=.0ee9ea01-13f5-4c0a-91e2-24cd031eb91e@github.com>
 <06n4CAAdscvysfgXBWG-uWwIUSIt4D_o1wppGATS1II=.7c9a46de-2b24-482b-8f67-77741a7ae938@github.com>
Message-ID: <8fptu16lcceBUEid012EvN4KHhrf3gjzPRgdOANg_Kk=.4d3d1e78-17f9-4248-89ca-99ca03370e71@github.com>

On Mon, 10 Jun 2024 20:12:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> This is what I've determined as well. I planned to leave these untranslated to reduce noise between drops as well.
>
> While we do not translate Java keywords (when used as such, e.g. "`class` not allowed here"), and option names (e.g. `--class-path`) we have typically translated other text that is not mandated by the language or tools, (e.g. `the name of this class`, `<args>`, `<class-path>`.
> 
> This change seems to be going backwards.
> 
> Whatever the policy we use for translating (or not translating) parts of a message, we should be consistent across all tools and documents.

@jonathan-gibbons I just realized that this change to the German file matches the file with the Japanese and Chinese localized files. By that I mean the "backwards" translations are also present for the Japanese and Chinese files.

However, the previous versions of the Japanese and Chinese files don't have these bits translated. So in summary, I can revert the German file back to German but the Japanese and Chinese files will still be English for these parts because I wouldn't know what to revert them to in their local language.

As a result, I actually think it might be better to change this German file as shown in the current version of the PR just to remain consistent with the other localized versions of this file. We can still bring this up to the go team as an issue, but I think this is the best solution now for this drop at least.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633859027

From joehw at openjdk.org  Mon Jun 10 21:54:14 2024
From: joehw at openjdk.org (Joe Wang)
Date: Mon, 10 Jun 2024 21:54:14 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
Message-ID: <ADcUl2k8pnbEDcAvLsEOBA05LjviX8HmX3OAlGEK5Mw=.05eee615-de93-4792-a8d8-5c2ea8a0dabe@github.com>

On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
> 
> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
> 
> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/

One minor comment, otherwise the java.xml changes look good.

src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties line 331:

> 329: 
> 330: # Implementation Property DTD
> 331:         JDK_DTD_DENY = JAXP00010008: DOCTYPE ist nicht zul?ssig, wenn die DTD-Eigenschaft auf "Ablehnen" gesetzt wurde. Weitere Informationen: Eigenschaft jdk.xml.dtd.support in java.xml/module-summary.

either drop the double quote in "Ablehnen" or use the literal without translation, that is, "deny".

-------------

Marked as reviewed by joehw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2108813421
PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633870136

From dnguyen at openjdk.org  Mon Jun 10 21:58:29 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 10 Jun 2024 21:58:29 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
Message-ID: <RMYfMzeTjSTgC0E5UhO44fJsnjtjn7JaokyIswpzljg=.ae3644a2-376e-4249-8a6b-8b02306b5aba@github.com>

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
> 
> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
> 
> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Remove double quotes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19609/files
  - new: https://git.openjdk.org/jdk/pull/19609/files/9125337b..32d69e89

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19609.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609

PR: https://git.openjdk.org/jdk/pull/19609

From cjplummer at openjdk.org  Mon Jun 10 22:27:15 2024
From: cjplummer at openjdk.org (Chris Plummer)
Date: Mon, 10 Jun 2024 22:27:15 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <RMYfMzeTjSTgC0E5UhO44fJsnjtjn7JaokyIswpzljg=.ae3644a2-376e-4249-8a6b-8b02306b5aba@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <RMYfMzeTjSTgC0E5UhO44fJsnjtjn7JaokyIswpzljg=.ae3644a2-376e-4249-8a6b-8b02306b5aba@github.com>
Message-ID: <ivxoCg1QhjwpzbGR6T6rHreTkqv-NVFo7jZYwNL0LiM=.c10bee70-9ca8-4db5-89b1-ee7682729e3d@github.com>

On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>> 
>> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
>> 
>> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove double quotes

src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java line 325:

> 323:         {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"},
> 324:         {"unknown", "unbekannt"},
> 325:         {"Unmonitoring", "Monitoring von {0} aufheben"},

The English entry is:

        {"Unmonitoring", "Unmonitoring {0} "},

But the German entry now says "Monitoring". I'm  sure what the original "\u00DCberwachung" translates to, other than berwachung is monitoring. Now this resource is partly in English, and is the incorrect English.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633902362

From dnguyen at openjdk.org  Mon Jun 10 22:51:14 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Mon, 10 Jun 2024 22:51:14 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <ivxoCg1QhjwpzbGR6T6rHreTkqv-NVFo7jZYwNL0LiM=.c10bee70-9ca8-4db5-89b1-ee7682729e3d@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <RMYfMzeTjSTgC0E5UhO44fJsnjtjn7JaokyIswpzljg=.ae3644a2-376e-4249-8a6b-8b02306b5aba@github.com>
 <ivxoCg1QhjwpzbGR6T6rHreTkqv-NVFo7jZYwNL0LiM=.c10bee70-9ca8-4db5-89b1-ee7682729e3d@github.com>
Message-ID: <iJZMTs0UUdFqw07uiMXQrkv3QBeyv70VQyyVZtFy5k4=.22762511-49c4-4ad6-a198-38d2be8ac4f6@github.com>

On Mon, 10 Jun 2024 22:19:49 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove double quotes
>
> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java line 325:
> 
>> 323:         {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"},
>> 324:         {"unknown", "unbekannt"},
>> 325:         {"Unmonitoring", "Monitoring von {0} aufheben"},
> 
> The English entry is:
> 
>         {"Unmonitoring", "Unmonitoring {0} "},
> 
> But the German entry now says "Monitoring". I'm  sure what the original "\u00DCberwachung" translates to, other than berwachung is monitoring. Now this resource is partly in English, and is the incorrect English.

I don't know German, but when plugging `"Monitoring von {0} aufheben"` into google translate, I get `Unmonitoring` as well. Maybe `Monitoring` is a word that could also be used in German? No clue. The translation tool decided to make this change.

@sormuras do you have any input on this?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633925334

From jjg at openjdk.org  Mon Jun 10 23:13:15 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Mon, 10 Jun 2024 23:13:15 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <8fptu16lcceBUEid012EvN4KHhrf3gjzPRgdOANg_Kk=.4d3d1e78-17f9-4248-89ca-99ca03370e71@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <6x05vtOnVTgxlyzPvesvYR9v3NUNHNkinbbaXJtXzxU=.492b5e27-02dd-4457-a725-705a3d6be7f9@github.com>
 <wk1BTXn55Ouaqbe_dkzkgpOMsrlIkQVDk5he2qLxgF8=.0ee9ea01-13f5-4c0a-91e2-24cd031eb91e@github.com>
 <06n4CAAdscvysfgXBWG-uWwIUSIt4D_o1wppGATS1II=.7c9a46de-2b24-482b-8f67-77741a7ae938@github.com>
 <8fptu16lcceBUEid012EvN4KHhrf3gjzPRgdOANg_Kk=.4d3d1e78-17f9-4248-89ca-99ca03370e71@github.com>
Message-ID: <Ss1KZ4NwolVYPiXv46jXJ05_pDMCkOY4GHYlq5stnCc=.135e6f50-206b-4f75-acf4-4574eaf84951@github.com>

On Mon, 10 Jun 2024 21:38:18 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> While we do not translate Java keywords (when used as such, e.g. "`class` not allowed here"), and option names (e.g. `--class-path`) we have typically translated other text that is not mandated by the language or tools, (e.g. `the name of this class`, `<args>`, `<class-path>`.
>> 
>> This change seems to be going backwards.
>> 
>> Whatever the policy we use for translating (or not translating) parts of a message, we should be consistent across all tools and documents.
>
> @jonathan-gibbons I just realized that this change to the German file matches the file with the Japanese and Chinese localized files. By that I mean the "backwards" translations are also present for the Japanese and Chinese files.
> 
> However, the previous versions of the Japanese and Chinese files don't have these bits translated. So in summary, I can revert the German file back to German but the Japanese and Chinese files will still be English for these parts because I wouldn't know what to revert them to in their local language.
> 
> As a result, I actually think it might be better to change this German file as shown in the current version of the PR just to remain consistent with the other localized versions of this file. We can still bring this up to the go team as an issue, but I think this is the best solution now for this drop at least.

No one else except people reading this PR will spot inconsistencies between translations in different languages. So inconsistencies across languages will not be obvious to end users.

But anyone (end-user) using the tool in any one of these languages is likely to spot inconsistencies in the translations for that one language.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1633937355

From dholmes at openjdk.org  Tue Jun 11 00:50:28 2024
From: dholmes at openjdk.org (David Holmes)
Date: Tue, 11 Jun 2024 00:50:28 GMT
Subject: RFR: 8330205: Initial troff manpage generation for JDK 24 [v2]
In-Reply-To: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>
References: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>
Message-ID: <aepA-ImIyckFwPaf4cS2pizlON3SYyrfc5BK9Y1SJwU=.50de780d-25c0-4da3-9066-52b1a472b8de@github.com>

> Sets the version to 24/24-ea and the copyright year to 2025.
> 
> Content changes related to the start of release (e.g. for removed options in java.1) are handled separately.
> 
> This initial generation also picks up the unpublished changes from: 
> 
> - JDK-8330807: Update Manpage for obsoletion of ScavengeBeforeFullGC
> - JDK-8284500: Typo in Supported Named Extensions - BasicContraints
> - JDK-8324342: Doclet should default `@since` for a nested class to that of its enclosing class
> 
> Thanks

David Holmes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Merge
 - 8330205: Initial troff manpage generation for JDK 24

-------------

Changes: https://git.openjdk.org/jdk/pull/19617/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19617&range=01
  Stats: 53 lines in 28 files changed: 12 ins; 3 del; 38 mod
  Patch: https://git.openjdk.org/jdk/pull/19617.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19617/head:pull/19617

PR: https://git.openjdk.org/jdk/pull/19617

From dholmes at openjdk.org  Tue Jun 11 01:02:39 2024
From: dholmes at openjdk.org (David Holmes)
Date: Tue, 11 Jun 2024 01:02:39 GMT
Subject: RFR: 8330205: Initial troff manpage generation for JDK 24 [v3]
In-Reply-To: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>
References: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>
Message-ID: <fxPYBQ2lvXomy6ZaWwe2l7ucWeyV5Yd9dl7b7lZl5ho=.e8c4eae1-cf24-42e2-a86a-f5e3e0f6163c@github.com>

> Sets the version to 24/24-ea and the copyright year to 2025.
> 
> Content changes related to the start of release (e.g. for removed options in java.1) are handled separately.
> 
> This initial generation also picks up the unpublished changes from: 
> 
> - JDK-8330807: Update Manpage for obsoletion of ScavengeBeforeFullGC
> - JDK-8284500: Typo in Supported Named Extensions - BasicContraints
> - JDK-8324342: Doclet should default `@since` for a nested class to that of its enclosing class
> 
> Thanks

David Holmes has updated the pull request incrementally with one additional commit since the last revision:

  Regenerated after merge

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19617/files
  - new: https://git.openjdk.org/jdk/pull/19617/files/8472c47d..e7563087

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19617&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19617&range=01-02

  Stats: 10 lines in 1 file changed: 0 ins; 10 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/19617.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19617/head:pull/19617

PR: https://git.openjdk.org/jdk/pull/19617

From dholmes at openjdk.org  Tue Jun 11 01:08:22 2024
From: dholmes at openjdk.org (David Holmes)
Date: Tue, 11 Jun 2024 01:08:22 GMT
Subject: RFR: 8330205: Initial troff manpage generation for JDK 24 [v3]
In-Reply-To: <uNkk5qQaPdNEfH5YxUXvQL8CFKT63f4P-PKcE3vKcMw=.6270cb01-eb8e-4f51-986c-5e93ec02cdcf@github.com>
References: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>
 <uNkk5qQaPdNEfH5YxUXvQL8CFKT63f4P-PKcE3vKcMw=.6270cb01-eb8e-4f51-986c-5e93ec02cdcf@github.com>
Message-ID: <7aiYPjUq_qkJuy1jRAFfZTpNoCwaw9scrgKJkkbp6UA=.dcdfae3e-05c5-45af-81b4-8a434b2774ba@github.com>

On Mon, 10 Jun 2024 17:27:18 GMT, Iris Clark <iris at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Regenerated after merge
>
> Marked as reviewed by iris (Reviewer).

Thanks for the review @irisclark .

I've merged in the latest updates that also brought in part of the missing changes. If anything goes wrong I have another PR in preparation that also updates java.1

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19617#issuecomment-2159577044

From dholmes at openjdk.org  Tue Jun 11 01:08:22 2024
From: dholmes at openjdk.org (David Holmes)
Date: Tue, 11 Jun 2024 01:08:22 GMT
Subject: Integrated: 8330205: Initial troff manpage generation for JDK 24
In-Reply-To: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>
References: <DxoS-iKUeC49_UYnIweL_1dLvlnbZlWLwt8PdjV9YFU=.39b7a1f3-b16c-439a-901d-cc8ca9d87882@github.com>
Message-ID: <rZfMnH59MoMxA4EjbTMjwJ6Wv7_aU6tAALkPzROcOSM=.d0ee9e97-4348-4441-9c5c-5ab4d834e2bc@github.com>

On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Sets the version to 24/24-ea and the copyright year to 2025.
> 
> Content changes related to the start of release (e.g. for removed options in java.1) are handled separately.
> 
> This initial generation also picks up the unpublished changes from: 
> 
> - ~~JDK-8330807: Update Manpage for obsoletion of ScavengeBeforeFullGC~~ (covered by merge)
> - JDK-8284500: Typo in Supported Named Extensions - BasicContraints
> - JDK-8324342: Doclet should default `@since` for a nested class to that of its enclosing class
> 
> Thanks

This pull request has now been integrated.

Changeset: 3a01b47a
Author:    David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3a01b47ac97714608356ce3faf797c37dc63e9af
Stats:     43 lines in 28 files changed: 2 ins; 3 del; 38 mod

8330205: Initial troff manpage generation for JDK 24

Reviewed-by: alanb, iris

-------------

PR: https://git.openjdk.org/jdk/pull/19617

From cstein at openjdk.org  Tue Jun 11 05:46:16 2024
From: cstein at openjdk.org (Christian Stein)
Date: Tue, 11 Jun 2024 05:46:16 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <4SzROPbfO7QDv-6_f_D3ntFvyEpXOvV9vsnb1LNU7Os=.b0fcfbbd-8c54-4443-b06d-722da305490d@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <4SzROPbfO7QDv-6_f_D3ntFvyEpXOvV9vsnb1LNU7Os=.b0fcfbbd-8c54-4443-b06d-722da305490d@github.com>
Message-ID: <rxc7-Mprc8iDuw1jhUolYiMoV7l6QxCSbsgnnZ35n1U=.02728f1d-1099-4ec7-a855-1eefe95f90f3@github.com>

On Mon, 10 Jun 2024 20:19:51 GMT, Phil Race <prr at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove double quotes
>
> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties line 66:
> 
>> 64: label.size=G&r??e:
>> 65: label.source=&Quelle:
>> 66: label.outputbins=A&usgabef?cher:
> 
> How confident are we in this ?
> google translate says that the old text referred to 'compartments' and the new one to 'areas' and I wonder why that is better ?
> 
> https://translate.google.com/?sl=auto&tl=en&text=Ausgabebereiche%0AAusgebefacher&op=translate

"Ausgabef?cher" is the best German translation here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634221518

From cstein at openjdk.org  Tue Jun 11 05:58:16 2024
From: cstein at openjdk.org (Christian Stein)
Date: Tue, 11 Jun 2024 05:58:16 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <iJZMTs0UUdFqw07uiMXQrkv3QBeyv70VQyyVZtFy5k4=.22762511-49c4-4ad6-a198-38d2be8ac4f6@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <RMYfMzeTjSTgC0E5UhO44fJsnjtjn7JaokyIswpzljg=.ae3644a2-376e-4249-8a6b-8b02306b5aba@github.com>
 <ivxoCg1QhjwpzbGR6T6rHreTkqv-NVFo7jZYwNL0LiM=.c10bee70-9ca8-4db5-89b1-ee7682729e3d@github.com>
 <iJZMTs0UUdFqw07uiMXQrkv3QBeyv70VQyyVZtFy5k4=.22762511-49c4-4ad6-a198-38d2be8ac4f6@github.com>
Message-ID: <Fb3AmUHDf5U2lnnok2LqxzKxUuXMQia6Ui9uU-eoqlY=.416d5ef4-d6ca-4aa3-a248-891d0e4b509e@github.com>

On Mon, 10 Jun 2024 22:48:13 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java line 325:
>> 
>>> 323:         {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"},
>>> 324:         {"unknown", "unbekannt"},
>>> 325:         {"Unmonitoring", "Monitoring von {0} aufheben"},
>> 
>> The English entry is:
>> 
>>         {"Unmonitoring", "Unmonitoring {0} "},
>> 
>> But the German entry now says "Monitoring". I'm  sure what the original "\u00DCberwachung" translates to, other than berwachung is monitoring. Now this resource is partly in English, and is the incorrect English.
>
> I don't know German, but when plugging `"Monitoring von {0} aufheben"` into google translate, I get `Unmonitoring` as well. Maybe `Monitoring` is a word that could also be used in German? No clue. The translation tool decided to make this change.
> 
> @sormuras do you have any input on this?

It's correct.

The "Un" of "Unmonitoring" is moved to the associated verb in German: "aufheben". which in this context translates to "cancel" or "revoke". This seems to be one of the few cases where there's no commonly used single word in German for "Unmonitoring".

> Now this resource is partly in English, and is the incorrect English.

That's how Tech-German often works - take a word from English and use it as-is, sometimes missing the original meaning. Such words or phrases are then referred to as: Denglisch.

In this case "?berwachung" was German, "Monitoring" is Denglisch. I'd revert that to `\u00DCberwachung` - but both are okay.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634236406

From cstein at openjdk.org  Tue Jun 11 06:03:20 2024
From: cstein at openjdk.org (Christian Stein)
Date: Tue, 11 Jun 2024 06:03:20 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <rxc7-Mprc8iDuw1jhUolYiMoV7l6QxCSbsgnnZ35n1U=.02728f1d-1099-4ec7-a855-1eefe95f90f3@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <4SzROPbfO7QDv-6_f_D3ntFvyEpXOvV9vsnb1LNU7Os=.b0fcfbbd-8c54-4443-b06d-722da305490d@github.com>
 <rxc7-Mprc8iDuw1jhUolYiMoV7l6QxCSbsgnnZ35n1U=.02728f1d-1099-4ec7-a855-1eefe95f90f3@github.com>
Message-ID: <fjDM8CLc7UlLywSpW23R_oXriwUiQu6lPv9zulRvfUs=.3d7a5920-67d3-4270-a366-79df33e241ae@github.com>

On Tue, 11 Jun 2024 05:43:12 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties line 66:
>> 
>>> 64: label.size=G&r??e:
>>> 65: label.source=&Quelle:
>>> 66: label.outputbins=A&usgabef?cher:
>> 
>> How confident are we in this ?
>> google translate says that the old text referred to 'compartments' and the new one to 'areas' and I wonder why that is better ?
>> 
>> https://translate.google.com/?sl=auto&tl=en&text=Ausgabebereiche%0AAusgebefacher&op=translate
>
> "Ausgabef?cher" is the best German translation here.

The reason for going with "Bereich (area)" instead of "Fach (compartment)" is that an area is more general compared to a compartment. At least in German: every "Fach" is a "Bereich", but every "Bereich" is NOT a "Fach".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634240847

From cstein at openjdk.org  Tue Jun 11 06:07:16 2024
From: cstein at openjdk.org (Christian Stein)
Date: Tue, 11 Jun 2024 06:07:16 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <2-SMv3j3Eqrv7LVV6CbkZVEb3KFcahQR1_8AiJErDAQ=.07538bd6-9b25-45ed-b47f-8e9102ea8af9@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <SjpwOVwkqCFBlC_Vj1rv4JwgHdgqnpiz8xrDTE98eOc=.c90d5753-0206-48e9-bfb4-8e6bc67c616a@github.com>
 <2-SMv3j3Eqrv7LVV6CbkZVEb3KFcahQR1_8AiJErDAQ=.07538bd6-9b25-45ed-b47f-8e9102ea8af9@github.com>
Message-ID: <CouuebhtcqMA6bHarrhzi4OkzoYr9fc13nWk21wQjZQ=.00f0f569-3215-4f99-8f00-59d1e7314c44@github.com>

On Mon, 10 Jun 2024 20:34:10 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties line 409:
>> 
>>> 407: compiler.err.unconditional.pattern.and.default=Switch umfasst sowohl ein nicht bedingtes Muster als auch ein Standardlabel
>>> 408: 
>>> 409: compiler.err.unconditional.pattern.and.both.boolean.values=Switch umfasst sowohl boolesche Werte als auch ein nicht bedingtes Muster
>> 
>> Here and elsewhere in this file and other translations, I'm surprised `switch` is not being translated, and is being capitalized. In the English form, it is not being used as a keyword, although could maybe be seen as a short form of `switch' statement, in which case `switch` should be treated as a keyword and not translated or capitalized.
>
> Good catch. Seems to be across all files and I'm assuming it's for the reason you suggested. I'll bring this up to the go team. I have no way to fix this since I can't rely on google translate. This can be caught in a future update if the go team can successfully differentiate the difference between the word `switch` and a `switch keyword`.

Yes. "Switch ..." is the short form for "Das Switch-Statement ..." or "Das `switch` Statement ..." and all other longer forms that match the context.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634244985

From cstein at openjdk.org  Tue Jun 11 06:13:24 2024
From: cstein at openjdk.org (Christian Stein)
Date: Tue, 11 Jun 2024 06:13:24 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <6x05vtOnVTgxlyzPvesvYR9v3NUNHNkinbbaXJtXzxU=.492b5e27-02dd-4457-a725-705a3d6be7f9@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <6x05vtOnVTgxlyzPvesvYR9v3NUNHNkinbbaXJtXzxU=.492b5e27-02dd-4457-a725-705a3d6be7f9@github.com>
Message-ID: <oF6N81khTgiBZPXZgBwJUPmJYlcJZF_DD6eIHaTW-Ng=.25effa3a-097e-41a0-bb03-d520fe0013d2@github.com>

On Sun, 9 Jun 2024 19:35:04 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove double quotes
>
> src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties line 285:
> 
>> 283: VIRTUAL_MACHINE=Virtuelle Maschine
>> 284: VM_ARGUMENTS=VM-Argumente
>> 285: VMINTERNAL_FRAME_ACCESSIBLE_DESCRIPTION=Innerer Frame f?r das Monitoring einer Java Virtual Machine
> 
> This one-off change is consistent with the change in _src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java_.

Consistently changed to be "[Denglisch](https://en.wikipedia.org/wiki/Denglisch)" instead of German.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1634249847

From prappo at openjdk.org  Tue Jun 11 11:06:17 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Tue, 11 Jun 2024 11:06:17 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <RMYfMzeTjSTgC0E5UhO44fJsnjtjn7JaokyIswpzljg=.ae3644a2-376e-4249-8a6b-8b02306b5aba@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <RMYfMzeTjSTgC0E5UhO44fJsnjtjn7JaokyIswpzljg=.ae3644a2-376e-4249-8a6b-8b02306b5aba@github.com>
Message-ID: <zuNDuUKk1vjisadTmYy9ejFqSmDKWLvKoFY-umQC7IU=.20b7ac6e-a91a-4c13-8c2d-17d2d23002be@github.com>

On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>> 
>> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
>> 
>> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove double quotes

I was asked to have a look at this PR elsewhere. I cannot verify correctness of translation, but I can review this PR generally for `jdk.javadoc`.

>From what I can see, the changes are only to the property files, which is expected from the PR title. The keys from English files 1-1 match the keys from non-English files: there are no missing or extra keys.

>From that point of view, the changes to `jdk.javadoc` look good.

-------------

Marked as reviewed by prappo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2110098592

From nbenalla at openjdk.org  Tue Jun 11 11:43:07 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Tue, 11 Jun 2024 11:43:07 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed
Message-ID: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>

Can I please get a review for this change, that aims to add support for Global HTML tags.
Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html) to the generated docs.
Thanks in advance.

-------------

Commit messages:
 - Allow global variables

Changes: https://git.openjdk.org/jdk/pull/19652/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19652&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8322708
  Stats: 613 lines in 5 files changed: 610 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/19652.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19652/head:pull/19652

PR: https://git.openjdk.org/jdk/pull/19652

From liach at openjdk.org  Tue Jun 11 11:55:13 2024
From: liach at openjdk.org (Chen Liang)
Date: Tue, 11 Jun 2024 11:55:13 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed
In-Reply-To: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
Message-ID: <74b_ftxSsh1-C1tLKzuZG-XpkMNFINSU69uRRcTqYME=.f2276cc2-79e0-4931-b5e9-36eba7a1568f@github.com>

On Tue, 11 Jun 2024 11:37:27 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I please get a review for this change, that aims to add support for Global HTML tags.
> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html) to the generated docs.
> Thanks in advance.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line 694:

> 692:             // without checking the validity or applicability of the name
> 693:             // custom "data-*" attributes are also accepted
> 694:             var attrName=name.toString();

Suggestion:

            var attrName = name.toString();

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 513:

> 511:         VSPACE,
> 512:         WIDTH,
> 513:         ACCESSKEY,

Maybe add a comment `// Global attributes` above this line to indicate the start of global attributes, so future attributes are added to the correct section?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634727172
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634727032

From prappo at openjdk.org  Tue Jun 11 12:43:14 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Tue, 11 Jun 2024 12:43:14 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed
In-Reply-To: <74b_ftxSsh1-C1tLKzuZG-XpkMNFINSU69uRRcTqYME=.f2276cc2-79e0-4931-b5e9-36eba7a1568f@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <74b_ftxSsh1-C1tLKzuZG-XpkMNFINSU69uRRcTqYME=.f2276cc2-79e0-4931-b5e9-36eba7a1568f@github.com>
Message-ID: <FM63ProninPmneneJPugqp7AN6hDgHAL-2MivTuOtw0=.66e676bf-7172-444f-9a9f-4a4d1d7f21cc@github.com>

On Tue, 11 Jun 2024 11:51:05 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 513:
> 
>> 511:         VSPACE,
>> 512:         WIDTH,
>> 513:         ACCESSKEY,
> 
> Maybe add a comment `// Global attributes` above this line to indicate the start of global attributes, so future attributes are added to the correct section?

Either what Chen has suggested or re-sort the complete list alphabetically as it was prior to this change, well, almost.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634810052

From nbenalla at openjdk.org  Tue Jun 11 12:43:14 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Tue, 11 Jun 2024 12:43:14 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed
In-Reply-To: <FM63ProninPmneneJPugqp7AN6hDgHAL-2MivTuOtw0=.66e676bf-7172-444f-9a9f-4a4d1d7f21cc@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <74b_ftxSsh1-C1tLKzuZG-XpkMNFINSU69uRRcTqYME=.f2276cc2-79e0-4931-b5e9-36eba7a1568f@github.com>
 <FM63ProninPmneneJPugqp7AN6hDgHAL-2MivTuOtw0=.66e676bf-7172-444f-9a9f-4a4d1d7f21cc@github.com>
Message-ID: <WA6BhWjUbrPsIoazxUCsi6WVAmJgqQPp7OvpiMOIBv4=.8fa54cbe-0efc-4394-b1a7-50e6d410f737@github.com>

On Tue, 11 Jun 2024 12:37:46 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Either what Chen has suggested or re-sort the complete list alphabetically as it was prior to this change.

I will go with Chen's suggestions, will fix in a bit.

I might move STYLE down as it's also a global tag

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634813558

From prappo at openjdk.org  Tue Jun 11 13:08:14 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Tue, 11 Jun 2024 13:08:14 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed
In-Reply-To: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
Message-ID: <troxEwciEfFvU8xOVeUQcBkmQUyApATfXxI9twTGDfI=.f060316b-8bab-4566-95e8-f8a68bbc0bf8@github.com>

On Tue, 11 Jun 2024 11:37:27 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I please get a review for this change, that aims to add support for Global HTML tags.
> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html) to the generated docs.
> Thanks in advance.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 556:

> 554:     }
> 555: 
> 556:     private final EnumSet<Attr> GLOBAL_ATTRS = EnumSet.of(

I get it, you cannot make it static because it's used in an enum ctor. But attaching it to every single enum constant seems wasteful.

test/langtools/jdk/javadoc/doclet/TestGlobalHtml/TestGlobalHtml.java line 41:

> 39:         var tester = new TestGlobalHtml();
> 40:         tester.runTests();
> 41:         tester.printSummary();

Why is this summary needed? Usually, we don't print it.

test/langtools/jdk/javadoc/doclet/TestGlobalHtml/pkg1/C1.java line 36:

> 34:  *
> 35:  * <p accesskey="C" autocapitalize="sentences" dir="ltr" lang="en" data-purpose="documentation">
> 36:  * This class is used to demonstrate the use of various HTML global attributes in Javadoc comments.

JavaDoc

test/langtools/jdk/javadoc/doclet/TestGlobalHtml/pkg1/C1.java line 299:

> 297:      */
> 298:     public void setUndecorated(boolean undecorated) {
> 299:         /* Make sure we don't run in the middle of peer creation.*/

I would delete this method-internal comment. While being immaterial, it draws too much attention.

test/langtools/jdk/javadoc/doclet/TestGlobalHtml/pkg1/C2.java line 8:

> 6:  * under the terms of the GNU General Public License version 2 only, as
> 7:  * published by the Free Software Foundation.  Oracle designates this
> 8:  * particular file as subject to the "Classpath" exception as provided

No "classpath" exception is required for a test.

test/langtools/jdk/javadoc/doclet/TestGlobalHtml/pkg1/C2.java line 104:

> 102:      * </p>
> 103:      *
> 104:      * <ul>

Since you use `ol`, `ul`, and `li`elements, you could add global attributes to them too. Otherwise, you only have such attributes in `p` elements.

test/langtools/jdk/javadoc/doclet/TestGlobalHtml/pkg1/C2.java line 115:

> 113:      */
> 114:     public boolean performAction(String action) {
> 115:         // Placeholder implementation

Delete this and the similar comments below.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634822550
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634847516
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634837845
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634841367
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634845398
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634851759
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634852871

From nbenalla at openjdk.org  Tue Jun 11 13:24:48 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Tue, 11 Jun 2024 13:24:48 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v2]
In-Reply-To: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
Message-ID: <ZenQV6Xm6sI_V-oB8LaANNo2nVmpYlRYiwk7C0DWRHU=.eef8e8bf-9028-4c52-9e41-76c5dda4131e@github.com>

> Can I please get a review for this change, that aims to add support for Global HTML tags.
> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html) to the generated docs.
> Thanks in advance.

Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:

  Remove classpath exception

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19652/files
  - new: https://git.openjdk.org/jdk/pull/19652/files/bbd9e017..a1292496

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19652&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19652&range=00-01

  Stats: 6 lines in 1 file changed: 0 ins; 5 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19652.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19652/head:pull/19652

PR: https://git.openjdk.org/jdk/pull/19652

From prappo at openjdk.org  Tue Jun 11 13:30:15 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Tue, 11 Jun 2024 13:30:15 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v2]
In-Reply-To: <ZenQV6Xm6sI_V-oB8LaANNo2nVmpYlRYiwk7C0DWRHU=.eef8e8bf-9028-4c52-9e41-76c5dda4131e@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <ZenQV6Xm6sI_V-oB8LaANNo2nVmpYlRYiwk7C0DWRHU=.eef8e8bf-9028-4c52-9e41-76c5dda4131e@github.com>
Message-ID: <f9NaWnsPXLCMKr59nNTwHkt0wdkIB4dEX8CdLhUEhDc=.a1b6a55b-280f-4390-8280-ecdd9933f9fe@github.com>

On Tue, 11 Jun 2024 13:24:48 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove classpath exception

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line 695:

> 693:             // custom "data-*" attributes are also accepted
> 694:             var attrName=name.toString();
> 695:             if (!attrName.startsWith("on") && !attrName.matches("data-[a-z]+(-[a-z]+)*")){

I understand that `startsWith("on")` precedes this PR. However, it's more permissive than it should be: in reality, there are only 70 global attributes that start with "on". On the other hand, `attrName.matches("data-[a-z]+(-[a-z]+)*")` is less permissive. For example, if I read the XML spec correctly, such an attribute can contain `_` or start with `data-.`.

But maybe those checks are good enough?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634890608

From liach at openjdk.org  Tue Jun 11 13:39:13 2024
From: liach at openjdk.org (Chen Liang)
Date: Tue, 11 Jun 2024 13:39:13 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v2]
In-Reply-To: <troxEwciEfFvU8xOVeUQcBkmQUyApATfXxI9twTGDfI=.f060316b-8bab-4566-95e8-f8a68bbc0bf8@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <troxEwciEfFvU8xOVeUQcBkmQUyApATfXxI9twTGDfI=.f060316b-8bab-4566-95e8-f8a68bbc0bf8@github.com>
Message-ID: <nc8iP7srsdnlaw_p78EVZz3XcTGTCAp-FrBsZZlVMzE=.74feff0a-2283-4b69-b8fb-d57c43322a86@github.com>

On Tue, 11 Jun 2024 12:45:10 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove classpath exception
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 556:
> 
>> 554:     }
>> 555: 
>> 556:     private final EnumSet<Attr> GLOBAL_ATTRS = EnumSet.of(
> 
> I get it, you cannot make it static because it's used in an enum ctor. But attaching it to every single enum constant seems wasteful.

If we are ordering the entries, we can use comparable to check that an attr is greater than the start of the global attr, something like

private static boolean isGlobalAttr(Attr value) {
    return value.compareTo(Attr.ACCESSKEY) >= 0;
}

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634905873

From prappo at openjdk.org  Tue Jun 11 13:44:12 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Tue, 11 Jun 2024 13:44:12 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v2]
In-Reply-To: <nc8iP7srsdnlaw_p78EVZz3XcTGTCAp-FrBsZZlVMzE=.74feff0a-2283-4b69-b8fb-d57c43322a86@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <troxEwciEfFvU8xOVeUQcBkmQUyApATfXxI9twTGDfI=.f060316b-8bab-4566-95e8-f8a68bbc0bf8@github.com>
 <nc8iP7srsdnlaw_p78EVZz3XcTGTCAp-FrBsZZlVMzE=.74feff0a-2283-4b69-b8fb-d57c43322a86@github.com>
Message-ID: <RQ1MMLAOj2SFojwi7vJIQjBZq36t1iyUuRob6VLkxqE=.1e010391-ba53-4e42-927a-491a038c4fe4@github.com>

On Tue, 11 Jun 2024 13:35:31 GMT, Chen Liang <liach at openjdk.org> wrote:

>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 556:
>> 
>>> 554:     }
>>> 555: 
>>> 556:     private final EnumSet<Attr> GLOBAL_ATTRS = EnumSet.of(
>> 
>> I get it, you cannot make it static because it's used in an enum ctor. But attaching it to every single enum constant seems wasteful.
>
> If we are ordering the entries, we can use comparable to check that an attr is greater than the start of the global attr, something like
> 
> private static boolean isGlobalAttr(Attr value) {
>     return value.compareTo(Attr.ACCESSKEY) >= 0;
> }

> If we are ordering the entries, we can use comparable to check that an attr is greater than the start of the global attr, something like
> 
> ```java
> private static boolean isGlobalAttr(Attr value) {
>     return value.compareTo(Attr.ACCESSKEY) >= 0;
> }
> ```

That would also work, yes. I still avoid relying on the order of enum constants; but it's me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634916196

From naoto at openjdk.org  Tue Jun 11 17:18:17 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 11 Jun 2024 17:18:17 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <wk1BTXn55Ouaqbe_dkzkgpOMsrlIkQVDk5he2qLxgF8=.0ee9ea01-13f5-4c0a-91e2-24cd031eb91e@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <6x05vtOnVTgxlyzPvesvYR9v3NUNHNkinbbaXJtXzxU=.492b5e27-02dd-4457-a725-705a3d6be7f9@github.com>
 <wk1BTXn55Ouaqbe_dkzkgpOMsrlIkQVDk5he2qLxgF8=.0ee9ea01-13f5-4c0a-91e2-24cd031eb91e@github.com>
Message-ID: <IkCDImPZqMUO8lTSYmq1eVu9VujFF-F5D4-gt7Hbt5A=.173876cd-1a2f-4713-a277-5a1cd5ee9703@github.com>

On Mon, 10 Jun 2024 19:45:14 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties line 278:
>> 
>>> 276:         UndeclaredElementInContentSpec = Contentmodell des Elements "{0}" verweist auf das nicht deklarierte Element "{1}".
>>> 277:         UniqueNotationName = Deklaration f?r die Notation "{0}" ist nicht eindeutig. Ein jeweiliger Name darf nicht in mehreren Notationsdeklarationen deklariert werden.
>>> 278:         ENTITYFailedInitializeGrammar =  ENTITYDatatype-Validator: Nicht erfolgreich. Initialisierungsmethode muss mit einer g?ltigen Grammatikreferenz aufgerufen werden. \t
>> 
>> It looks like the _zh_CN_ file should also have the `\t` removed, but such changes are done by the translation tool. I think in this case, we should manually remove it, and then file a bug against the translation tool.
>
> Yeah, I believe you're right. Noted as something else to file against the translation tool.

Just out of curiosity, do we know why `\t` was attached in the first place? I don't think it is with the original English properties.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635231459

From jlu at openjdk.org  Tue Jun 11 17:26:18 2024
From: jlu at openjdk.org (Justin Lu)
Date: Tue, 11 Jun 2024 17:26:18 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <IkCDImPZqMUO8lTSYmq1eVu9VujFF-F5D4-gt7Hbt5A=.173876cd-1a2f-4713-a277-5a1cd5ee9703@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <6x05vtOnVTgxlyzPvesvYR9v3NUNHNkinbbaXJtXzxU=.492b5e27-02dd-4457-a725-705a3d6be7f9@github.com>
 <wk1BTXn55Ouaqbe_dkzkgpOMsrlIkQVDk5he2qLxgF8=.0ee9ea01-13f5-4c0a-91e2-24cd031eb91e@github.com>
 <IkCDImPZqMUO8lTSYmq1eVu9VujFF-F5D4-gt7Hbt5A=.173876cd-1a2f-4713-a277-5a1cd5ee9703@github.com>
Message-ID: <dwTM7lAxBa_Z6Diij907FtLkAiNb8Nbc0B2ZLYYIWVY=.df8c37f4-2e21-496c-bba9-29bc71d24689@github.com>

On Tue, 11 Jun 2024 17:15:49 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Yeah, I believe you're right. Noted as something else to file against the translation tool.
>
> Just out of curiosity, do we know why `\t` was attached in the first place? I don't think it is with the original English properties.

I can see that in 2012, the original did not have `\t` while the translated files did. (Did not search before then).
Seems like this discrepancy originates from awhile ago.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635242656

From cjplummer at openjdk.org  Tue Jun 11 18:04:42 2024
From: cjplummer at openjdk.org (Chris Plummer)
Date: Tue, 11 Jun 2024 18:04:42 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <RMYfMzeTjSTgC0E5UhO44fJsnjtjn7JaokyIswpzljg=.ae3644a2-376e-4249-8a6b-8b02306b5aba@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <RMYfMzeTjSTgC0E5UhO44fJsnjtjn7JaokyIswpzljg=.ae3644a2-376e-4249-8a6b-8b02306b5aba@github.com>
Message-ID: <ingMGDOjflPwzkCCYc6MKKiBsXikH9L11Bt_l18MALc=.5726d2a9-d503-45de-a657-becc134c7596@github.com>

On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>> 
>> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
>> 
>> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove double quotes

jdk.jconsole and jdk.jdi changes look fine.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2111108012

From dnguyen at openjdk.org  Tue Jun 11 19:21:17 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 11 Jun 2024 19:21:17 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
In-Reply-To: <fjDM8CLc7UlLywSpW23R_oXriwUiQu6lPv9zulRvfUs=.3d7a5920-67d3-4270-a366-79df33e241ae@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <4SzROPbfO7QDv-6_f_D3ntFvyEpXOvV9vsnb1LNU7Os=.b0fcfbbd-8c54-4443-b06d-722da305490d@github.com>
 <rxc7-Mprc8iDuw1jhUolYiMoV7l6QxCSbsgnnZ35n1U=.02728f1d-1099-4ec7-a855-1eefe95f90f3@github.com>
 <fjDM8CLc7UlLywSpW23R_oXriwUiQu6lPv9zulRvfUs=.3d7a5920-67d3-4270-a366-79df33e241ae@github.com>
Message-ID: <jbO8ccEzKKoAo9tNxRdfAaMeuN2A_18Qk_c19bJvg0o=.3b33dc8a-d611-4fdb-96e3-d513913d71aa@github.com>

On Tue, 11 Jun 2024 06:00:19 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> "Ausgabef?cher" is the best German translation here.
>
> The reason for going with "Bereich (area)" instead of "Fach (compartment)" is that an area is more general compared to a compartment. At least in German: every "Fach" is a "Bereich", but every "Bereich" is NOT a "Fach".

Thanks for the input @sormuras!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635369067

From dnguyen at openjdk.org  Tue Jun 11 19:28:27 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Tue, 11 Jun 2024 19:28:27 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
In-Reply-To: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
Message-ID: <gKEdrkbDjRi0nDWUOKbtoIqqkn704gRuecB9iuFI3qA=.03521c6e-baaf-48aa-a052-c5b9a8cd75d7@github.com>

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
> 
> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
> 
> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Revert updated translation

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19609/files
  - new: https://git.openjdk.org/jdk/pull/19609/files/32d69e89..e9e0bcea

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19609.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609

PR: https://git.openjdk.org/jdk/pull/19609

From asemenyuk at openjdk.org  Tue Jun 11 20:01:20 2024
From: asemenyuk at openjdk.org (Alexey Semenyuk)
Date: Tue, 11 Jun 2024 20:01:20 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
In-Reply-To: <gKEdrkbDjRi0nDWUOKbtoIqqkn704gRuecB9iuFI3qA=.03521c6e-baaf-48aa-a052-c5b9a8cd75d7@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <gKEdrkbDjRi0nDWUOKbtoIqqkn704gRuecB9iuFI3qA=.03521c6e-baaf-48aa-a052-c5b9a8cd75d7@github.com>
Message-ID: <b4_ag7ODt2hsNNfwRhoSKNQzldRPb-O_DagZiuFMIek=.b56751e1-5385-4a5e-a081-b1818cd30f2a@github.com>

On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>> 
>> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
>> 
>> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert updated translation

Marked as reviewed by asemenyuk (Reviewer).

jpackage changes look good

-------------

PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2111344874
PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2161509207

From achung at openjdk.org  Tue Jun 11 22:54:19 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 11 Jun 2024 22:54:19 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
In-Reply-To: <gKEdrkbDjRi0nDWUOKbtoIqqkn704gRuecB9iuFI3qA=.03521c6e-baaf-48aa-a052-c5b9a8cd75d7@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <gKEdrkbDjRi0nDWUOKbtoIqqkn704gRuecB9iuFI3qA=.03521c6e-baaf-48aa-a052-c5b9a8cd75d7@github.com>
Message-ID: <tWMKY1f1KglIZZuTUdD9ZpYS8hmiiIeTv9nytEhFZWE=.201e7860-bc28-4ac4-8812-a8866d1801c1@github.com>

On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>> 
>> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
>> 
>> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert updated translation

LGTM

-------------

Marked as reviewed by achung (Committer).

PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2111576337

From achung at openjdk.org  Tue Jun 11 22:54:21 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 11 Jun 2024 22:54:21 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
In-Reply-To: <0xmUIRy1V_ts7yyfm1kMaQfbzU5YoJSWAzD3QDNLY7U=.8e0e163e-d0c6-4f22-a92d-79de8c58e8f6@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <4SzROPbfO7QDv-6_f_D3ntFvyEpXOvV9vsnb1LNU7Os=.b0fcfbbd-8c54-4443-b06d-722da305490d@github.com>
 <0xmUIRy1V_ts7yyfm1kMaQfbzU5YoJSWAzD3QDNLY7U=.8e0e163e-d0c6-4f22-a92d-79de8c58e8f6@github.com>
Message-ID: <P-vtaJDvvh15Fb-zFtwRbpDSNxovZZXzDiYfFO9Fa0g=.6570cfd3-6cc4-4100-bf53-0f7bd09820fb@github.com>

On Mon, 10 Jun 2024 20:37:41 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties line 32:
>> 
>>> 30: border.jobattributes=????
>>> 31: border.media=??
>>> 32: border.output=??
>> 
>> What triggered this ? Just someone noticing it and deciding there's a better translation ?
>> What does it say ?
>
> In the past, it was brought up in review that some of the words were translated to localized words that didn't exactly mean what the original English word meant. I believe Weijun Wang caught some of these in Chinese files in the past.  I'm assuming these are cases where the go team is improving the translation, but I also can't exactly tell. We do suggest changes to the go team, so maybe this is evidence of them improving their tool.

It was changed from "paper output" to just "output". Since the original English doesn't specify anything about paper, I guess the new translation is more general and fitting in this case.

The original inclusion of the border.output field was actually part of the output bin update on [JDK-8314070](https://bugs.openjdk.org/browse/JDK-8314070) so it was actually not initially translated by the translation team.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1635559474

From achung at openjdk.org  Tue Jun 11 23:13:17 2024
From: achung at openjdk.org (Alisen Chung)
Date: Tue, 11 Jun 2024 23:13:17 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
In-Reply-To: <RdC2DWY9T4c_CtoDC0VQQO-glDmN41Gyjl3ZevJgU5c=.525f206b-ef90-4856-bd4e-e6e0b26822e6@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <RdC2DWY9T4c_CtoDC0VQQO-glDmN41Gyjl3ZevJgU5c=.525f206b-ef90-4856-bd4e-e6e0b26822e6@github.com>
Message-ID: <sc34YUtz7xCMiUCtBjFH8Gx9qMQ_6wN20ORFRkBMXZA=.cbdb0a2e-c35a-4a7a-b640-9d1a5dcb62b9@github.com>

On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert updated translation
>
> Did not look at each for translation accuracy (did some for Japanese), but looks good overall.
> It's great to see diffs in native languages, rather than those cryptic `\uXXXX` notation!

An interesting note after looking at Phil's comment on the serviceui.properties change is that there is no Japanese update for that file. The translations on [here](https://github.com/openjdk/jdk/commit/c7d2a5c1c4e86955100f4c40170dc25222abd07f#diff-38c26a463e174224c6b9fc5007f3058482e533dc0f60f3275e21f9f2fc9acf8e) from the output bins update look good to me but maybe @naotoj should double check in case?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2161748245

From naoto at openjdk.org  Tue Jun 11 23:29:17 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Tue, 11 Jun 2024 23:29:17 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
In-Reply-To: <RdC2DWY9T4c_CtoDC0VQQO-glDmN41Gyjl3ZevJgU5c=.525f206b-ef90-4856-bd4e-e6e0b26822e6@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <RdC2DWY9T4c_CtoDC0VQQO-glDmN41Gyjl3ZevJgU5c=.525f206b-ef90-4856-bd4e-e6e0b26822e6@github.com>
Message-ID: <8pnAwewRWdiqnLGBNNUGPwD7bjUsuVhUDtaPC8IJ7Bc=.c7ceb4be-dc7a-48ff-9ee2-7aa3d94b2ead@github.com>

On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert updated translation
>
> Did not look at each for translation accuracy (did some for Japanese), but looks good overall.
> It's great to see diffs in native languages, rather than those cryptic `\uXXXX` notation!

> An interesting note after looking at Phil's comment on the serviceui.properties change is that there is no Japanese update for that file. The translations on [here](https://github.com/openjdk/jdk/commit/c7d2a5c1c4e86955100f4c40170dc25222abd07f#diff-38c26a463e174224c6b9fc5007f3058482e533dc0f60f3275e21f9f2fc9acf8e) from the output bins update look good to me but maybe @naotoj should double check in case?

I can confirm that English "Out&put trays:" to "?????(&P):" is OK

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19609#issuecomment-2161765683

From prr at openjdk.org  Wed Jun 12 19:46:20 2024
From: prr at openjdk.org (Phil Race)
Date: Wed, 12 Jun 2024 19:46:20 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
In-Reply-To: <gKEdrkbDjRi0nDWUOKbtoIqqkn704gRuecB9iuFI3qA=.03521c6e-baaf-48aa-a052-c5b9a8cd75d7@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <gKEdrkbDjRi0nDWUOKbtoIqqkn704gRuecB9iuFI3qA=.03521c6e-baaf-48aa-a052-c5b9a8cd75d7@github.com>
Message-ID: <vUUnGbZkSBcAhexcNbtiUu-9SzGrvcln2ejWHPLszkg=.2dcd07e7-cb81-4843-84bc-bbd2b84f4a72@github.com>

On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>> 
>> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
>> 
>> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert updated translation

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2114049394

From jlu at openjdk.org  Wed Jun 12 20:15:18 2024
From: jlu at openjdk.org (Justin Lu)
Date: Wed, 12 Jun 2024 20:15:18 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]
In-Reply-To: <gKEdrkbDjRi0nDWUOKbtoIqqkn704gRuecB9iuFI3qA=.03521c6e-baaf-48aa-a052-c5b9a8cd75d7@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <gKEdrkbDjRi0nDWUOKbtoIqqkn704gRuecB9iuFI3qA=.03521c6e-baaf-48aa-a052-c5b9a8cd75d7@github.com>
Message-ID: <xUXJHd1OOUlkCtLwTS_wmgx0FlcrHSE7cbwrmIsCVD4=.b96c0b4a-0028-4d33-8b44-f07b1f1ff039@github.com>

On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>> 
>> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
>> 
>> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert updated translation

Marked as reviewed by jlu (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2114131181

From dnguyen at openjdk.org  Wed Jun 12 21:11:52 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 12 Jun 2024 21:11:52 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]
In-Reply-To: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
Message-ID: <DAEnGganAWoVga2j8IKfI2HiHDrKGn8lHExbWpMzNQU=.e3eea870-10b9-4eca-9cb4-85ee95ed70b3@github.com>

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
> 
> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
> 
> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/

Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:

  Undo translation for some words

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19609/files
  - new: https://git.openjdk.org/jdk/pull/19609/files/e9e0bcea..8c22d1db

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19609&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19609.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19609/head:pull/19609

PR: https://git.openjdk.org/jdk/pull/19609

From dnguyen at openjdk.org  Wed Jun 12 21:11:52 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Wed, 12 Jun 2024 21:11:52 GMT
Subject: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]
In-Reply-To: <Ss1KZ4NwolVYPiXv46jXJ05_pDMCkOY4GHYlq5stnCc=.135e6f50-206b-4f75-acf4-4574eaf84951@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
 <6x05vtOnVTgxlyzPvesvYR9v3NUNHNkinbbaXJtXzxU=.492b5e27-02dd-4457-a725-705a3d6be7f9@github.com>
 <wk1BTXn55Ouaqbe_dkzkgpOMsrlIkQVDk5he2qLxgF8=.0ee9ea01-13f5-4c0a-91e2-24cd031eb91e@github.com>
 <06n4CAAdscvysfgXBWG-uWwIUSIt4D_o1wppGATS1II=.7c9a46de-2b24-482b-8f67-77741a7ae938@github.com>
 <8fptu16lcceBUEid012EvN4KHhrf3gjzPRgdOANg_Kk=.4d3d1e78-17f9-4248-89ca-99ca03370e71@github.com>
 <Ss1KZ4NwolVYPiXv46jXJ05_pDMCkOY4GHYlq5stnCc=.135e6f50-206b-4f75-acf4-4574eaf84951@github.com>
Message-ID: <tYq_jOkBddmXa1PV50hifwtXBOKDhobAVEX4PKO7U40=.518cf1f2-8c4f-4789-b51a-fa1bb4b62ccd@github.com>

On Mon, 10 Jun 2024 23:11:04 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> @jonathan-gibbons I just realized that this change to the German file matches the file with the Japanese and Chinese localized files. By that I mean the "backwards" translations are also present for the Japanese and Chinese files.
>> 
>> However, the previous versions of the Japanese and Chinese files don't have these bits translated. So in summary, I can revert the German file back to German but the Japanese and Chinese files will still be English for these parts because I wouldn't know what to revert them to in their local language.
>> 
>> As a result, I actually think it might be better to change this German file as shown in the current version of the PR just to remain consistent with the other localized versions of this file. We can still bring this up to the go team as an issue, but I think this is the best solution now for this drop at least.
>
> No one else except people reading this PR will spot inconsistencies between translations in different languages. So inconsistencies across languages will not be obvious to end users.
> 
> But anyone (end-user) using the tool in any one of these languages is likely to spot inconsistencies in the translations for that one language.

@jonathan-gibbons I have gone back and manually undid some of the English translations back to its former German word. Most occurrences of this are `<flag>` to `<Kennzeichen>`, but some others were changed back as well. Could you re-review this?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19609#discussion_r1637092298

From duke at openjdk.org  Thu Jun 13 09:59:55 2024
From: duke at openjdk.org (psoujany)
Date: Thu, 13 Jun 2024 09:59:55 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v30]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <DyjulQbBy4qNsEGaMBRDzMUUcrd-ps83rfjOJULXpls=.3e92b1da-43e5-4baf-9352-04ff18f4b9a6@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 33 additional commits since the last revision:

 - Merge branch 'openjdk:master' into remove-overflow
 - Add tabindex to tabbable elements
 - Add tabindex to tabbable elements
 - Make only elements which are tabbable
 - Make only elements which are tabbable
 - Merge branch 'openjdk:master' into remove-overflow
 - Add tabindex only to elemetns which are not tabbable
 - Add tab order to plain text
 - Add tab order to plain text
 - Add tabindex to plain text
 - ... and 23 more: https://git.openjdk.org/jdk/compare/1dcf0269...a2055fe2

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/265ee868..a2055fe2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=29
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=28-29

  Stats: 38971 lines in 940 files changed: 23649 ins; 11991 del; 3331 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Thu Jun 13 11:03:38 2024
From: duke at openjdk.org (psoujany)
Date: Thu, 13 Jun 2024 11:03:38 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v31]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <knYlJW0GrQUzLL9Dy4jjRisXWn-GODMJ9slXz8GvgcY=.90a41e7b-df71-4e58-8bcd-6022cdad91ae@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with two additional commits since the last revision:

 - Merge branch 'remove-overflow' of github.com:psoujany/jdk into remove-overflow
 - Add grid role to tables

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/a2055fe2..0448657a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=30
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=29-30

  Stats: 103 lines in 7 files changed: 5 ins; 0 del; 98 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Thu Jun 13 11:07:44 2024
From: duke at openjdk.org (psoujany)
Date: Thu, 13 Jun 2024 11:07:44 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v32]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <IWqSqSo3Aw8b3Lg6Y-ZfwD0kyjLAlRFhNf2JtAhOq2s=.1c6b65e5-931a-40d1-8e07-5e5c48d8f77f@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Add grid role to tables

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/0448657a..8bf881e7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=31
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=30-31

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Thu Jun 13 15:19:52 2024
From: duke at openjdk.org (psoujany)
Date: Thu, 13 Jun 2024 15:19:52 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v33]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <GnQ_LeLLiAXBWD1igpBDZ7oJWwBdiBY6zqS3qPz9OWs=.9f0c880b-f86c-4e5c-a419-60a0f06980ec@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Add grid role to tables

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/8bf881e7..e84e18d9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=32
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=31-32

  Stats: 481 lines in 34 files changed: 0 ins; 0 del; 481 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From jjg at openjdk.org  Thu Jun 13 18:34:16 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 13 Jun 2024 18:34:16 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v23]
In-Reply-To: <dppfhC4OAe66l8k_lHclswVZ2e5BrvcHqiGJDdgcn-M=.b01050ef-7473-4f78-9cfd-b252edefde7a@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
 <4qdAGPJ4wHfvhkkALNrnsEHdSAu2guRqMxfDYnsz8b4=.c9bbf75b-608e-40ae-b261-d5539eb12708@github.com>
 <B639d3msMiDgs3FWVRzZV20i_i65v3nzZADKbQU-bFA=.959d9223-482d-4f84-8e85-091fd113e0a7@github.com>
 <dppfhC4OAe66l8k_lHclswVZ2e5BrvcHqiGJDdgcn-M=.b01050ef-7473-4f78-9cfd-b252edefde7a@github.com>
Message-ID: <hPDEE880ba51xKpuEGWlMMorK-MzIjMmrDXxndN1A8Y=.087b0063-a7f5-4c7d-9e7e-ec0b6ffc14d4@github.com>

On Mon, 3 Jun 2024 06:37:22 GMT, psoujany <duke at openjdk.org> wrote:

>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Table.java line 349:
>> 
>>> 347:              * For more information on the `widget_tabbable_single` rule, please refer to the following documentation:
>>> 348:              * <a href="https://able.ibm.com/rules/archives/latest/doc/en-US/widget_tabbable_single.html#%7B%22message%22%3A%22Component%20with%20%5C%22tablist%5C%22%20role%20has%20more%20than%20one%20tabbable%20element%22%2C%22snippet%22%3A%22%3Cdiv%20tabindex%3D%5C%220%5C%22%20role%3D%5C%22tablist%5C%22%20class%3D%5C%22col-second%20odd-row-color%20method-summary-table%20method-summary-table-tab2%20method-summary-table-tab3%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22POTENTIAL%22%5D%2C%22reasonId%22%3A%22fail_multiple_tabbable%22%2C%22ruleId%22%3A%22widget_tabbable_single%22%7D">widget_tabbable_single</a>
>>> 349:              */
>> 
>> I think this new comment is a bit excessive. Can it be boiled down to a single sentence, maybe one or two lines? Also, there's no need to use `/**` doc comment style here. For example (but feel free to improve):
>> 
>>     // Only make element tabbable if it doesn't contain tabbable content.
>> 
>> Regarding the link, I don't think the content after the `#` is necessary. I would prefer the following form:
>> 
>>     // https://able.ibm.com/rules/archives/latest/doc/en-US/widget_tabbable_single.html
>
> I simplified comment as per your suggestion. Thank You.

Also, links containing `latest` are typically unstable

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17819#discussion_r1638713493

From dnguyen at openjdk.org  Thu Jun 13 21:32:24 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 13 Jun 2024 21:32:24 GMT
Subject: Integrated: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
References: <kBnLJalScsnsCOYxtnGUnxFAkZVP1eWtHxbdRWBCGeM=.98a2eef9-44f2-4f30-b147-ea37a2cd4b59@github.com>
Message-ID: <PHwvH3AGCvU714vSF5eogwl7u7smKE8mEXNNBx_jZHw=.00a7eff2-a020-4ff5-b82f-2a14b33ba35a@github.com>

On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
> 
> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
> 
> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
> https://cr.openjdk.org/~dnguyen/output2/

This pull request has now been integrated.

Changeset: c4702ca8
Author:    Damon Nguyen <dnguyen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a
Stats:     237 lines in 38 files changed: 133 ins; 57 del; 47 mod

8333827: JDK 23 RDP1 L10n resource files update

Reviewed-by: achung, jlu, naoto, joehw, prappo, cjplummer, asemenyuk, prr

-------------

PR: https://git.openjdk.org/jdk/pull/19609

From dnguyen at openjdk.org  Thu Jun 13 21:45:37 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 13 Jun 2024 21:45:37 GMT
Subject: [jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update
Message-ID: <ir-rPjlu15vrBoqjBZPeFbHx4fIwBmhkqTY2Ylt3D54=.501e11b7-9495-4e49-9358-5055e15b1b4d@github.com>

Hi all,

This pull request contains a backport of commit [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo, Chris Plummer, Alexey Semenyuk and Phil Race.

Thanks!

-------------

Commit messages:
 - Backport c4702ca8c026e2d265aca0126fd3fb7bc5bb392a

Changes: https://git.openjdk.org/jdk/pull/19713/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19713&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8333827
  Stats: 237 lines in 38 files changed: 133 ins; 57 del; 47 mod
  Patch: https://git.openjdk.org/jdk/pull/19713.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19713/head:pull/19713

PR: https://git.openjdk.org/jdk/pull/19713

From jlu at openjdk.org  Thu Jun 13 21:45:37 2024
From: jlu at openjdk.org (Justin Lu)
Date: Thu, 13 Jun 2024 21:45:37 GMT
Subject: [jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <ir-rPjlu15vrBoqjBZPeFbHx4fIwBmhkqTY2Ylt3D54=.501e11b7-9495-4e49-9358-5055e15b1b4d@github.com>
References: <ir-rPjlu15vrBoqjBZPeFbHx4fIwBmhkqTY2Ylt3D54=.501e11b7-9495-4e49-9358-5055e15b1b4d@github.com>
Message-ID: <BElwil0jmH0ze0istvpnHeChiUH_VkQTR2Fpekk6wAc=.b3a49075-4e5b-4819-8f43-698207725e09@github.com>

On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo, Chris Plummer, Alexey Semenyuk and Phil Race.
> 
> Thanks!

Clean backport of L10n resource drop required for JDK23

-------------

Marked as reviewed by jlu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/19713#pullrequestreview-2117082417

From naoto at openjdk.org  Thu Jun 13 21:48:14 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Thu, 13 Jun 2024 21:48:14 GMT
Subject: [jdk23] RFR: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <ir-rPjlu15vrBoqjBZPeFbHx4fIwBmhkqTY2Ylt3D54=.501e11b7-9495-4e49-9358-5055e15b1b4d@github.com>
References: <ir-rPjlu15vrBoqjBZPeFbHx4fIwBmhkqTY2Ylt3D54=.501e11b7-9495-4e49-9358-5055e15b1b4d@github.com>
Message-ID: <OIOxdjppmbkch2qDdWkZwpdRD9TLTMxAx7pD2fIZVTs=.a99b7fee-5dfc-4b3e-aac5-e524b5888da7@github.com>

On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo, Chris Plummer, Alexey Semenyuk and Phil Race.
> 
> Thanks!

Marked as reviewed by naoto (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19713#pullrequestreview-2117085705

From dnguyen at openjdk.org  Thu Jun 13 21:51:17 2024
From: dnguyen at openjdk.org (Damon Nguyen)
Date: Thu, 13 Jun 2024 21:51:17 GMT
Subject: [jdk23] Integrated: 8333827: JDK 23 RDP1 L10n resource files update
In-Reply-To: <ir-rPjlu15vrBoqjBZPeFbHx4fIwBmhkqTY2Ylt3D54=.501e11b7-9495-4e49-9358-5055e15b1b4d@github.com>
References: <ir-rPjlu15vrBoqjBZPeFbHx4fIwBmhkqTY2Ylt3D54=.501e11b7-9495-4e49-9358-5055e15b1b4d@github.com>
Message-ID: <2L_EtBxkTfdXVo8_kwbYVDyrQb9T5YRNQXwM03orLko=.be85bc8d-836c-49b1-9663-149f79562338@github.com>

On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo, Chris Plummer, Alexey Semenyuk and Phil Race.
> 
> Thanks!

This pull request has now been integrated.

Changeset: a7964453
Author:    Damon Nguyen <dnguyen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a7964453cf5203229d4a5b5231b7fc86da5d4af8
Stats:     237 lines in 38 files changed: 133 ins; 57 del; 47 mod

8333827: JDK 23 RDP1 L10n resource files update

Reviewed-by: jlu, naoto
Backport-of: c4702ca8c026e2d265aca0126fd3fb7bc5bb392a

-------------

PR: https://git.openjdk.org/jdk/pull/19713

From duke at openjdk.org  Fri Jun 14 09:19:33 2024
From: duke at openjdk.org (psoujany)
Date: Fri, 14 Jun 2024 09:19:33 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v34]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <ffWBWDY5VubDLz0uuLjjhNkMhXyGSTZfsqY9KGUUN8A=.ba11ebfb-ebe4-4fba-ba4f-db08788e9b45@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Add table role to summary tables

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/e84e18d9..86030317

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=33
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=32-33

  Stats: 133 lines in 23 files changed: 0 ins; 0 del; 133 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Fri Jun 14 10:42:38 2024
From: duke at openjdk.org (psoujany)
Date: Fri, 14 Jun 2024 10:42:38 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v35]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <UPvS-hU0JD602NyPyWBS1U-ev3b0i-kzMmHsFVZi1IQ=.c7dda8fb-8cfd-4b45-a0cd-62642cc5b127@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Add table role to summary tables

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/86030317..1534112b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=34
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=33-34

  Stats: 42 lines in 12 files changed: 0 ins; 0 del; 42 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Fri Jun 14 11:24:27 2024
From: duke at openjdk.org (psoujany)
Date: Fri, 14 Jun 2024 11:24:27 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v36]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <HIKYPqMxNDHKrrW9bZRRmftq_FXa7LLeHaaSV3te4pE=.79dc1c41-15c1-4c92-a2da-fb6ec9cddc0c@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Add table role to summary tables

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/1534112b..7717936a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=35
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=34-35

  Stats: 8 lines in 4 files changed: 0 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Fri Jun 14 11:31:30 2024
From: duke at openjdk.org (psoujany)
Date: Fri, 14 Jun 2024 11:31:30 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v37]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <JVuIvu3ARaIsfti1iilyQGyGmgG7x3DwueMa4oVvJ4o=.fb957983-6ecd-465e-829e-b01a97071cb8@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Add table role to summary tables

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/7717936a..a2b0bab7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=36
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=35-36

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Fri Jun 14 11:46:17 2024
From: duke at openjdk.org (psoujany)
Date: Fri, 14 Jun 2024 11:46:17 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v37]
In-Reply-To: <JVuIvu3ARaIsfti1iilyQGyGmgG7x3DwueMa4oVvJ4o=.fb957983-6ecd-465e-829e-b01a97071cb8@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
 <JVuIvu3ARaIsfti1iilyQGyGmgG7x3DwueMa4oVvJ4o=.fb957983-6ecd-465e-829e-b01a97071cb8@github.com>
Message-ID: <OqyOjJvCWaXoLS5_9mI_LLH7aR0TSPgDPhTGVCmmYXw=.a1010958-6e5c-4293-8749-e70f052bcf64@github.com>

On Fri, 14 Jun 2024 11:31:30 GMT, psoujany <duke at openjdk.org> wrote:

>> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
>> https://bugs.openjdk.org/browse/JDK-8325690
>
> psoujany has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add table role to summary tables

@hns Thank you for the review. I tried to read more about table/grids and their associated ARIAs. 
As per [MDN](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-label), I added `role=table aria-label` for a table which doesn't has unique name and `role=table aria-labelledby`  for the table having unique name and `role=row tabindex=0` to the table rows making them tabbable. Could you please review these changes. Thank You.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17819#issuecomment-2167846820

From nbenalla at openjdk.org  Fri Jun 14 12:15:45 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Fri, 14 Jun 2024 12:15:45 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
Message-ID: <rEZoiFjDtz0xXEKG1oAdwDi94PuNVrBe9QXaMk0_CCM=.8a1a9ffa-d228-47ed-806a-45e07a5712a4@github.com>

> Can I please get a review for this change, that aims to add support for Global HTML tags.
> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
> Thanks in advance.

Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - Null safety
 - Merge branch 'master' into html-attributes
 - remove trailing whitespace
 - -Add a boolean attribute to the enum type
   -Simply regex in `visitAttribute`
   -Simplified the Test
   -Added a negative test
 - no longer print summary
 - no longer print summary
 - Add small comment
 - Remove classpath exception
 - Allow global variables

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19652/files
  - new: https://git.openjdk.org/jdk/pull/19652/files/a1292496..248f1f2a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19652&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19652&range=01-02

  Stats: 24208 lines in 691 files changed: 13960 ins; 8261 del; 1987 mod
  Patch: https://git.openjdk.org/jdk/pull/19652.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19652/head:pull/19652

PR: https://git.openjdk.org/jdk/pull/19652

From nbenalla at openjdk.org  Fri Jun 14 12:15:46 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Fri, 14 Jun 2024 12:15:46 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <rEZoiFjDtz0xXEKG1oAdwDi94PuNVrBe9QXaMk0_CCM=.8a1a9ffa-d228-47ed-806a-45e07a5712a4@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <rEZoiFjDtz0xXEKG1oAdwDi94PuNVrBe9QXaMk0_CCM=.8a1a9ffa-d228-47ed-806a-45e07a5712a4@github.com>
Message-ID: <Xyo3VgC_wbWGTWzZSAJztf8udTyVyK8bKDFbvkwmSP0=.df3c2ca4-8c08-4a8c-8098-1b0824656689@github.com>

On Fri, 14 Jun 2024 12:12:51 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - Null safety
>  - Merge branch 'master' into html-attributes
>  - remove trailing whitespace
>  - -Add a boolean attribute to the enum type
>    -Simply regex in `visitAttribute`
>    -Simplified the Test
>    -Added a negative test
>  - no longer print summary
>  - no longer print summary
>  - Add small comment
>  - Remove classpath exception
>  - Allow global variables

I've updated the PR based on everyone's suggestions, here are the main changes.
Currently running tier 1-3

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line 695:

> 693:             // custom "data-*" attributes are also accepted
> 694:             var attrName = name.toString();
> 695:             if (!attrName.startsWith("on") && !attrName.startsWith("data-")) {

I've removed the regex here.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 441:

> 439:         ALINK,
> 440:         ALT,
> 441:         ARIA_ACTIVEDESCENDANT(true),

The enum `Attr` holds two values now, the second representing whether it's a global attribute.

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 670:

> 668:     public AttrKind getAttrKind(Name attrName) {
> 669:         Attr attr= getAttr(attrName);
> 670:         AttrKind k = attr.isGlobal()? AttrKind.OK: attrs.get(attr); // null-safe

As hannes suggested, `getAttrKind` now returns `AttrKind.OK` if we are dealing with a global attribute.

Edit: It's no longer null safe so I will slightly change it

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 673:

> 671: 
> 672:         if (attr != null) {
> 673:             kind = attr.isGlobal() ? AttrKind.OK : attrs.get(attr);  // get is null-safe

As hannes suggested, `getAttrKind` now returns `AttrKind.OK` if we are dealing with a global attribute.

I've added a null check here because of `attr.isGlobal()`

test/langtools/jdk/javadoc/doclet/TestGlobalHtml/TestGlobalHtml.java line 70:

> 68:                 public class C {
> 69:                     /**
> 70:                      * <form>

Added a negative test, as `<a>` and `<form>` tags aren't allowed .

test/langtools/jdk/javadoc/doclet/TestGlobalHtml/pkg1/C1.java line 23:

> 21:  * questions.
> 22:  */
> 23: 

I've simplified the `C1` class, it's smaller now and has many smaller examples.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19652#pullrequestreview-2117318623
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1639144111
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1639145147
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1639147374
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1639726374
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1639145878
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1639146304

From nbenalla at openjdk.org  Fri Jun 14 12:15:46 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Fri, 14 Jun 2024 12:15:46 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v2]
In-Reply-To: <ZenQV6Xm6sI_V-oB8LaANNo2nVmpYlRYiwk7C0DWRHU=.eef8e8bf-9028-4c52-9e41-76c5dda4131e@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <ZenQV6Xm6sI_V-oB8LaANNo2nVmpYlRYiwk7C0DWRHU=.eef8e8bf-9028-4c52-9e41-76c5dda4131e@github.com>
Message-ID: <TcdfNDd8VTs37aV8FktxP-3h3jk8uM1-HbEoCHTxI5E=.93ff04e2-d8e5-4f60-8653-2b81aaa5fb42@github.com>

On Tue, 11 Jun 2024 13:24:48 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove classpath exception

I've ran tests locally for doclint and they all passed. Waiting on new results from tier 1-3 but there shouldn't be anything else that breaks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19652#issuecomment-2167889419

From nbenalla at openjdk.org  Fri Jun 14 12:15:47 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Fri, 14 Jun 2024 12:15:47 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <f9NaWnsPXLCMKr59nNTwHkt0wdkIB4dEX8CdLhUEhDc=.a1b6a55b-280f-4390-8280-ecdd9933f9fe@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <ZenQV6Xm6sI_V-oB8LaANNo2nVmpYlRYiwk7C0DWRHU=.eef8e8bf-9028-4c52-9e41-76c5dda4131e@github.com>
 <f9NaWnsPXLCMKr59nNTwHkt0wdkIB4dEX8CdLhUEhDc=.a1b6a55b-280f-4390-8280-ecdd9933f9fe@github.com>
Message-ID: <isR9CF6dli2wrO2ky7Pa6yr_t6F8bvYDVPnDqDI6B7U=.308b975f-c939-43ec-b16a-81d6cbe750bd@github.com>

On Tue, 11 Jun 2024 13:26:28 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Null safety
>>  - Merge branch 'master' into html-attributes
>>  - remove trailing whitespace
>>  - -Add a boolean attribute to the enum type
>>    -Simply regex in `visitAttribute`
>>    -Simplified the Test
>>    -Added a negative test
>>  - no longer print summary
>>  - no longer print summary
>>  - Add small comment
>>  - Remove classpath exception
>>  - Allow global variables
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line 695:
> 
>> 693:             // custom "data-*" attributes are also accepted
>> 694:             var attrName=name.toString();
>> 695:             if (!attrName.startsWith("on") && !attrName.matches("data-[a-z]+(-[a-z]+)*")){
> 
> I understand that `startsWith("on")` precedes this PR. However, it's more permissive than it should be: in reality, there are only 70 global attributes that start with "on". On the other hand, `attrName.matches("data-[a-z]+(-[a-z]+)*")` is less permissive. For example, if I read the XML spec correctly, such an attribute can contain `_` or start with `data-.`.
> 
> But maybe those checks are good enough?

I think like being slightly restrictive and safe.

> test/langtools/jdk/javadoc/doclet/TestGlobalHtml/TestGlobalHtml.java line 41:
> 
>> 39:         var tester = new TestGlobalHtml();
>> 40:         tester.runTests();
>> 41:         tester.printSummary();
> 
> Why is this summary needed? Usually, we don't print it.

Fixed in [cf4dab6](https://github.com/openjdk/jdk/pull/19652/commits/cf4dab6ceefb8625e9e7b281073cba49b894d13c). I was using it locally.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1635017243
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634982192

From prappo at openjdk.org  Fri Jun 14 12:15:47 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Fri, 14 Jun 2024 12:15:47 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <isR9CF6dli2wrO2ky7Pa6yr_t6F8bvYDVPnDqDI6B7U=.308b975f-c939-43ec-b16a-81d6cbe750bd@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <ZenQV6Xm6sI_V-oB8LaANNo2nVmpYlRYiwk7C0DWRHU=.eef8e8bf-9028-4c52-9e41-76c5dda4131e@github.com>
 <f9NaWnsPXLCMKr59nNTwHkt0wdkIB4dEX8CdLhUEhDc=.a1b6a55b-280f-4390-8280-ecdd9933f9fe@github.com>
 <isR9CF6dli2wrO2ky7Pa6yr_t6F8bvYDVPnDqDI6B7U=.308b975f-c939-43ec-b16a-81d6cbe750bd@github.com>
Message-ID: <_hmPpYYOW0JrDtDVQXESlDlNufvcMUyEbt_TbuCHlx0=.c6874de4-8b8a-4f87-af88-1ebccfc5c7f3@github.com>

On Tue, 11 Jun 2024 14:42:48 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line 695:
>> 
>>> 693:             // custom "data-*" attributes are also accepted
>>> 694:             var attrName=name.toString();
>>> 695:             if (!attrName.startsWith("on") && !attrName.matches("data-[a-z]+(-[a-z]+)*")){
>> 
>> I understand that `startsWith("on")` precedes this PR. However, it's more permissive than it should be: in reality, there are only 70 global attributes that start with "on". On the other hand, `attrName.matches("data-[a-z]+(-[a-z]+)*")` is less permissive. For example, if I read the XML spec correctly, such an attribute can contain `_` or start with `data-.`.
>> 
>> But maybe those checks are good enough?
>
> I think like being slightly restrictive and safe.

As @jonathan-gibbons likes to point out, javadoc is not an HTML validation tool. So I think, it's okay to leave the code simple. Maybe this would be even simpler?

    data-[a-z][-a-z0-9]*

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1635059794

From jjg at openjdk.org  Fri Jun 14 12:15:47 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 14 Jun 2024 12:15:47 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <_hmPpYYOW0JrDtDVQXESlDlNufvcMUyEbt_TbuCHlx0=.c6874de4-8b8a-4f87-af88-1ebccfc5c7f3@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <ZenQV6Xm6sI_V-oB8LaANNo2nVmpYlRYiwk7C0DWRHU=.eef8e8bf-9028-4c52-9e41-76c5dda4131e@github.com>
 <f9NaWnsPXLCMKr59nNTwHkt0wdkIB4dEX8CdLhUEhDc=.a1b6a55b-280f-4390-8280-ecdd9933f9fe@github.com>
 <isR9CF6dli2wrO2ky7Pa6yr_t6F8bvYDVPnDqDI6B7U=.308b975f-c939-43ec-b16a-81d6cbe750bd@github.com>
 <_hmPpYYOW0JrDtDVQXESlDlNufvcMUyEbt_TbuCHlx0=.c6874de4-8b8a-4f87-af88-1ebccfc5c7f3@github.com>
Message-ID: <FoN42jaYyTHtu1fkpXGugiGlnpYORAAQ3ZTPnh2W5mk=.345940a3-f9fb-4576-80e8-205834f8e995@github.com>

On Tue, 11 Jun 2024 15:09:03 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> I think like being slightly restrictive and safe.
>
> As @jonathan-gibbons likes to point out, javadoc is not an HTML validation tool. So I think, it's okay to leave the code simple. Maybe this would be even simpler?
> 
>     data-[a-z][-a-z0-9]*

I admit to being "lazy" when I wrote `startsWith("on")`. In general, I don't think folk should be writing many if any event handlers in doc comments, and it was easier to give forward compatibility with a weak test for `"on"`. Likewise, there should not be many if any uses of `data-*` attributes, and it is easy enough to give a simple regex. It's more important to not reject valid uses of event attributes and custom data attributes than it is to detect all invalid cases. The right place to detect all invalid cases is downstream in recognized validation tools, like `tidy` which catch all occurrences of bad stuff, wherever they originate (doc comment, command-line options, the `javadoc` tool, post-processors, etc).  DocLint is primarily an "early warning system" for common errors.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1635600065

From prappo at openjdk.org  Fri Jun 14 12:15:47 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Fri, 14 Jun 2024 12:15:47 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <FoN42jaYyTHtu1fkpXGugiGlnpYORAAQ3ZTPnh2W5mk=.345940a3-f9fb-4576-80e8-205834f8e995@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <ZenQV6Xm6sI_V-oB8LaANNo2nVmpYlRYiwk7C0DWRHU=.eef8e8bf-9028-4c52-9e41-76c5dda4131e@github.com>
 <f9NaWnsPXLCMKr59nNTwHkt0wdkIB4dEX8CdLhUEhDc=.a1b6a55b-280f-4390-8280-ecdd9933f9fe@github.com>
 <isR9CF6dli2wrO2ky7Pa6yr_t6F8bvYDVPnDqDI6B7U=.308b975f-c939-43ec-b16a-81d6cbe750bd@github.com>
 <_hmPpYYOW0JrDtDVQXESlDlNufvcMUyEbt_TbuCHlx0=.c6874de4-8b8a-4f87-af88-1ebccfc5c7f3@github.com>
 <FoN42jaYyTHtu1fkpXGugiGlnpYORAAQ3ZTPnh2W5mk=.345940a3-f9fb-4576-80e8-205834f8e995@github.com>
Message-ID: <DmkJmV-pN7H_7xFzuXzauYu43tv8STQB5ZaEJZ6RX8A=.e8fa83e3-5a2c-49b6-88d1-cd0400415f70@github.com>

On Tue, 11 Jun 2024 23:49:15 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> As @jonathan-gibbons likes to point out, javadoc is not an HTML validation tool. So I think, it's okay to leave the code simple. Maybe this would be even simpler?
>> 
>>     data-[a-z][-a-z0-9]*
>
> I admit to being "lazy" when I wrote `startsWith("on")`. In general, I don't think folk should be writing many if any event handlers in doc comments, and it was easier to give forward compatibility with a weak test for `"on"`. Likewise, there should not be many if any uses of `data-*` attributes, and it is easy enough to give a simple regex. It's more important to not reject valid uses of event attributes and custom data attributes than it is to detect all invalid cases. The right place to detect all invalid cases is downstream in recognized validation tools, like `tidy` which catch all occurrences of bad stuff, wherever they originate (doc comment, command-line options, the `javadoc` tool, post-processors, etc).  DocLint is primarily an "early warning system" for common errors.

I agree with you, Jon. So, we can simply use `startsWith("data-")`, which would be good enough and most permissive (i.e. no false negatives).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1636126138

From nbenalla at openjdk.org  Fri Jun 14 12:15:47 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Fri, 14 Jun 2024 12:15:47 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <DmkJmV-pN7H_7xFzuXzauYu43tv8STQB5ZaEJZ6RX8A=.e8fa83e3-5a2c-49b6-88d1-cd0400415f70@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <ZenQV6Xm6sI_V-oB8LaANNo2nVmpYlRYiwk7C0DWRHU=.eef8e8bf-9028-4c52-9e41-76c5dda4131e@github.com>
 <f9NaWnsPXLCMKr59nNTwHkt0wdkIB4dEX8CdLhUEhDc=.a1b6a55b-280f-4390-8280-ecdd9933f9fe@github.com>
 <isR9CF6dli2wrO2ky7Pa6yr_t6F8bvYDVPnDqDI6B7U=.308b975f-c939-43ec-b16a-81d6cbe750bd@github.com>
 <_hmPpYYOW0JrDtDVQXESlDlNufvcMUyEbt_TbuCHlx0=.c6874de4-8b8a-4f87-af88-1ebccfc5c7f3@github.com>
 <FoN42jaYyTHtu1fkpXGugiGlnpYORAAQ3ZTPnh2W5mk=.345940a3-f9fb-4576-80e8-205834f8e995@github.com>
 <DmkJmV-pN7H_7xFzuXzauYu43tv8STQB5ZaEJZ6RX8A=.e8fa83e3-5a2c-49b6-88d1-cd0400415f70@github.com>
Message-ID: <2ZIfH8r3kkYL55Mpp2TDW3PFpazCNSDOTvj6gyOkK0g=.0e974410-8dab-4191-9795-e43976583827@github.com>

On Wed, 12 Jun 2024 09:26:25 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> I admit to being "lazy" when I wrote `startsWith("on")`. In general, I don't think folk should be writing many if any event handlers in doc comments, and it was easier to give forward compatibility with a weak test for `"on"`. Likewise, there should not be many if any uses of `data-*` attributes, and it is easy enough to give a simple regex. It's more important to not reject valid uses of event attributes and custom data attributes than it is to detect all invalid cases. The right place to detect all invalid cases is downstream in recognized validation tools, like `tidy` which catch all occurrences of bad stuff, wherever they originate (doc comment, command-line options, the `javadoc` tool, post-processors, etc).  DocLint is primarily an "early warning system" for common errors.
>
> I agree with you, Jon. So, we can simply use `startsWith("data-")`, which would be good enough and most permissive (i.e. no false negatives).

Sure, I will go with that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1636140103

From jjg at openjdk.org  Fri Jun 14 12:15:47 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 14 Jun 2024 12:15:47 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <WA6BhWjUbrPsIoazxUCsi6WVAmJgqQPp7OvpiMOIBv4=.8fa54cbe-0efc-4394-b1a7-50e6d410f737@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <74b_ftxSsh1-C1tLKzuZG-XpkMNFINSU69uRRcTqYME=.f2276cc2-79e0-4931-b5e9-36eba7a1568f@github.com>
 <FM63ProninPmneneJPugqp7AN6hDgHAL-2MivTuOtw0=.66e676bf-7172-444f-9a9f-4a4d1d7f21cc@github.com>
 <WA6BhWjUbrPsIoazxUCsi6WVAmJgqQPp7OvpiMOIBv4=.8fa54cbe-0efc-4394-b1a7-50e6d410f737@github.com>
Message-ID: <6uMiFaOQdfdS7piwmse3ijbBqTIOLKUj69Tzqn0JH9g=.c6db2c71-50e1-4a70-a330-1a4454a37d35@github.com>

On Tue, 11 Jun 2024 12:40:23 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Either what Chen has suggested or re-sort the complete list alphabetically as it was prior to this change, well, almost.
>
>> Either what Chen has suggested or re-sort the complete list alphabetically as it was prior to this change.
> 
> I will go with Chen's suggestions, will fix in a bit.
> 
> I might move STYLE down as it's also a global tag

I'm (mostly) with Pavel about `enum` ordering -- it's OK when there is an obvious natural order, but risky when it's not. It's generally better to find other ways to categorize members than relying on the order.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1635605329

From jjg at openjdk.org  Fri Jun 14 12:15:47 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 14 Jun 2024 12:15:47 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <RQ1MMLAOj2SFojwi7vJIQjBZq36t1iyUuRob6VLkxqE=.1e010391-ba53-4e42-927a-491a038c4fe4@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <troxEwciEfFvU8xOVeUQcBkmQUyApATfXxI9twTGDfI=.f060316b-8bab-4566-95e8-f8a68bbc0bf8@github.com>
 <nc8iP7srsdnlaw_p78EVZz3XcTGTCAp-FrBsZZlVMzE=.74feff0a-2283-4b69-b8fb-d57c43322a86@github.com>
 <RQ1MMLAOj2SFojwi7vJIQjBZq36t1iyUuRob6VLkxqE=.1e010391-ba53-4e42-927a-491a038c4fe4@github.com>
Message-ID: <rn-OS053KoQXdF64G2Bz9fwdpFylZPl45DOxhLgHlso=.26a2581f-b34a-4125-9029-834da35ba5e2@github.com>

On Tue, 11 Jun 2024 13:41:58 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> If we are ordering the entries, we can use comparable to check that an attr is greater than the start of the global attr, something like
>> 
>> private static boolean isGlobalAttr(Attr value) {
>>     return value.compareTo(Attr.ACCESSKEY) >= 0;
>> }
>
>> If we are ordering the entries, we can use comparable to check that an attr is greater than the start of the global attr, something like
>> 
>> ```java
>> private static boolean isGlobalAttr(Attr value) {
>>     return value.compareTo(Attr.ACCESSKEY) >= 0;
>> }
>> ```
> 
> That would also work, yes. I still avoid relying on the order of enum constants; but it's me.

I suggest one of

1. Add a `boolean global;` member to the enum, and provide a second constructor that allows that boolean member to be set true.   For example,

WIDTH,
STYLE(true),


2. Make the `Set` be static and init it in a static initializer.
See the `javac` `Source` and `Target` classes for examples of this technique.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1635524009

From hannesw at openjdk.org  Fri Jun 14 12:15:47 2024
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Fri, 14 Jun 2024 12:15:47 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <rn-OS053KoQXdF64G2Bz9fwdpFylZPl45DOxhLgHlso=.26a2581f-b34a-4125-9029-834da35ba5e2@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <troxEwciEfFvU8xOVeUQcBkmQUyApATfXxI9twTGDfI=.f060316b-8bab-4566-95e8-f8a68bbc0bf8@github.com>
 <nc8iP7srsdnlaw_p78EVZz3XcTGTCAp-FrBsZZlVMzE=.74feff0a-2283-4b69-b8fb-d57c43322a86@github.com>
 <RQ1MMLAOj2SFojwi7vJIQjBZq36t1iyUuRob6VLkxqE=.1e010391-ba53-4e42-927a-491a038c4fe4@github.com>
 <rn-OS053KoQXdF64G2Bz9fwdpFylZPl45DOxhLgHlso=.26a2581f-b34a-4125-9029-834da35ba5e2@github.com>
Message-ID: <wiJChMhUeISDhJ2S78NdIlMPWfj4xWjPWP0l32BMoW8=.224d115d-f6ca-4e54-b2fc-24d73a08ceba@github.com>

On Tue, 11 Jun 2024 21:58:46 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>>> If we are ordering the entries, we can use comparable to check that an attr is greater than the start of the global attr, something like
>>> 
>>> ```java
>>> private static boolean isGlobalAttr(Attr value) {
>>>     return value.compareTo(Attr.ACCESSKEY) >= 0;
>>> }
>>> ```
>> 
>> That would also work, yes. I still avoid relying on the order of enum constants; but it's me.
>
> I suggest one of
> 
> 1. Add a `boolean global;` member to the enum, and provide a second constructor that allows that boolean member to be set true.   For example,
> 
> WIDTH,
> STYLE(true),
> 
> 
> 2. Make the `Set` be static and init it in a static initializer.
> See the `javac` `Source` and `Target` classes for examples of this technique.

Wouldn't the easiest solution be to add a boolean `global`/`isGlobal` field and getter to `Attr`?

That would give use some more opportunities to simplify the code: We could get rid of the `GLOBAL_ATTRS` map here *and* avoid putting global attributes in the the `attr` map of each `HtmlTag` instance by simply adding a shortcut to return `AttrKind.OK` in `getAttrKind(Name)` if the given attribute is global.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1636093592

From hannesw at openjdk.org  Fri Jun 14 12:15:47 2024
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Fri, 14 Jun 2024 12:15:47 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <wiJChMhUeISDhJ2S78NdIlMPWfj4xWjPWP0l32BMoW8=.224d115d-f6ca-4e54-b2fc-24d73a08ceba@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <troxEwciEfFvU8xOVeUQcBkmQUyApATfXxI9twTGDfI=.f060316b-8bab-4566-95e8-f8a68bbc0bf8@github.com>
 <nc8iP7srsdnlaw_p78EVZz3XcTGTCAp-FrBsZZlVMzE=.74feff0a-2283-4b69-b8fb-d57c43322a86@github.com>
 <RQ1MMLAOj2SFojwi7vJIQjBZq36t1iyUuRob6VLkxqE=.1e010391-ba53-4e42-927a-491a038c4fe4@github.com>
 <rn-OS053KoQXdF64G2Bz9fwdpFylZPl45DOxhLgHlso=.26a2581f-b34a-4125-9029-834da35ba5e2@github.com>
 <wiJChMhUeISDhJ2S78NdIlMPWfj4xWjPWP0l32BMoW8=.224d115d-f6ca-4e54-b2fc-24d73a08ceba@github.com>
Message-ID: <hIM_Q8nXgUA7axU45JQJrWl6e3WXx4j8TIEqpfPlzu8=.0402fdfd-cf57-436a-a2b7-8ee30a7c3347@github.com>

On Wed, 12 Jun 2024 09:02:20 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

>> I suggest one of
>> 
>> 1. Add a `boolean global;` member to the enum, and provide a second constructor that allows that boolean member to be set true.   For example,
>> 
>> WIDTH,
>> STYLE(true),
>> 
>> 
>> 2. Make the `Set` be static and init it in a static initializer.
>> See the `javac` `Source` and `Target` classes for examples of this technique.
>
> Wouldn't the easiest solution be to add a boolean `global`/`isGlobal` field and getter to `Attr`?
> 
> That would give use some more opportunities to simplify the code: We could get rid of the `GLOBAL_ATTRS` map here *and* avoid putting global attributes in the the `attr` map of each `HtmlTag` instance by simply adding a shortcut to return `AttrKind.OK` in `getAttrKind(Name)` if the given attribute is global.

BTW, this should also be done by global attributes that are already respected, such as `id`, `class`, and the `aria-*` accessibility attributes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1636095371

From prappo at openjdk.org  Fri Jun 14 12:15:47 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Fri, 14 Jun 2024 12:15:47 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <hIM_Q8nXgUA7axU45JQJrWl6e3WXx4j8TIEqpfPlzu8=.0402fdfd-cf57-436a-a2b7-8ee30a7c3347@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <troxEwciEfFvU8xOVeUQcBkmQUyApATfXxI9twTGDfI=.f060316b-8bab-4566-95e8-f8a68bbc0bf8@github.com>
 <nc8iP7srsdnlaw_p78EVZz3XcTGTCAp-FrBsZZlVMzE=.74feff0a-2283-4b69-b8fb-d57c43322a86@github.com>
 <RQ1MMLAOj2SFojwi7vJIQjBZq36t1iyUuRob6VLkxqE=.1e010391-ba53-4e42-927a-491a038c4fe4@github.com>
 <rn-OS053KoQXdF64G2Bz9fwdpFylZPl45DOxhLgHlso=.26a2581f-b34a-4125-9029-834da35ba5e2@github.com>
 <wiJChMhUeISDhJ2S78NdIlMPWfj4xWjPWP0l32BMoW8=.224d115d-f6ca-4e54-b2fc-24d73a08ceba@github.com>
 <hIM_Q8nXgUA7axU45JQJrWl6e3WXx4j8TIEqpfPlzu8=.0402fdfd-cf57-436a-a2b7-8ee30a7c3347@github.com>
Message-ID: <IP35tklUtH323Bbfopa_jVYGK963vRZwVZZSyYO4ZEk=.3857d559-8fd0-4d72-ae41-a73b24b28be7@github.com>

On Wed, 12 Jun 2024 09:03:38 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

>> Wouldn't the easiest solution be to add a boolean `global`/`isGlobal` field and getter to `Attr`?
>> 
>> That would give use some more opportunities to simplify the code: We could get rid of the `GLOBAL_ATTRS` map here *and* avoid putting global attributes in the the `attr` map of each `HtmlTag` instance by simply adding a shortcut to return `AttrKind.OK` in `getAttrKind(Name)` if the given attribute is global.
>
> BTW, this should also be done by global attributes that are already respected, such as `id`, `class`, and the `aria-*` accessibility attributes.

I agree with Hannes on both comments:

  - `class`, `id`, `slot`, and `aria-*` are effectively global attributes and should be modelled as such
  - global attributes could probably be constructed with a boolean argument `true`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1636148171

From jjg at openjdk.org  Fri Jun 14 12:15:47 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 14 Jun 2024 12:15:47 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <rEZoiFjDtz0xXEKG1oAdwDi94PuNVrBe9QXaMk0_CCM=.8a1a9ffa-d228-47ed-806a-45e07a5712a4@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <rEZoiFjDtz0xXEKG1oAdwDi94PuNVrBe9QXaMk0_CCM=.8a1a9ffa-d228-47ed-806a-45e07a5712a4@github.com>
Message-ID: <afH6p2vF_yalWruYQIlhj-LkucHz3dN5YDxuL4HI67c=.a25a3eb1-1f3c-4511-9fec-f7b0a8f4c27b@github.com>

On Fri, 14 Jun 2024 12:12:51 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - Null safety
>  - Merge branch 'master' into html-attributes
>  - remove trailing whitespace
>  - -Add a boolean attribute to the enum type
>    -Simply regex in `visitAttribute`
>    -Simplified the Test
>    -Added a negative test
>  - no longer print summary
>  - no longer print summary
>  - Add small comment
>  - Remove classpath exception
>  - Allow global variables

test/langtools/jdk/javadoc/doclet/TestGlobalHtml/pkg1/C1.java line 1:

> 1: /*

This example is way too big and/or insufficiently focused on global attributes.  As an example of this, compare the size of the input programs to the size (number) of strings given to `checkOutput` in. the previous file.

The challenge of writing good tests is to find the simplest example that causes the newly-written code to be executed.

Also, while not wrong, it's also "old-school" to write separate classes in separate files to run through `javadoc`.  You can often come up with small enough examples to fit in text blocks in the main test program.

In this case, I would suggest providing a class with a comment containing a whole bunch of simple tags each containing one or more global attributes. It doesn't have to make "sense" as a comment -- it just has to exercise code paths in the new code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1635537304

From jjg at openjdk.org  Fri Jun 14 12:15:48 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 14 Jun 2024 12:15:48 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <afH6p2vF_yalWruYQIlhj-LkucHz3dN5YDxuL4HI67c=.a25a3eb1-1f3c-4511-9fec-f7b0a8f4c27b@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <rEZoiFjDtz0xXEKG1oAdwDi94PuNVrBe9QXaMk0_CCM=.8a1a9ffa-d228-47ed-806a-45e07a5712a4@github.com>
 <afH6p2vF_yalWruYQIlhj-LkucHz3dN5YDxuL4HI67c=.a25a3eb1-1f3c-4511-9fec-f7b0a8f4c27b@github.com>
Message-ID: <WTpNgPgs-_lAd-c6eX3I_uTBEnrbR-Du3MEcz_48Ark=.0a08883b-b40c-46c8-b75f-8394931c5c26@github.com>

On Tue, 11 Jun 2024 22:12:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Null safety
>>  - Merge branch 'master' into html-attributes
>>  - remove trailing whitespace
>>  - -Add a boolean attribute to the enum type
>>    -Simply regex in `visitAttribute`
>>    -Simplified the Test
>>    -Added a negative test
>>  - no longer print summary
>>  - no longer print summary
>>  - Add small comment
>>  - Remove classpath exception
>>  - Allow global variables
>
> test/langtools/jdk/javadoc/doclet/TestGlobalHtml/pkg1/C1.java line 1:
> 
>> 1: /*
> 
> This example is way too big and/or insufficiently focused on global attributes.  As an example of this, compare the size of the input programs to the size (number) of strings given to `checkOutput` in. the previous file.
> 
> The challenge of writing good tests is to find the simplest example that causes the newly-written code to be executed.
> 
> Also, while not wrong, it's also "old-school" to write separate classes in separate files to run through `javadoc`.  You can often come up with small enough examples to fit in text blocks in the main test program.
> 
> In this case, I would suggest providing a class with a comment containing a whole bunch of simple tags each containing one or more global attributes. It doesn't have to make "sense" as a comment -- it just has to exercise code paths in the new code.

Also, consider what it might mean to write "negative" tests. That might be a bit tricky, given these are global attributes, accepted on all HTML tags that can appear in a doc comment, so at least make sure there is a test (there may already be a test) for something that is not a global attribute, just to test the error reporting.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1635550821

From jjg at openjdk.org  Fri Jun 14 12:15:48 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 14 Jun 2024 12:15:48 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <troxEwciEfFvU8xOVeUQcBkmQUyApATfXxI9twTGDfI=.f060316b-8bab-4566-95e8-f8a68bbc0bf8@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <troxEwciEfFvU8xOVeUQcBkmQUyApATfXxI9twTGDfI=.f060316b-8bab-4566-95e8-f8a68bbc0bf8@github.com>
Message-ID: <uuqKBoo07QOsObZws28GZXFOxnOVsCtNuHKA5ks--xE=.fe03e15f-d1a3-4535-816e-044099459a0f@github.com>

On Tue, 11 Jun 2024 13:03:47 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Null safety
>>  - Merge branch 'master' into html-attributes
>>  - remove trailing whitespace
>>  - -Add a boolean attribute to the enum type
>>    -Simply regex in `visitAttribute`
>>    -Simplified the Test
>>    -Added a negative test
>>  - no longer print summary
>>  - no longer print summary
>>  - Add small comment
>>  - Remove classpath exception
>>  - Allow global variables
>
> test/langtools/jdk/javadoc/doclet/TestGlobalHtml/pkg1/C2.java line 104:
> 
>> 102:      * </p>
>> 103:      *
>> 104:      * <ul>
> 
> Since you use `ol`, `ul`, and `li`elements, you could add global attributes to them too. Otherwise, you only have such attributes in `p` elements.

The more you go down this path, the more this seems like a combo test for generated code ;-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1636662684

From duke at openjdk.org  Fri Jun 14 12:50:44 2024
From: duke at openjdk.org (psoujany)
Date: Fri, 14 Jun 2024 12:50:44 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v38]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <7e4UpHxLogkFEskNHg_ULDAV5b2HzOE0yZSxUUbQeNA=.c2d9be91-18d5-4ff2-8580-587bd7a260ae@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 42 additional commits since the last revision:

 - Merge branch 'openjdk:master' into remove-overflow
 - Add table role to summary tables
 - Add table role to summary tables
 - Add table role to summary tables
 - Add table role to summary tables
 - Add grid role to tables
 - Add grid role to tables
 - Merge branch 'remove-overflow' of github.com:psoujany/jdk into remove-overflow
 - Merge branch 'openjdk:master' into remove-overflow
 - Add grid role to tables
 - ... and 32 more: https://git.openjdk.org/jdk/compare/72559e1c...8748de2a

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/a2b0bab7..8748de2a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=37
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=36-37

  Stats: 1936 lines in 108 files changed: 1483 ins; 165 del; 288 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From prappo at openjdk.org  Fri Jun 14 14:56:21 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Fri, 14 Jun 2024 14:56:21 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v3]
In-Reply-To: <rEZoiFjDtz0xXEKG1oAdwDi94PuNVrBe9QXaMk0_CCM=.8a1a9ffa-d228-47ed-806a-45e07a5712a4@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <rEZoiFjDtz0xXEKG1oAdwDi94PuNVrBe9QXaMk0_CCM=.8a1a9ffa-d228-47ed-806a-45e07a5712a4@github.com>
Message-ID: <kAA0ZFkJLwahiN68cgV7ZZbCTklJllOScM7X_J17kIw=.2a002b25-dabc-496b-afbc-472a389a0c40@github.com>

On Fri, 14 Jun 2024 12:15:45 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - Null safety
>  - Merge branch 'master' into html-attributes
>  - remove trailing whitespace
>  - -Add a boolean attribute to the enum type
>    -Simply regex in `visitAttribute`
>    -Simplified the Test
>    -Added a negative test
>  - no longer print summary
>  - no longer print summary
>  - Add small comment
>  - Remove classpath exception
>  - Allow global variables

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 672:

> 670:         AttrKind kind = null;
> 671: 
> 672:         if (attr != null) {

Can the remainder of this method be simplified using `Map.getOrDefault`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1639952309

From hannesw at openjdk.org  Fri Jun 14 16:41:32 2024
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Fri, 14 Jun 2024 16:41:32 GMT
Subject: RFR: 8334241: Adjust API docs side bar dimensions
Message-ID: <oTuJsLsNk_Bon-Sk9pAhETgkWUcIFOD7Rg8y7qM2EGw=.00b88f38-c034-414b-b3c5-baeccc7fe350@github.com>

Please review a change to slightly adjust the proportion between the side bar and the main content area in API documentation pages, making the side bar a bit slimmer and leaving more space for the main content area. The ratio between side bar and main content used to be 1 : 2.6, it is now 1 : 3. 

Updated API documentation[ can be viewed here](https://cr.openjdk.org/~hannesw/8334241/api.00/java.base/java/lang/Object.html).

-------------

Commit messages:
 - JDK-8334241: Adjust API docs side bar dimensions

Changes: https://git.openjdk.org/jdk/pull/19726/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19726&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8334241
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19726.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19726/head:pull/19726

PR: https://git.openjdk.org/jdk/pull/19726

From nbenalla at openjdk.org  Fri Jun 14 19:00:41 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Fri, 14 Jun 2024 19:00:41 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v4]
In-Reply-To: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
Message-ID: <R-BL4m_jRXueCHzS13rYHNdwcKZvNypJXZqoECwkro4=.aa64550b-29df-4716-968f-a4500088b7bf@github.com>

> Can I please get a review for this change, that aims to add support for Global HTML tags.
> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
> Thanks in advance.

Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:

  Simplify method

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19652/files
  - new: https://git.openjdk.org/jdk/pull/19652/files/248f1f2a..0e792be4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19652&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19652&range=02-03

  Stats: 7 lines in 1 file changed: 1 ins; 2 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/19652.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19652/head:pull/19652

PR: https://git.openjdk.org/jdk/pull/19652

From liach at openjdk.org  Fri Jun 14 19:12:12 2024
From: liach at openjdk.org (Chen Liang)
Date: Fri, 14 Jun 2024 19:12:12 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v4]
In-Reply-To: <R-BL4m_jRXueCHzS13rYHNdwcKZvNypJXZqoECwkro4=.aa64550b-29df-4716-968f-a4500088b7bf@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <R-BL4m_jRXueCHzS13rYHNdwcKZvNypJXZqoECwkro4=.aa64550b-29df-4716-968f-a4500088b7bf@github.com>
Message-ID: <mnQl245hv9l5_uIsBSYNUWTOHjF4AbbIz-M1S3sRrsU=.6c3a0cef-dc16-4789-a10e-12a4e5933c33@github.com>

On Fri, 14 Jun 2024 19:00:41 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplify method

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 670:

> 668:     public AttrKind getAttrKind(Name attrName) {
> 669:         Attr attr = getAttr(attrName);
> 670:         if (attr==null){

Suggestion:

        if (attr == null) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1640233115

From nbenalla at openjdk.org  Fri Jun 14 19:16:26 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Fri, 14 Jun 2024 19:16:26 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v5]
In-Reply-To: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
Message-ID: <FKdfLlnKRGOL90leHOG0kwHPI8XM6WVxPaaPx3nIUow=.9f547095-b55a-46dc-b473-a2dab5a068db@github.com>

> Can I please get a review for this change, that aims to add support for Global HTML tags.
> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
> Thanks in advance.

Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:

  whitespace

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19652/files
  - new: https://git.openjdk.org/jdk/pull/19652/files/0e792be4..cfde660d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19652&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19652&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19652.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19652/head:pull/19652

PR: https://git.openjdk.org/jdk/pull/19652

From nbenalla at openjdk.org  Fri Jun 14 19:16:26 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Fri, 14 Jun 2024 19:16:26 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v4]
In-Reply-To: <mnQl245hv9l5_uIsBSYNUWTOHjF4AbbIz-M1S3sRrsU=.6c3a0cef-dc16-4789-a10e-12a4e5933c33@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <R-BL4m_jRXueCHzS13rYHNdwcKZvNypJXZqoECwkro4=.aa64550b-29df-4716-968f-a4500088b7bf@github.com>
 <mnQl245hv9l5_uIsBSYNUWTOHjF4AbbIz-M1S3sRrsU=.6c3a0cef-dc16-4789-a10e-12a4e5933c33@github.com>
Message-ID: <Z2zxbsm7TfleNudjo6jj4__saCuiNkq7o0Plyzf9Vdc=.d5323fe4-ca47-450a-907b-e629c391af8c@github.com>

On Fri, 14 Jun 2024 19:01:56 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplify method
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 670:
> 
>> 668:     public AttrKind getAttrKind(Name attrName) {
>> 669:         Attr attr = getAttr(attrName);
>> 670:         if (attr==null){
> 
> Suggestion:
> 
>         if (attr == null) {

Thanks, didn't run a formatter on this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1640242180

From syan at openjdk.org  Sat Jun 15 09:13:40 2024
From: syan at openjdk.org (SendaoYan)
Date: Sat, 15 Jun 2024 09:13:40 GMT
Subject: RFR: 8334332: Run TestIOException.java with root user fails
Message-ID: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>

Hi all,
  Test `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root.
  The change has been verified, only change the testcase, no risk.

-------------

Commit messages:
 - 8334332: TestIOException.java fails run with root user

Changes: https://git.openjdk.org/jdk/pull/19731/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19731&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8334332
  Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/19731.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19731/head:pull/19731

PR: https://git.openjdk.org/jdk/pull/19731

From syan at openjdk.org  Sat Jun 15 09:54:38 2024
From: syan at openjdk.org (SendaoYan)
Date: Sat, 15 Jun 2024 09:54:38 GMT
Subject: RFR: 8334332: Run TestIOException.java with root user fails [v2]
In-Reply-To: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
Message-ID: <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>

> Hi all,
>   Test `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root.
>   The change has been verified, only change the testcase, no risk.

SendaoYan has updated the pull request incrementally with one additional commit since the last revision:

  delete an extra whitespace

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19731/files
  - new: https://git.openjdk.org/jdk/pull/19731/files/24b4f6f9..30916158

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19731&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19731&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19731.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19731/head:pull/19731

PR: https://git.openjdk.org/jdk/pull/19731

From prappo at openjdk.org  Mon Jun 17 15:14:15 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Mon, 17 Jun 2024 15:14:15 GMT
Subject: RFR: 8334332: Run TestIOException.java with root user fails [v2]
In-Reply-To: <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
Message-ID: <xXhRhl7Dxr-FmJgpH8BLQZFVF6XUl_dO5rn2hAE8s-c=.e2a94e85-7066-45c4-a89f-8bd09c546c77@github.com>

On Sat, 15 Jun 2024 09:54:38 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>>   Test `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root.
>>   Why run the jtreg test by root user? It's because during rpmbuild process for linux distribution of JDK, root user is the default user to build the openjdk, also is the default user to run the `make test-tier1`, this PR make this testcase more robustness.
>>   The change has been verified, only change the testcase, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   delete an extra whitespace

I re-titled the JBS issue, please update this PR title accordingly.

test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java line 58:

> 56:         if(Platform.isRoot() && !tester.isWindows()) {
> 57:             throw new SkippedException("root user has privileged will make this test fail.");
> 58:         }

Suggestion:

        if (Platform.isRoot() && !tester.isWindows()) {
            throw new SkippedException("root user has privileges that will make this test fail");
        }
        var tester = new TestIOException();

-------------

PR Review: https://git.openjdk.org/jdk/pull/19731#pullrequestreview-2123177216
PR Review Comment: https://git.openjdk.org/jdk/pull/19731#discussion_r1642972912

From syan at openjdk.org  Mon Jun 17 15:23:13 2024
From: syan at openjdk.org (SendaoYan)
Date: Mon, 17 Jun 2024 15:23:13 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v2]
In-Reply-To: <xXhRhl7Dxr-FmJgpH8BLQZFVF6XUl_dO5rn2hAE8s-c=.e2a94e85-7066-45c4-a89f-8bd09c546c77@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
 <xXhRhl7Dxr-FmJgpH8BLQZFVF6XUl_dO5rn2hAE8s-c=.e2a94e85-7066-45c4-a89f-8bd09c546c77@github.com>
Message-ID: <8-SYaTy3H5Y43DqhvjONM45-KQKA0lsMGTc1yf_hcgE=.10911d2f-e8bf-4c14-b288-80055221da40@github.com>

On Mon, 17 Jun 2024 15:11:56 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> I re-titled the JBS issue, please update this PR title accordingly.

Okey, thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19731#issuecomment-2173697821

From syan at openjdk.org  Mon Jun 17 15:32:18 2024
From: syan at openjdk.org (SendaoYan)
Date: Mon, 17 Jun 2024 15:32:18 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v2]
In-Reply-To: <xXhRhl7Dxr-FmJgpH8BLQZFVF6XUl_dO5rn2hAE8s-c=.e2a94e85-7066-45c4-a89f-8bd09c546c77@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
 <xXhRhl7Dxr-FmJgpH8BLQZFVF6XUl_dO5rn2hAE8s-c=.e2a94e85-7066-45c4-a89f-8bd09c546c77@github.com>
Message-ID: <zSpZm8hC3Ig7qdcIHC9o_bRBR5jZiVbzz9NPJlk2hIc=.99ea4b3f-fc20-4ea1-bc52-8b944d478ab7@github.com>

On Mon, 17 Jun 2024 15:10:52 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   delete an extra whitespace
>
> test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java line 58:
> 
>> 56:         if(Platform.isRoot() && !tester.isWindows()) {
>> 57:             throw new SkippedException("root user has privileged will make this test fail.");
>> 58:         }
> 
> Suggestion:
> 
>         if (Platform.isRoot() && !tester.isWindows()) {
>             throw new SkippedException("root user has privileges that will make this test fail");
>         }
>         var tester = new TestIOException();

`isWindows()` is not static, so call this function need a instance `TestIOException` object, thus `var tester = new TestIOException();` should at before line 56.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19731#discussion_r1643003292

From hannesw at openjdk.org  Mon Jun 17 16:06:23 2024
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Mon, 17 Jun 2024 16:06:23 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v38]
In-Reply-To: <7e4UpHxLogkFEskNHg_ULDAV5b2HzOE0yZSxUUbQeNA=.c2d9be91-18d5-4ff2-8580-587bd7a260ae@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
 <7e4UpHxLogkFEskNHg_ULDAV5b2HzOE0yZSxUUbQeNA=.c2d9be91-18d5-4ff2-8580-587bd7a260ae@github.com>
Message-ID: <z1W9jH4YokSVtPJV9DhODZQPk4o1dLzE78sy2Gb4_Ow=.0d48c090-cf94-4499-a1d1-c54cbaf459fd@github.com>

On Fri, 14 Jun 2024 12:50:44 GMT, psoujany <duke at openjdk.org> wrote:

>> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
>> https://bugs.openjdk.org/browse/JDK-8325690
>
> psoujany has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 42 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into remove-overflow
>  - Add table role to summary tables
>  - Add table role to summary tables
>  - Add table role to summary tables
>  - Add table role to summary tables
>  - Add grid role to tables
>  - Add grid role to tables
>  - Merge branch 'remove-overflow' of github.com:psoujany/jdk into remove-overflow
>  - Merge branch 'openjdk:master' into remove-overflow
>  - Add grid role to tables
>  - ... and 32 more: https://git.openjdk.org/jdk/compare/a6fa4c6a...8748de2a

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Table.java line 341:

> 339:                 cell.addStyle(tabClass);
> 340:                 if (!matchFound) {
> 341:                     cell.put(HtmlAttr.ROLE, "row")

We now use [CSS Grid layout](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_grid_layout) for tables. Unfortunately, this implies that we do not have HTML elements representing rows. Tables are represented by an unstructured stream of table cells. This means that [`role="cell"`](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/cell_role) would probably be the right attribute to use here.

Once [Subgrid](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout/Subgrid) is well enough supported in browsers (which may be soon), we will be able to introduce elements representing table rows.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17819#discussion_r1643053878

From prappo at openjdk.org  Mon Jun 17 16:13:22 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Mon, 17 Jun 2024 16:13:22 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v2]
In-Reply-To: <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
Message-ID: <RTjSNwD8QdGnOLmYrNiGfAEKH01zBYqgAueQtuxeel4=.f76bc6f7-c04e-4c9e-84dc-491e36dfd133@github.com>

On Sat, 15 Jun 2024 09:54:38 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>>   Test `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root.
>>   Why run the jtreg test by root user? It's because during rpmbuild process for linux distribution of JDK, root user is the default user to build the openjdk, also is the default user to run the `make test-tier1`, this PR make this testcase more robustness.
>>   The change has been verified, only change the testcase, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   delete an extra whitespace

Come to think of it, there's already a mechanism in the test to skip a Windows machine if a directory cannot be made read-only. We could combine that mechanism with what you propose, simplifying and making code more robust at the same time.

Any time when we do `throw error`, it means that the test should be skipped. Cannot create a directory? Cannot make it read-only? Can write to a directory after having made it read-only? In any of these cases, our assumptions are invalid; the test should be skipped, not failed. So perhaps we could modify it like this?


diff --git a/test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java b/test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java
index 9127cdf86bb..fb01707511a 100644
--- a/test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java
+++ b/test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016, 2022, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2016, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -25,7 +25,7 @@
  * @test
  * @bug 8164130
  * @summary test IOException handling
- * @library ../../lib
+ * @library ../../lib /test/lib
  * @modules jdk.javadoc/jdk.javadoc.internal.tool
  * @build javadoc.tester.*
  * @run main TestIOException
@@ -61,16 +61,13 @@ public static void main(String... args) throws Exception {
     public void testReadOnlyDirectory() {
         File outDir = new File("out1");
         if (!outDir.mkdir()) {
-            throw error(outDir, "Cannot create directory");
+            throw skip(outDir, "Cannot create directory");
         }
         if (!outDir.setReadOnly()) {
-            if (skip(outDir)) {
-                return;
-            }
-            throw error(outDir, "could not set directory read-only");
+            throw skip(outDir, "could not set directory read-only");
         }
         if (outDir.canWrite()) {
-            throw error(outDir, "directory is writable");
+            throw skip(outDir, "directory is writable");
         }
 
         try {
@@ -93,15 +90,15 @@ public void testReadOnlyDirectory() {
     public void testReadOnlyFile() throws Exception {
         File outDir = new File("out2");
         if (!outDir.mkdir()) {
-            throw error(outDir, "Cannot create directory");
+            throw skip(outDir, "Cannot create directory");
         }
         File index = new File(outDir, "index.html");
         try (FileWriter fw = new FileWriter(index)) { }
         if (!index.setReadOnly()) {
-            throw error(index, "could not set index read-only");
+            throw skip(index, "could not set index read-only");
         }
         if (index.canWrite()) {
-            throw error(index, "index is writable");
+            throw skip(index, "index is writable");
         }
 
         try {
@@ -139,16 +136,13 @@ public void testReadOnlySubdirectory() throws Exception {
         File outDir = new File("out3");
         File pkgOutDir = new File(outDir, "p");
         if (!pkgOutDir.mkdirs()) {
-            throw error(pkgOutDir, "Cannot create directory");
+            throw skip(pkgOutDir, "Cannot create directory");
         }
         if (!pkgOutDir.setReadOnly()) {
-            if (skip(pkgOutDir)) {
-                return;
-            }
-            throw error(pkgOutDir, "could not set directory read-only");
+            throw skip(pkgOutDir, "could not set directory read-only");
         }
         if (pkgOutDir.canWrite()) {
-            throw error(pkgOutDir, "directory is writable");
+            throw skip(pkgOutDir, "directory is writable");
         }
 
         // run javadoc and check results
@@ -192,16 +186,13 @@ public void testReadOnlyDocFilesDir() throws Exception {
         File pkgOutDir = new File(outDir, "p");
         File docFilesOutDir = new File(pkgOutDir, "doc-files");
         if (!docFilesOutDir.mkdirs()) {
-            throw error(docFilesOutDir, "Cannot create directory");
+            throw skip(docFilesOutDir, "Cannot create directory");
         }
         if (!docFilesOutDir.setReadOnly()) {
-            if (skip(docFilesOutDir)) {
-                return;
-            }
-            throw error(docFilesOutDir, "could not set directory read-only");
+            throw skip(docFilesOutDir, "could not set directory read-only");
         }
         if (docFilesOutDir.canWrite()) {
-            throw error(docFilesOutDir, "directory is writable");
+            throw skip(docFilesOutDir, "directory is writable");
         }
 
         try {
@@ -219,7 +210,8 @@ public void testReadOnlyDocFilesDir() throws Exception {
         }
     }
 
-    private Error error(File f, String message) {
+    private Error skip(File f, String message) {
+        out.print(System.getProperty("user.name"));
         out.println(f + ": " + message);
         showAllAttributes(f.toPath());
         throw new Error(f + ": " + message);
@@ -242,20 +234,5 @@ private void showAttributes(Path p, String attributes) {
             out.println("Error accessing attributes " + attributes + ": " + t);
         }
     }
-
-    private boolean skip(File dir) {
-        if (isWindows()) {
-            showAllAttributes(dir.toPath());
-            out.println("Windows: cannot set directory read only:" + dir);
-            out.println("TEST CASE SKIPPED");
-            return true;
-        } else {
-            return false;
-        }
-    }
-
-    private boolean isWindows() {
-        return System.getProperty("os.name").toLowerCase(Locale.US).startsWith("windows");
-    }
 }
 


This will work if people occasionally review the reasons why tests are skipped, not ignore skipped tests.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19731#issuecomment-2173808185

From syan at openjdk.org  Tue Jun 18 01:26:09 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 01:26:09 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v2]
In-Reply-To: <RTjSNwD8QdGnOLmYrNiGfAEKH01zBYqgAueQtuxeel4=.f76bc6f7-c04e-4c9e-84dc-491e36dfd133@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
 <RTjSNwD8QdGnOLmYrNiGfAEKH01zBYqgAueQtuxeel4=.f76bc6f7-c04e-4c9e-84dc-491e36dfd133@github.com>
Message-ID: <LHI9dbAx89q1Jv7izSFos9-oa8j8iDVF61L5KQ1NEEA=.934135ec-0201-4863-a766-da7593347613@github.com>

On Mon, 17 Jun 2024 16:10:08 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> -    private Error error(File f, String message) {
> +    private Error skip(File f, String message) {
> +        out.print(System.getProperty("user.name"));
>          out.println(f + ": " + message);
>          showAllAttributes(f.toPath());
>          throw new Error(f + ": " + message);
> @@ -242,20 +234,5 @@ private void showAttributes(Path p, String attributes) {
>              out.println("Error accessing attributes " + attributes + ": " + t);
>          }
>      }

Does the `throw new Error(f + ": " + message);` should replace to `throw new SkippedException(f + ": " + message);`, to avoid report failure if a directory cannot be made read-only.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19731#issuecomment-2174730568

From syan at openjdk.org  Tue Jun 18 01:29:08 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 01:29:08 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v2]
In-Reply-To: <RTjSNwD8QdGnOLmYrNiGfAEKH01zBYqgAueQtuxeel4=.f76bc6f7-c04e-4c9e-84dc-491e36dfd133@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
 <RTjSNwD8QdGnOLmYrNiGfAEKH01zBYqgAueQtuxeel4=.f76bc6f7-c04e-4c9e-84dc-491e36dfd133@github.com>
Message-ID: <4mi_aUbDh2catGHOlJNfIm013r31unAUdNpTlZqtQqE=.858fd4fa-7f27-49ba-b27d-7891053bd491@github.com>

On Mon, 17 Jun 2024 16:10:08 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> ```
> -    private Error error(File f, String message) {
> +    private Error skip(File f, String message) {
> +        out.print(System.getProperty("user.name"));
>          out.println(f + ": " + message);
>          showAllAttributes(f.toPath());
>          throw new Error(f + ": " + message);
> @@ -242,20 +234,5 @@ private void showAttributes(Path p, String attributes) {
>              out.println("Error accessing attributes " + attributes + ": " + t);
>          }
>      }
> ```

Does the `throw new Error(f + ": " + message);` should be replaced to `throw new SkippedException(f + ": " + message);`, to avoid report failure if a directory cannot be made read-only.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19731#issuecomment-2174732914

From aturbanov at openjdk.org  Tue Jun 18 06:22:11 2024
From: aturbanov at openjdk.org (Andrey Turbanov)
Date: Tue, 18 Jun 2024 06:22:11 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v2]
In-Reply-To: <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
Message-ID: <Q9fDnTYVYzWSc5dR9WvGQjlLd5oRMSWxOKsI6d1dgIE=.c5367817-4466-46d0-8623-8035df4f0567@github.com>

On Sat, 15 Jun 2024 09:54:38 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>>   Test `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root.
>>   Why run the jtreg test by root user? It's because during rpmbuild process for linux distribution of JDK, root user is the default user to build the openjdk, also is the default user to run the `make test-tier1`, this PR make this testcase more robustness.
>>   The change has been verified, only change the testcase, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   delete an extra whitespace

test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java line 56:

> 54:     public static void main(String... args) throws Exception {
> 55:         var tester = new TestIOException();
> 56:         if(Platform.isRoot() && !tester.isWindows()) {

Suggestion:

        if (Platform.isRoot() && !tester.isWindows()) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19731#discussion_r1643875959

From syan at openjdk.org  Tue Jun 18 06:40:30 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 06:40:30 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v3]
In-Reply-To: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
Message-ID: <_GRxDVQTDsX6aIXlWqUEP4J59nnM80ROND9pv9qrdHU=.b6d31bfb-711b-4ca8-9b12-715760387128@github.com>

> Hi all,
>   Test `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root.
>   Why run the jtreg test by root user? It's because during rpmbuild process for linux distribution of JDK, root user is the default user to build the openjdk, also is the default user to run the `make test-tier1`, this PR make this testcase more robustness.
>   The change has been verified, only change the testcase, no risk.

SendaoYan has updated the pull request incrementally with one additional commit since the last revision:

  throw error()  ->  throw skip()

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19731/files
  - new: https://git.openjdk.org/jdk/pull/19731/files/30916158..a9a770f2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19731&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19731&range=01-02

  Stats: 44 lines in 1 file changed: 1 ins; 29 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/19731.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19731/head:pull/19731

PR: https://git.openjdk.org/jdk/pull/19731

From syan at openjdk.org  Tue Jun 18 06:43:10 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 06:43:10 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v2]
In-Reply-To: <Q9fDnTYVYzWSc5dR9WvGQjlLd5oRMSWxOKsI6d1dgIE=.c5367817-4466-46d0-8623-8035df4f0567@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
 <Q9fDnTYVYzWSc5dR9WvGQjlLd5oRMSWxOKsI6d1dgIE=.c5367817-4466-46d0-8623-8035df4f0567@github.com>
Message-ID: <p53Wb_gI5_3kYluv3ej4yq8mzV9LVHcRI8FxuEn8GZ0=.204058b1-1953-4034-8109-11e3eed167ca@github.com>

On Tue, 18 Jun 2024 06:19:23 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   delete an extra whitespace
>
> test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java line 56:
> 
>> 54:     public static void main(String... args) throws Exception {
>> 55:         var tester = new TestIOException();
>> 56:         if(Platform.isRoot() && !tester.isWindows()) {
> 
> Suggestion:
> 
>         if (Platform.isRoot() && !tester.isWindows()) {

Thanks for the review. The code has been changed according to the review opinions of @pavelrappo.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19731#discussion_r1643905043

From syan at openjdk.org  Tue Jun 18 07:43:23 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 07:43:23 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v4]
In-Reply-To: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
Message-ID: <dD85CVD0_HUV3-hK-GaBtFB2OZiefIq73SuXj103PW8=.108d4e01-fc29-4e43-a023-af020151e17a@github.com>

> Hi all,
>   Test `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root.
>   Why run the jtreg test by root user? It's because during rpmbuild process for linux distribution of JDK, root user is the default user to build the openjdk, also is the default user to run the `make test-tier1`, this PR make this testcase more robustness.
>   The change has been verified, only change the testcase, no risk.
> 
> The change verified on:
> 
> - [x] linux
> - [x] windows

SendaoYan has updated the pull request incrementally with one additional commit since the last revision:

  add bug id 8334332 to jtreg tag @bug

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19731/files
  - new: https://git.openjdk.org/jdk/pull/19731/files/a9a770f2..92fc510a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19731&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19731&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19731.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19731/head:pull/19731

PR: https://git.openjdk.org/jdk/pull/19731

From prappo at openjdk.org  Tue Jun 18 08:35:10 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Tue, 18 Jun 2024 08:35:10 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v2]
In-Reply-To: <4mi_aUbDh2catGHOlJNfIm013r31unAUdNpTlZqtQqE=.858fd4fa-7f27-49ba-b27d-7891053bd491@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
 <RTjSNwD8QdGnOLmYrNiGfAEKH01zBYqgAueQtuxeel4=.f76bc6f7-c04e-4c9e-84dc-491e36dfd133@github.com>
 <4mi_aUbDh2catGHOlJNfIm013r31unAUdNpTlZqtQqE=.858fd4fa-7f27-49ba-b27d-7891053bd491@github.com>
Message-ID: <nQDc_ii6IJqe5jLqW2SeypkOgU6pIObuR3DghIKgb1g=.7cb40529-4bc5-417d-b826-acb224f1a022@github.com>

On Tue, 18 Jun 2024 01:26:33 GMT, SendaoYan <syan at openjdk.org> wrote:

> Does the `throw new Error(f + ": " + message);` should be replaced to `throw new SkippedException(f + ": " + message);`, to avoid report failure if a directory cannot be made read-only.

Yes, it does! That's the whole point. Ironically, I missed that in my diff.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19731#issuecomment-2175523628

From syan at openjdk.org  Tue Jun 18 08:52:16 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 08:52:16 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v2]
In-Reply-To: <nQDc_ii6IJqe5jLqW2SeypkOgU6pIObuR3DghIKgb1g=.7cb40529-4bc5-417d-b826-acb224f1a022@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <SGawdZ2M2obkt8QX_GBMy5PH5zS4-RGUxOjApNZj0Xk=.149bf6bf-4436-4075-abe4-8f70634b3b5c@github.com>
 <RTjSNwD8QdGnOLmYrNiGfAEKH01zBYqgAueQtuxeel4=.f76bc6f7-c04e-4c9e-84dc-491e36dfd133@github.com>
 <4mi_aUbDh2catGHOlJNfIm013r31unAUdNpTlZqtQqE=.858fd4fa-7f27-49ba-b27d-7891053bd491@github.com>
 <nQDc_ii6IJqe5jLqW2SeypkOgU6pIObuR3DghIKgb1g=.7cb40529-4bc5-417d-b826-acb224f1a022@github.com>
Message-ID: <2qVS6dmmMMzb_qH0buQw0qbB6kVk8oq-6ucCYgc1ewc=.634d24f2-92ad-4ce4-a9a4-8094adb668c4@github.com>

On Tue, 18 Jun 2024 08:32:43 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> > Does the `throw new Error(f + ": " + message);` should be replaced to `throw new SkippedException(f + ": " + message);`, to avoid report failure if a directory cannot be made read-only.
> 
> Yes, it does! That's the whole point. Ironically, I missed that in my diff.

Thanks your advice, the code has been updated according your advice, and has been verified on linux and windows.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19731#issuecomment-2175555950

From prappo at openjdk.org  Tue Jun 18 09:08:16 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Tue, 18 Jun 2024 09:08:16 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v4]
In-Reply-To: <dD85CVD0_HUV3-hK-GaBtFB2OZiefIq73SuXj103PW8=.108d4e01-fc29-4e43-a023-af020151e17a@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <dD85CVD0_HUV3-hK-GaBtFB2OZiefIq73SuXj103PW8=.108d4e01-fc29-4e43-a023-af020151e17a@github.com>
Message-ID: <EgpPEssmd0-hhyK1MAnXYgxW3B38sHNbv2rygGpwcfU=.11893803-52e9-472c-9168-85ce6b36bd18@github.com>

On Tue, 18 Jun 2024 07:43:23 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>>   Test `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root.
>>   Why run the jtreg test by root user? It's because during rpmbuild process for linux distribution of JDK, root user is the default user to build the openjdk, also is the default user to run the `make test-tier1`, this PR make this testcase more robustness.
>>   The change has been verified, only change the testcase, no risk.
>> 
>> The change verified on:
>> 
>> - [x] linux
>> - [x] windows
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add bug id 8334332 to jtreg tag @bug

I'm running it on our CI. If all is well, I'll approve and sponsor it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19731#issuecomment-2175588209

From prappo at openjdk.org  Tue Jun 18 10:16:11 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Tue, 18 Jun 2024 10:16:11 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v4]
In-Reply-To: <dD85CVD0_HUV3-hK-GaBtFB2OZiefIq73SuXj103PW8=.108d4e01-fc29-4e43-a023-af020151e17a@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <dD85CVD0_HUV3-hK-GaBtFB2OZiefIq73SuXj103PW8=.108d4e01-fc29-4e43-a023-af020151e17a@github.com>
Message-ID: <1q88j_e0lYQ8jdjOuVSnfE_rjML7qjIzwAO41rp-tVQ=.c28e2c4c-c380-41b5-8dfa-13a3182cafdd@github.com>

On Tue, 18 Jun 2024 07:43:23 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>>   Test `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root.
>>   Why run the jtreg test by root user? It's because during rpmbuild process for linux distribution of JDK, root user is the default user to build the openjdk, also is the default user to run the `make test-tier1`, this PR make this testcase more robustness.
>>   The change has been verified, only change the testcase, no risk.
>> 
>> The change verified on:
>> 
>> - [x] linux
>> - [x] windows
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add bug id 8334332 to jtreg tag @bug

Marked as reviewed by prappo (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19731#pullrequestreview-2125100221

From syan at openjdk.org  Tue Jun 18 10:21:11 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 10:21:11 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v4]
In-Reply-To: <dD85CVD0_HUV3-hK-GaBtFB2OZiefIq73SuXj103PW8=.108d4e01-fc29-4e43-a023-af020151e17a@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <dD85CVD0_HUV3-hK-GaBtFB2OZiefIq73SuXj103PW8=.108d4e01-fc29-4e43-a023-af020151e17a@github.com>
Message-ID: <Vh8FsJdLQH53OAmrT_S32V4-CGfcYMlCt5iM12GQkUk=.e1c15ad1-a5f1-4e02-8629-f303bba20ab0@github.com>

On Tue, 18 Jun 2024 07:43:23 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>>   Test `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root.
>>   Why run the jtreg test by root user? It's because during rpmbuild process for linux distribution of JDK, root user is the default user to build the openjdk, also is the default user to run the `make test-tier1`, this PR make this testcase more robustness.
>>   The change has been verified, only change the testcase, no risk.
>> 
>> The change verified on:
>> 
>> - [x] linux
>> - [x] windows
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add bug id 8334332 to jtreg tag @bug

Thanks all for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19731#issuecomment-2175740002

From syan at openjdk.org  Tue Jun 18 10:27:19 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 10:27:19 GMT
Subject: Integrated: 8334332: TestIOException.java fails if run by root
In-Reply-To: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
Message-ID: <Vnq63abdyiIRcXX0dGE_0P3bwtFCjt0gq30DlzY7Toc=.335af031-9a06-428a-95ec-edd5926ca6c8@github.com>

On Sat, 15 Jun 2024 09:07:04 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
>   Test `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root.
>   Why run the jtreg test by root user? It's because during rpmbuild process for linux distribution of JDK, root user is the default user to build the openjdk, also is the default user to run the `make test-tier1`, this PR make this testcase more robustness.
>   The change has been verified, only change the testcase, no risk.
> 
> The change verified on:
> 
> - [x] linux
> - [x] windows

This pull request has now been integrated.

Changeset: 472b935b
Author:    SendaoYan <syan at openjdk.org>
Committer: Pavel Rappo <prappo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b
Stats:     43 lines in 1 file changed: 2 ins; 24 del; 17 mod

8334332: TestIOException.java fails if run by root

Reviewed-by: prappo

-------------

PR: https://git.openjdk.org/jdk/pull/19731

From syan at openjdk.org  Tue Jun 18 11:03:19 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 11:03:19 GMT
Subject: RFR: 8334332: TestIOException.java fails if run by root [v4]
In-Reply-To: <dD85CVD0_HUV3-hK-GaBtFB2OZiefIq73SuXj103PW8=.108d4e01-fc29-4e43-a023-af020151e17a@github.com>
References: <miW57A5ghtpgOlcrl1lTl5Me7mR8n6GJaycb1yNurvQ=.de73cfb4-297e-4f55-9939-18c6af59a8df@github.com>
 <dD85CVD0_HUV3-hK-GaBtFB2OZiefIq73SuXj103PW8=.108d4e01-fc29-4e43-a023-af020151e17a@github.com>
Message-ID: <ZvFxzhBb7JOq84DcnBs0v9bA1upwH5ZUqxmroHvM-h8=.e99007b8-cb11-47ef-b2c3-10eee8e558aa@github.com>

On Tue, 18 Jun 2024 07:43:23 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>>   Test `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run fails with root user privileged. I think it's necessary to skip this testcase when user is root.
>>   Why run the jtreg test by root user? It's because during rpmbuild process for linux distribution of JDK, root user is the default user to build the openjdk, also is the default user to run the `make test-tier1`, this PR make this testcase more robustness.
>>   The change has been verified, only change the testcase, no risk.
>> 
>> The change verified on:
>> 
>> - [x] linux
>> - [x] windows
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add bug id 8334332 to jtreg tag @bug

Thanks for the sponsor.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19731#issuecomment-2175822381

From syan at openjdk.org  Tue Jun 18 11:17:24 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 11:17:24 GMT
Subject: [jdk23] RFR: 8334332: TestIOException.java fails if run by root
Message-ID: <dPijzs-q7SQn-bWobUxNXhLoZdyS9fQZtvXoKl5f6Rk=.1b6f0a77-1d62-4afc-a81f-df21490d2690@github.com>

Hi all,

This pull request contains a backport of commit [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by SendaoYan on 18 Jun 2024 and was reviewed by Pavel Rappo.

Only change test testcase, no risk.

Thanks!

-------------

Commit messages:
 - Backport 472b935b442f7f925b665c7de91eda77f3dcbe8b

Changes: https://git.openjdk.org/jdk/pull/19765/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19765&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8334332
  Stats: 43 lines in 1 file changed: 2 ins; 24 del; 17 mod
  Patch: https://git.openjdk.org/jdk/pull/19765.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19765/head:pull/19765

PR: https://git.openjdk.org/jdk/pull/19765

From prappo at openjdk.org  Tue Jun 18 11:21:14 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Tue, 18 Jun 2024 11:21:14 GMT
Subject: [jdk23] RFR: 8334332: TestIOException.java fails if run by root
In-Reply-To: <dPijzs-q7SQn-bWobUxNXhLoZdyS9fQZtvXoKl5f6Rk=.1b6f0a77-1d62-4afc-a81f-df21490d2690@github.com>
References: <dPijzs-q7SQn-bWobUxNXhLoZdyS9fQZtvXoKl5f6Rk=.1b6f0a77-1d62-4afc-a81f-df21490d2690@github.com>
Message-ID: <kkH0kR1D6zT6n1tvJJzjZUC8jND9nHmT9z3wvXuDoRU=.006b0b8b-1f51-4933-b39e-455dcb18ead5@github.com>

On Tue, 18 Jun 2024 11:12:41 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by SendaoYan on 18 Jun 2024 and was reviewed by Pavel Rappo.
> 
> Only change test testcase, no risk.
> 
> Thanks!

Marked as reviewed by prappo (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19765#pullrequestreview-2125224767

From syan at openjdk.org  Tue Jun 18 12:45:22 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 12:45:22 GMT
Subject: [jdk23] RFR: 8334332: TestIOException.java fails if run by root
In-Reply-To: <dPijzs-q7SQn-bWobUxNXhLoZdyS9fQZtvXoKl5f6Rk=.1b6f0a77-1d62-4afc-a81f-df21490d2690@github.com>
References: <dPijzs-q7SQn-bWobUxNXhLoZdyS9fQZtvXoKl5f6Rk=.1b6f0a77-1d62-4afc-a81f-df21490d2690@github.com>
Message-ID: <4BMF2qorgss3lD5GZXStraMFiaW4VUzvwHI1nLwyASE=.54f18699-3c42-42a7-9dc7-ba595d05a2e1@github.com>

On Tue, 18 Jun 2024 11:12:41 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by SendaoYan on 18 Jun 2024 and was reviewed by Pavel Rappo.
> 
> Only change test testcase, no risk.
> 
> Thanks!

Thanks for the approved.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19765#issuecomment-2176008628

From syan at openjdk.org  Tue Jun 18 13:16:18 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 13:16:18 GMT
Subject: [jdk23] Integrated: 8334332: TestIOException.java fails if run by root
In-Reply-To: <dPijzs-q7SQn-bWobUxNXhLoZdyS9fQZtvXoKl5f6Rk=.1b6f0a77-1d62-4afc-a81f-df21490d2690@github.com>
References: <dPijzs-q7SQn-bWobUxNXhLoZdyS9fQZtvXoKl5f6Rk=.1b6f0a77-1d62-4afc-a81f-df21490d2690@github.com>
Message-ID: <OBC-XFatK-lWQc51D0vg1egHi9OMdaTaKH9kYmtszes=.8614726e-4e5e-4c51-beb5-4761ad942437@github.com>

On Tue, 18 Jun 2024 11:12:41 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by SendaoYan on 18 Jun 2024 and was reviewed by Pavel Rappo.
> 
> Only change test testcase, no risk.
> 
> Thanks!

This pull request has now been integrated.

Changeset: 867312a7
Author:    SendaoYan <syan at openjdk.org>
Committer: Pavel Rappo <prappo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/867312a7e54e205d48a954e54a09ce7e62a99e51
Stats:     43 lines in 1 file changed: 2 ins; 24 del; 17 mod

8334332: TestIOException.java fails if run by root

Reviewed-by: prappo
Backport-of: 472b935b442f7f925b665c7de91eda77f3dcbe8b

-------------

PR: https://git.openjdk.org/jdk/pull/19765

From syan at openjdk.org  Tue Jun 18 16:06:16 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 18 Jun 2024 16:06:16 GMT
Subject: [jdk23] RFR: 8334332: TestIOException.java fails if run by root
In-Reply-To: <dPijzs-q7SQn-bWobUxNXhLoZdyS9fQZtvXoKl5f6Rk=.1b6f0a77-1d62-4afc-a81f-df21490d2690@github.com>
References: <dPijzs-q7SQn-bWobUxNXhLoZdyS9fQZtvXoKl5f6Rk=.1b6f0a77-1d62-4afc-a81f-df21490d2690@github.com>
Message-ID: <GsL6v3GM461UFPdJxZn4EcG2Fvsmo5Y7-KudBbsJ4GU=.0800cfea-9421-4e04-8d07-a7c4eb91b3ca@github.com>

On Tue, 18 Jun 2024 11:12:41 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by SendaoYan on 18 Jun 2024 and was reviewed by Pavel Rappo.
> 
> Only change test testcase, no risk.
> 
> Thanks!

Thanks for the sponsor.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19765#issuecomment-2176464404

From jjg at openjdk.org  Tue Jun 18 20:53:11 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Tue, 18 Jun 2024 20:53:11 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v5]
In-Reply-To: <FKdfLlnKRGOL90leHOG0kwHPI8XM6WVxPaaPx3nIUow=.9f547095-b55a-46dc-b473-a2dab5a068db@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <FKdfLlnKRGOL90leHOG0kwHPI8XM6WVxPaaPx3nIUow=.9f547095-b55a-46dc-b473-a2dab5a068db@github.com>
Message-ID: <9o4f5NZbTQZZ2ksubTpuANbNQnfkntiVuVEJhto9pcY=.c9f6bddf-0acc-4712-b06a-575f628199ea@github.com>

On Fri, 14 Jun 2024 19:16:26 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   whitespace

This is good for now.

We might want to work on this more as part of the general evolution for HTML support and DocLint support in JavaDoc.

-------------

Marked as reviewed by jjg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19652#pullrequestreview-2126467283

From jjg at openjdk.org  Tue Jun 18 20:53:12 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Tue, 18 Jun 2024 20:53:12 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v5]
In-Reply-To: <Xyo3VgC_wbWGTWzZSAJztf8udTyVyK8bKDFbvkwmSP0=.df3c2ca4-8c08-4a8c-8098-1b0824656689@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <rEZoiFjDtz0xXEKG1oAdwDi94PuNVrBe9QXaMk0_CCM=.8a1a9ffa-d228-47ed-806a-45e07a5712a4@github.com>
 <Xyo3VgC_wbWGTWzZSAJztf8udTyVyK8bKDFbvkwmSP0=.df3c2ca4-8c08-4a8c-8098-1b0824656689@github.com>
Message-ID: <kcZ_UO7fYxSH_PCm6mgaZDo6A-gCikoeEj1ZV6FWWEs=.bd081be8-5a8c-4186-99b1-be7eac945bab@github.com>

On Fri, 14 Jun 2024 02:32:16 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   whitespace
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line 695:
> 
>> 693:             // custom "data-*" attributes are also accepted
>> 694:             var attrName = name.toString();
>> 695:             if (!attrName.startsWith("on") && !attrName.startsWith("data-")) {
> 
> I've removed the regex here.

the regex wasn't awful, but ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1645038019

From nbenalla at openjdk.org  Wed Jun 19 09:59:26 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Wed, 19 Jun 2024 09:59:26 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v6]
In-Reply-To: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
Message-ID: <nRhMzjRi9_oHNKaBVPy71PB9Tzg0q4BHWFHB0svQm4g=.f9f9af69-b45e-494f-a911-1123343cc0e5@github.com>

> Can I please get a review for this change, that aims to add support for Global HTML tags.
> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
> Thanks in advance.

Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:

 - Merge branch 'master' into html-attributes
 - whitespace
 - Simplify method
 - Null safety
 - Merge branch 'master' into html-attributes
 - remove trailing whitespace
 - -Add a boolean attribute to the enum type
   -Simply regex in `visitAttribute`
   -Simplified the Test
   -Added a negative test
 - no longer print summary
 - no longer print summary
 - Add small comment
 - ... and 2 more: https://git.openjdk.org/jdk/compare/3c7fc2c1...aa2f2d89

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19652/files
  - new: https://git.openjdk.org/jdk/pull/19652/files/cfde660d..aa2f2d89

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19652&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19652&range=04-05

  Stats: 4481 lines in 190 files changed: 2834 ins; 1063 del; 584 mod
  Patch: https://git.openjdk.org/jdk/pull/19652.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19652/head:pull/19652

PR: https://git.openjdk.org/jdk/pull/19652

From nbenalla at openjdk.org  Thu Jun 20 10:14:16 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Thu, 20 Jun 2024 10:14:16 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v6]
In-Reply-To: <nRhMzjRi9_oHNKaBVPy71PB9Tzg0q4BHWFHB0svQm4g=.f9f9af69-b45e-494f-a911-1123343cc0e5@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <nRhMzjRi9_oHNKaBVPy71PB9Tzg0q4BHWFHB0svQm4g=.f9f9af69-b45e-494f-a911-1123343cc0e5@github.com>
Message-ID: <WtSj_2qZz2_fIVctXMoFFBixYyhlKI_lwE4HJYexwZo=.c466c94c-3875-4d5a-9ef1-7b2d30ad8aac@github.com>

On Wed, 19 Jun 2024 09:59:26 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
> 
>  - Merge branch 'master' into html-attributes
>  - whitespace
>  - Simplify method
>  - Null safety
>  - Merge branch 'master' into html-attributes
>  - remove trailing whitespace
>  - -Add a boolean attribute to the enum type
>    -Simply regex in `visitAttribute`
>    -Simplified the Test
>    -Added a negative test
>  - no longer print summary
>  - no longer print summary
>  - Add small comment
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/c8be277e...aa2f2d89

Passes tier 1-3, I'll backport this once it's merged

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19652#issuecomment-2180311303

From liach at openjdk.org  Thu Jun 20 11:55:19 2024
From: liach at openjdk.org (Chen Liang)
Date: Thu, 20 Jun 2024 11:55:19 GMT
Subject: RFR: 8322708: Global HTML attributes are not allowed [v6]
In-Reply-To: <nRhMzjRi9_oHNKaBVPy71PB9Tzg0q4BHWFHB0svQm4g=.f9f9af69-b45e-494f-a911-1123343cc0e5@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
 <nRhMzjRi9_oHNKaBVPy71PB9Tzg0q4BHWFHB0svQm4g=.f9f9af69-b45e-494f-a911-1123343cc0e5@github.com>
Message-ID: <wQlR4UB79rk4iPJs21-1cXvZalGWVrCa0sF-OyYkNwg=.2441f771-c376-4c5f-adfd-81d88a5651b3@github.com>

On Wed, 19 Jun 2024 09:59:26 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
> 
>  - Merge branch 'master' into html-attributes
>  - whitespace
>  - Simplify method
>  - Null safety
>  - Merge branch 'master' into html-attributes
>  - remove trailing whitespace
>  - -Add a boolean attribute to the enum type
>    -Simply regex in `visitAttribute`
>    -Simplified the Test
>    -Added a negative test
>  - no longer print summary
>  - no longer print summary
>  - Add small comment
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/2e62e2ca...aa2f2d89

Thanks Nizar!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19652#issuecomment-2180485455

From nbenalla at openjdk.org  Thu Jun 20 11:55:20 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Thu, 20 Jun 2024 11:55:20 GMT
Subject: Integrated: 8322708: Global HTML attributes are not allowed
In-Reply-To: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
References: <TqJ_wGe-eyTF4QJcM3o8KoSuj8QIP49DxjAr4SuFjDk=.75848b3e-6a26-4bf1-833e-5ad5f823a602@github.com>
Message-ID: <2kcsdKfYH9vDXrmwRaHiR2B83q0nL8nGoH91TpYClcU=.6a7e5916-3cd5-4d5c-a10d-5e48e75a571e@github.com>

On Tue, 11 Jun 2024 11:37:27 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> Can I please get a review for this change, that aims to add support for Global HTML tags.
> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) to the generated docs.
> Thanks in advance.

This pull request has now been integrated.

Changeset: 5cad0b4d
Author:    Nizar Benalla <nbenalla at openjdk.org>
Committer: Chen Liang <liach at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5cad0b4df7f5ccb6d462dc948c2ea5ad5da6e2ed
Stats:     262 lines in 4 files changed: 238 ins; 2 del; 22 mod

8322708: Global HTML attributes are not allowed

Reviewed-by: jjg

-------------

PR: https://git.openjdk.org/jdk/pull/19652

From nbenalla at openjdk.org  Thu Jun 20 12:40:25 2024
From: nbenalla at openjdk.org (Nizar Benalla)
Date: Thu, 20 Jun 2024 12:40:25 GMT
Subject: [jdk23] RFR: 8322708: Global HTML attributes are not allowed
Message-ID: <AZBVe8Z8hYy6aVG7Hxo8TAleXmNsJhRl-F6jX5JlYso=.cf8c3fb0-b54f-413b-97ac-d071277776cd@github.com>

This is a clean backport of #19652 and commit 5cad0b4df7f5ccb6d462dc948c2ea5ad5da6e2ed. Allowing the use of global HTML attributes in javadoc.

I used the `/backport` command but also manually created a backport of the issue in JBS, I hope that's fine.

-------------

Commit messages:
 - Backport 5cad0b4df7f5ccb6d462dc948c2ea5ad5da6e2ed

Changes: https://git.openjdk.org/jdk/pull/19805/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19805&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8322708
  Stats: 262 lines in 4 files changed: 238 ins; 2 del; 22 mod
  Patch: https://git.openjdk.org/jdk/pull/19805.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19805/head:pull/19805

PR: https://git.openjdk.org/jdk/pull/19805

From kcr at openjdk.org  Thu Jun 20 13:45:14 2024
From: kcr at openjdk.org (Kevin Rushforth)
Date: Thu, 20 Jun 2024 13:45:14 GMT
Subject: [jdk23] RFR: 8322708: Global HTML attributes are not allowed
In-Reply-To: <AZBVe8Z8hYy6aVG7Hxo8TAleXmNsJhRl-F6jX5JlYso=.cf8c3fb0-b54f-413b-97ac-d071277776cd@github.com>
References: <AZBVe8Z8hYy6aVG7Hxo8TAleXmNsJhRl-F6jX5JlYso=.cf8c3fb0-b54f-413b-97ac-d071277776cd@github.com>
Message-ID: <pBeTTp8OKOYIzpTzesyBK7dUjqdswm8S4Kl5xp4KVTM=.57ddfa2b-5dd5-40e0-9d3b-6b41e2dd8044@github.com>

On Thu, 20 Jun 2024 12:22:14 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> This is a clean backport of #19652 and commit 5cad0b4df7f5ccb6d462dc948c2ea5ad5da6e2ed. Allowing the use of global HTML attributes in javadoc.
> 
> I used the `/backport` command but also manually created a backport of the issue in JBS, I hope that's fine.

@nizarbenalla In order to backport this enhancement request to JDK 23, you will need approval for a late enhancement as described in the ["Late-Enhancement Request Process" of JEP 3](https://openjdk.org/jeps/3#Late-Enhancement-Request-Process). This is in addition to this PR needing a review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19805#issuecomment-2180740250

From duke at openjdk.org  Mon Jun 24 06:20:36 2024
From: duke at openjdk.org (psoujany)
Date: Mon, 24 Jun 2024 06:20:36 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v39]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <tnNoSywU_2xqmhqxX9QrLAd2iPNZm85zOMLy1S3bSSU=.0fcb0b2d-51f5-4a75-9be6-285420cd7b88@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 43 additional commits since the last revision:

 - Merge branch 'openjdk:master' into remove-overflow
 - Merge branch 'openjdk:master' into remove-overflow
 - Add table role to summary tables
 - Add table role to summary tables
 - Add table role to summary tables
 - Add table role to summary tables
 - Add grid role to tables
 - Add grid role to tables
 - Merge branch 'remove-overflow' of github.com:psoujany/jdk into remove-overflow
 - Merge branch 'openjdk:master' into remove-overflow
 - ... and 33 more: https://git.openjdk.org/jdk/compare/1e6413e2...6641c9b8

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/8748de2a..6641c9b8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=38
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=37-38

  Stats: 21756 lines in 384 files changed: 14442 ins; 5298 del; 2016 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Mon Jun 24 06:50:24 2024
From: duke at openjdk.org (psoujany)
Date: Mon, 24 Jun 2024 06:50:24 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v40]
In-Reply-To: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
Message-ID: <1aazLpeoPZVwwFpXwQW-h0Msx4yWzwy8iguKuAmZ0Hk=.7531d0fe-6d7c-445f-9af7-49ae9d3853f8@github.com>

> The scrollable element `<div>` with non-interactive content is not tabbable. Grid columns in the javadoc stylesheet has overflow: auto, which is failing Accessibility checks.
> https://bugs.openjdk.org/browse/JDK-8325690

psoujany has updated the pull request incrementally with one additional commit since the last revision:

  Add tabindex to all rows of table

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17819/files
  - new: https://git.openjdk.org/jdk/pull/17819/files/6641c9b8..32092858

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=39
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17819&range=38-39

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17819.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17819/head:pull/17819

PR: https://git.openjdk.org/jdk/pull/17819

From duke at openjdk.org  Mon Jun 24 08:07:19 2024
From: duke at openjdk.org (psoujany)
Date: Mon, 24 Jun 2024 08:07:19 GMT
Subject: RFR: 8325690: The scrollable element <div> with non-interactive
 content is not tabbable [v38]
In-Reply-To: <z1W9jH4YokSVtPJV9DhODZQPk4o1dLzE78sy2Gb4_Ow=.0d48c090-cf94-4499-a1d1-c54cbaf459fd@github.com>
References: <sOfcWV4OU4T7B3MdgQV4KPza-Nn9ebkg9lnyE0OWhVE=.1f1acdc1-e379-44ea-8650-8cfdceba61ec@github.com>
 <7e4UpHxLogkFEskNHg_ULDAV5b2HzOE0yZSxUUbQeNA=.c2d9be91-18d5-4ff2-8580-587bd7a260ae@github.com>
 <z1W9jH4YokSVtPJV9DhODZQPk4o1dLzE78sy2Gb4_Ow=.0d48c090-cf94-4499-a1d1-c54cbaf459fd@github.com>
Message-ID: <Qg98RWgkPi0BSByBC7hPT-tKyHRG3z_YNpHz2P9Wxt0=.9f7d5970-3a83-441f-b07a-8069b6327078@github.com>

On Mon, 17 Jun 2024 16:03:45 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

>> psoujany has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 42 additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into remove-overflow
>>  - Add table role to summary tables
>>  - Add table role to summary tables
>>  - Add table role to summary tables
>>  - Add table role to summary tables
>>  - Add grid role to tables
>>  - Add grid role to tables
>>  - Merge branch 'remove-overflow' of github.com:psoujany/jdk into remove-overflow
>>  - Merge branch 'openjdk:master' into remove-overflow
>>  - Add grid role to tables
>>  - ... and 32 more: https://git.openjdk.org/jdk/compare/a7901e0a...8748de2a
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Table.java line 341:
> 
>> 339:                 cell.addStyle(tabClass);
>> 340:                 if (!matchFound) {
>> 341:                     cell.put(HtmlAttr.ROLE, "row")
> 
> We now use [CSS Grid layout](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_grid_layout) for tables. Unfortunately, this implies that we do not have HTML elements representing rows. Tables are represented by an unstructured stream of table cells. This means that [`role="cell"`](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/cell_role) would probably be the right attribute to use here.
> 
> Once [Subgrid](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout/Subgrid) is well enough supported in browsers (which may be soon), we will be able to introduce elements representing table rows.

@hns [role="cell"](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/cell_role) should be used within row element. But the code here has row styles as `col-first even-row-color` and `col-last even-row-color` and also tabindex should be added to only widget role i.e, `role="row"`. In order to add `role="cell"` and `role="row"` ARIA elements then we have to restructure the existing code. Could you please suggest here.

**Current code generates docs as :**

<div class="col-first odd-row-color" role="row" tabindex="0">&nbsp;</div>
<div class="col-last odd-row-color"><a href="some link">Some Link</a></div>
</div>


**To add roles row and cell, docs to be generated as :**

<div class="col-first" role="row">
<div class="odd-row-color" role="cell"><a href="someLink">SomeLink</a></div>
</div>
<div class="col-last" role="row" tabindex="0">
<div class="odd-row-color" role="cell">&nbsp;</div>
</div>

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17819#discussion_r1650533784

From jjg at openjdk.org  Tue Jun 25 22:48:10 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Tue, 25 Jun 2024 22:48:10 GMT
Subject: RFR: 8334241: Adjust API docs side bar dimensions
In-Reply-To: <oTuJsLsNk_Bon-Sk9pAhETgkWUcIFOD7Rg8y7qM2EGw=.00b88f38-c034-414b-b3c5-baeccc7fe350@github.com>
References: <oTuJsLsNk_Bon-Sk9pAhETgkWUcIFOD7Rg8y7qM2EGw=.00b88f38-c034-414b-b3c5-baeccc7fe350@github.com>
Message-ID: <Mhs9XO5ImzAMGML3iV4dGk9R24iPeYYDI42tRJk-IFU=.2f62f2e8-3027-4290-bac4-05a423b73f8c@github.com>

On Fri, 14 Jun 2024 16:35:54 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a change to slightly adjust the proportion between the side bar and the main content area in API documentation pages, making the side bar a bit slimmer and leaving more space for the main content area. The ratio between side bar and main content used to be 1 : 2.6, it is now 1 : 3. 
> 
> Updated API documentation[ can be viewed here](https://cr.openjdk.org/~hannesw/8334241/api.00/java.base/java/lang/Object.html).

One of these days, I think that maybe the boundary should be adjustable, although there is a definite sense of "deja vu" for that (looking back at Frames)

-------------

Marked as reviewed by jjg (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19726#pullrequestreview-2140009090

From hannesw at openjdk.org  Wed Jun 26 09:40:14 2024
From: hannesw at openjdk.org (Hannes =?UTF-8?B?V2FsbG7DtmZlcg==?=)
Date: Wed, 26 Jun 2024 09:40:14 GMT
Subject: Integrated: 8334241: Adjust API docs side bar dimensions
In-Reply-To: <oTuJsLsNk_Bon-Sk9pAhETgkWUcIFOD7Rg8y7qM2EGw=.00b88f38-c034-414b-b3c5-baeccc7fe350@github.com>
References: <oTuJsLsNk_Bon-Sk9pAhETgkWUcIFOD7Rg8y7qM2EGw=.00b88f38-c034-414b-b3c5-baeccc7fe350@github.com>
Message-ID: <dq16jWUp5HI5qI7MGIGeAUgxn555UlSbDFUmJ-7rwkE=.6a83bb81-2c0b-4219-b9e0-126879f7e4e3@github.com>

On Fri, 14 Jun 2024 16:35:54 GMT, Hannes Walln?fer <hannesw at openjdk.org> wrote:

> Please review a change to slightly adjust the proportion between the side bar and the main content area in API documentation pages, making the side bar a bit slimmer and leaving more space for the main content area. The ratio between side bar and main content used to be 1 : 2.6, it is now 1 : 3. 
> 
> Updated API documentation[ can be viewed here](https://cr.openjdk.org/~hannesw/8334241/api.00/java.base/java/lang/Object.html).

This pull request has now been integrated.

Changeset: 741a0f39
Author:    Hannes Walln?fer <hannesw at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/741a0f39dd1fffc1caaa8d69bfe3662dad830452
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8334241: Adjust API docs side bar dimensions

Reviewed-by: jjg

-------------

PR: https://git.openjdk.org/jdk/pull/19726

From kcr at openjdk.org  Fri Jun 28 15:35:23 2024
From: kcr at openjdk.org (Kevin Rushforth)
Date: Fri, 28 Jun 2024 15:35:23 GMT
Subject: [jdk23] RFR: 8322708: Global HTML attributes are not allowed
In-Reply-To: <AZBVe8Z8hYy6aVG7Hxo8TAleXmNsJhRl-F6jX5JlYso=.cf8c3fb0-b54f-413b-97ac-d071277776cd@github.com>
References: <AZBVe8Z8hYy6aVG7Hxo8TAleXmNsJhRl-F6jX5JlYso=.cf8c3fb0-b54f-413b-97ac-d071277776cd@github.com>
Message-ID: <-Q4dG3BVrGq57nN0RffZKivdcYVx8Zycpzir5PaLtiw=.2c74c23e-9796-42c9-9cb2-31c9aadddc8e@github.com>

On Thu, 20 Jun 2024 12:22:14 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

> This is a clean backport of #19652 and commit 5cad0b4df7f5ccb6d462dc948c2ea5ad5da6e2ed. Allowing the use of global HTML attributes in javadoc.
> 
> I used the `/backport` command but also manually created a backport of the issue in JBS, I hope that's fine.

Since the JBS issue was determined to be a Bug rather than an Enhancement, no additional process is needed to integrate this backport. It now is just waiting for a code review. I note that @jonathan-gibbons reviewed the original mainline fix, so perhaps he would be willing to review this backport.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19805#issuecomment-2197188020

From michael.osipov at innomotics.com  Fri Jun  7 12:16:28 2024
From: michael.osipov at innomotics.com (Osipov, Michael (IN IT IN))
Date: Fri, 07 Jun 2024 12:16:28 -0000
Subject: [External] : Re: Missing element-list for
 https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec
In-Reply-To: <94c6cf1c-21f3-4fb6-9c5a-4bd6cada8e4b@oracle.com>
References: <5947f22d-0c8d-4063-b721-42b7dd44ba4c@siemens.com>
 <47A81E8E-1DFB-4CE1-A465-7FDE83F183DA@oracle.com>
 <d93a2dfe-50b8-4fe3-a680-cdad8aef4b81@oracle.com>
 <PAVPR10MB7035701A19D9F217B471B27C8AF92@PAVPR10MB7035.EURPRD10.PROD.OUTLOOK.COM>
 <94c6cf1c-21f3-4fb6-9c5a-4bd6cada8e4b@oracle.com>
Message-ID: <703d209f-db1f-46bf-9315-1cd75d6eb9da@siemens.com>

On 2024-06-07 01:11, Jonathan Gibbons wrote:
> 
> On 6/5/24 2:51 AM, Osipov, Michael wrote:
>> On 2024-05-31 21:38, Jonathan Gibbons wrote:
>>> Michael,
>>>
>>> There is no `element-list` file for any version of JDK before JDK 9.
>>> Before JDK 9, the appropriate information was in the `package-list`
>>> file. In JDK 9, with the introduction of modules, the format of the file
>>> was updated to include modules, and because this was an incompatible
>>> change, the file was renamed as well, to `element-list`.
>>>
>>> It is an annoying misconfiguration of `docs.oracle.com` that you are
>>> seeing `302 Moved Temporarily` instead of `404 Not Found` which would be
>>> a more semantically accurate response.
>>>
>>> That leaves the question of why whatever you were doing was looking for
>>> `element-list` in JDK 8. To answer that, we need more info, to determine
>>> whether it is just a command-line error on your part, or any error in
>>> the `javadoc` tool itself. What version of JDK and javadoc are you
>>> using; what external libraries were you referencing in `-link` or `-
>>> linkoffline` options; and what source level were you using, with either
>>> the `-source` or `--release` options?
>> John,
>>
>> thanks for the elaboration. Let me better clarify what happens.
>>
>> The code is question with a modification for you is available at:
>> https://urldefense.com/v3/__https://github.com/michael-o/ 
>> tomcatspnegoad/tree/javadoc-issue__;!!ACWV5N9M2RV99hQ! 
>> L6MibNz6g0M99jnVOo2O_Zs2vP8-4CM- 
>> NS4WNUmHmL5dB30i0qaSfDJBHW4S_bxjOhImERJfBWGpStJ6WrwE0WAva10xtV86PQ$ 
>>
>> Class net.sf.michaelo.tomcat.pac.asn1.AdIfRelevantAsn1Parser uses
>> com.sun.security.jgss.AuthorizationDataEntry and others use private Sun
>> classes which does not allow me to use -release for now, only -source.
>> The source is Java 8. When I run javadoc:javadoc with Zulu 8 all links
>> are generated successfully. Running Zulu 11 with extracted Javadoc call
>> (&"C:\Program Files\Zulu\zulu-11\bin\javadoc.exe" -verbose "@options"
>> "@packages") gives me no warning, even in verbose mode. It simply does
>> not link.
>> When trying Temurin 22.0.1 (&"C:\Temp\jdk-22.0.1+8\bin\javadoc.exe"
>> -verbose "@options" "@packages") it gives me:
>>> Warnung: URLhttps://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec/ 
>>> element-list wurde umgeleitet anhttps://docs.oracle.com/en/java/javase/22/ - Aktualisieren Sie die Befehlszeilenoptionen, um diese Warnung zu unterdr?cken.
>> That is the redirect. Either I am misunderstanding or I have hit an edge
>> case for public classes outside of the standard JDK (Java namespaces).
>> Here is the input to Javadoc (@options, @packages) if you cannot try
>> yourself:https://urldefense.com/v3/__https://gist.github.com/michael- 
>> o/212c6797b000914b9142f1f077b1d9df__;!!ACWV5N9M2RV99hQ! 
>> L6MibNz6g0M99jnVOo2O_Zs2vP8-4CM- 
>> NS4WNUmHmL5dB30i0qaSfDJBHW4S_bxjOhImERJfBWGpStJ6WrwE0WAva12c46QzhA$ 
>>
>> I have tried:
>>> Apache Maven 3.8.8 (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
>>> Maven home: C:\Entwicklung\Programme\apache-maven-3.8.8
>>> Java version: 11.0.18, vendor: Azul Systems, Inc., runtime: C:\Program Files\Zulu\zulu-11
>>> Default locale: de_DE, platform encoding: UTF-8
>>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>>> Apache Maven 3.8.8 (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
>>> Maven home: C:\Entwicklung\Programme\apache-maven-3.8.8
>>> Java version: 1.8.0_362, vendor: Azul Systems, Inc., runtime: C:\Program Files\Zulu\zulu-8\jre
>>> Default locale: de_DE, platform encoding: Cp1252
>>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>>> Apache Maven 3.8.8 (4c87b05d9aedce574290d1acc98575ed5eb6cd39)
>>> Maven home: C:\Entwicklung\Programme\apache-maven-3.8.8
>>> Java version: 22.0.1, vendor: Eclipse Adoptium, runtime: C:\Temp\jdk-22.0.1+8
>>> Default locale: de_DE, platform encoding: UTF-8
>>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>> Note: I have routed the Javadoc traffic through Fiddler and it clearly
>> following the misconfigured docs.oracle.com location:
>>> #	Result	Protocol	Host	URL	Body	Caching	Content-Type	Process	Comments	Custom	
>>> 10	302	HTTPS	docs.oracle.com	/javase/8/docs/jre/api/security/jgss/spec/element-list	1			javadoc:24660			
>>> #	Result	Protocol	Host	URL	Body	Caching	Content-Type	Process	Comments	Custom	
>>> 12	200	HTTPS	docs.oracle.com	/en/java/javase/22/	33 431	max-age=19052	text/html	javadoc:24660			
>> Regards,
>>
>> Michael
>>
>>
> 
> Michael,
> 
> I investigated a bit further, and I may have a solution for you.
> 
> The redirect is annoying, and sad to say, there is nothing I can do to 
> get it fixed in a timely manner.? But, I think you may be able to work 
> around it.? The answer is based on the content of the files in the gist 
> that you referenced in your message.
> 
> Look at these lines:
> 
> -link
> 'https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec'
> -linkoffline
> 'https://docs.oracle.com/javase/8/docs/api' 'C:/Entwicklung/ 
> workspace-2023-06/tomcatspnegoad/tomcat90/target/javadoc-bundle-options'
> 
> I'm not sure what is in your `javadoc-bundle-options` file, but it 
> *ought* to be a local copy of the `package-list` found here:
> https://docs.oracle.com/javase/8/docs/api/package-list
> 
> For the first option, the `-link` one, try changing it to:
> 
> -linkoffline
> 'https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec' / 
> path/to/file
> 
> where `/path/to/file` is a local copy of the file found here:
> https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec/ 
> package-list
> 
> which in reality is just:
> 
> com.sun.security.jgss
> 
> In other words, both options should be instances of the `-linkoffline` 
> option, which should be of the form:
> 
> -linkofflinehttps:/url/to/api  /path/to/file
> 
> where `/path/to/file` is a local copy of the file downloaded from 
> `https:/url/to/api/package-list`
> 
> Note I am using `.../package-list` in this message because you are using 
> `-source 8`.? If you use a newer version of these APIs, you may need to 
> change `package-list` to `element-list`. (I believe the change happened 
> in JDK 11.)
> 
> For more details on the `-linkoffline` option, see
> https://docs.oracle.com/en/java/javase/22/docs/specs/man/ 
> javadoc.html#option-linkoffline

Jon,

this indeed worked. Thank you very much. I am certain that if 
docs.oracle.com would not misbehave it would work as expected and not 
wasted our time :-(. Hope you can fix that soon.

A similar issue I need to address in upcoming Maven Javadoc Plugin:
https://issues.apache.org/jira/browse/MJAVADOC-656

Best regards,

Michael