RFR: 8322708: Global HTML attributes are not allowed
Pavel Rappo
prappo at openjdk.org
Tue Jun 11 12:43:14 UTC 2024
On Tue, 11 Jun 2024 11:51:05 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Can I please get a review for this change, that aims to add support for Global HTML tags.
>> Here is the [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html) to the generated docs.
>> Thanks in advance.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line 513:
>
>> 511: VSPACE,
>> 512: WIDTH,
>> 513: ACCESSKEY,
>
> Maybe add a comment `// Global attributes` above this line to indicate the start of global attributes, so future attributes are added to the correct section?
Either what Chen has suggested or re-sort the complete list alphabetically as it was prior to this change, well, almost.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19652#discussion_r1634810052
More information about the javadoc-dev
mailing list